Search Unity

Discussion Breaking API change in 1.4.0

Discussion in 'Netcode for GameObjects' started by cerestorm, May 3, 2023.

  1. cerestorm

    cerestorm

    Joined:
    Apr 16, 2020
    Posts:
    666
    This is a heads up to anyone using NetworkShow in their projects and considering updating to 1.4.0.

    Previously NetworkShow and NetworkHide gave full control over spawning objects on clients which is essential in some use cases. In 1.4.0 NetworkShow now makes a networkObject.CheckObjectVisibility call and won't spawn that object if it returns false. This is a breaking change without an easy workaround provided.

    In my view changing longstanding API behaviour like this is a no-no, I don't think the impact of this change was fully understood or considered.

    Here's the pull request for the change.

    And an issue raised on the subject.
     
    LaneFox likes this.