Bug (IN-25763) [1.0.0-pre.44] Baker to client world and server world not working properly

For completeness, duplication of: https://forum.unity.com/threads/client-and-server-only-baking-issue.1371600/

 

Hey! It is on our radar and we will try to fix ASAP. Of course I could repro it. The logic has been already changed in 1.0-pre.15, so that problem specifically is gone. But we have others.

 

I'm actually surprised. We have that specific issue fixed in 1.0-pre.44 and we tested that client and client server build get the correct values from the GetNetcodeTarget function.

 

I tested in your project and the value I get from the GetNetcodeTarget is exactly what I expect in the editor. It depends from the DotsSettings current configuration.
You are not using platform, as such the only thing that affect in the editor the GetNetcodeTargent (at baking time) are the DotsSettings setup by the baker when it creates the baking settings.

And since runtime baking is not supported anymore baking only occurs in the editor. Let's clarify how it work, because there may be a misunderstand here.

The SubSceneImporter use the DotsGlobalSettings and try to find, base on the GUID passed the BuildConfiguration (hash128) with setting should be applied. In case the BuildConfiguration field is not assigned or is assigned to an unknown configuration, the current default for the DotsGlobalSettings.GetPlayerType() is used. Either NetcodeClientSettings or NetcodeServerSettings. The first one then, can let you choose which configuration you want (client-only, client/server) for the client world.

In the editor, the sub-scene are baked:
- LiveConversoin
- When entering playmode
- Making a build

LiveConversion use pretty much the default DotsGlobalSettings (the BuildConfiguration should be not set).

When entering playmode, netcode has two systems:
- ConfigureServerGUIDSystem
- ConfigureClientGUIDSystem

They are executed only in the editor and they setup the SceneSystem.BuildConfiguration to use for the baking for the server and client world respectively.

The first time you enter playmode, or if there is a change that invalidate the bake, scenes are baked again, once for each world (an entry in SceneDependencyCache is what trigger that, via one of the Asset Worker processes).

At this point, the baking settings are constructed and the GetNetcodeTargent will retrieve the settings to use for the current temporary baking world.

The GetNetcodeTarget(bool isPrefab) accept a bool params that is in practice never used (apart tests) because the DotsSettings is always present.

Now, which part of that does not work? Because I tried my self, in your project and the settings are passed as expected in the editor.

NOTE:
I think there is still an issue (not netcode specific) that sometime the asset processor does not get the correct up-to-date value of the setting.

 

As a final note, in you project you have this system:

Code (csharp):

1.  
2. [WorldSystemFilter(WorldSystemFilterFlags.Editor)]
3. [UpdateInGroup(typeof(InitializationSystemGroup))]
4. [AlwaysSynchronizeSystem]
5. public partial class ConfigureEditorSystem : SystemBase
6. {
7.     protected override void OnCreate() { }
8.    
9.     protected override void OnUpdate()
10.     {
11.         if (UnityEditor.EditorApplication.isPlaying)
12.             return;
13.        ...        
14.         sceneSystemGuid.BuildConfigurationGUID = DotsGlobalSettings.Instance.GetClientGUID(); // <----
15.        ....      
16.         Enabled = false;
17.     }
18. }
19.  

This is forcing in the editor all the Live Conversion (and only these) to be Client only (so no client-server).

 

I need to check again. But I wanted to understand first why you say it does not work as expected.

 

Like 49? Which file?