Search Unity

  1. Unity support for visionOS is now available. Learn more in our blog post.
    Dismiss Notice

Question why my player are moving so slow on unity 3d

Discussion in 'Scripting' started by Teresiaqizz, Dec 3, 2023.

  1. Teresiaqizz

    Teresiaqizz

    Joined:
    Dec 3, 2023
    Posts:
    3
    My character is super slow, even if I set the speed to 100f it doesn’t change the speed of the player.

    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class playerMovenment : MonoBehaviour
    6. {
    7.  
    8.     public float turnspeed = 200f;
    9.     public float frameRate0 = 2;
    10.     public float walkspeed = 80f;
    11.  
    12.     Animator m_Animator;
    13.     Rigidbody m_Rigidbody;
    14.  
    15.     Vector3 m_Movement;
    16.     Quaternion m_Quaternion = Quaternion.identity;
    17.  
    18.     // Start is called before the first frame update
    19.     void Start()
    20.     {
    21.         m_Animator = GetComponent<Animator>();
    22.         m_Rigidbody = GetComponent<Rigidbody>();
    23.  
    24.     }
    25.  
    26.  
    27.  
    28.     private void FixedUpdate()
    29.     {
    30.         float horizontal = Input.GetAxis("Horizontal");
    31.         float vertical = Input.GetAxis("Vertical");
    32.  
    33.         m_Movement.Set(horizontal, 0f, vertical);
    34.         m_Movement.Normalize();
    35.  
    36.         bool hasHorizontalInput = !Mathf.Approximately(horizontal, 0f);
    37.         bool hasVerticalInput = !Mathf.Approximately(vertical, 0f);
    38.         bool iswalking = hasHorizontalInput || hasVerticalInput;
    39.         m_Animator.SetBool("iswalking", iswalking);
    40.  
    41.         Vector3 desirForward = Vector3.RotateTowards(transform.forward, m_Movement, turnspeed * Time.deltaTime, 0f);
    42.         m_Quaternion = Quaternion.LookRotation(desirForward);
    43.  
    44.  
    45.  
    46.  
    47.     }
    48.  
    49.  
    50.     private void OnAnimatorMove()
    51.     {
    52.         m_Rigidbody.MovePosition(m_Rigidbody.position + m_Movement * m_Animator.deltaPosition.magnitude);
    53.         m_Rigidbody.MoveRotation(m_Quaternion);
    54.  
    55.  
    56.  
    57.     }
    58. }
    59.  
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,271
    Serialized / public fields in Unity are initialized as a cascade of possible values, each subsequent value (if present) overwriting the previous value:

    - what the class constructor makes (either default(T) or else field initializers, eg "what's in your code")

    - what may be saved with the prefab

    - what may be saved with the prefab override(s)/variant(s)

    - what may be saved in the scene and not applied to the prefab

    - what may be changed in the scene and not yet saved to disk

    - what may be changed in OnEnable(), Awake(), Start(), or even later

    Make sure you only initialize things at ONE of the above levels, or if necessary, at levels that you specifically understand in your use case. Otherwise errors will seem very mysterious.

    Here's the official discussion: https://blog.unity.com/technology/serialization-in-unity

    If you must initialize fields, then do so in the void
    Reset()
    method, which ONLY runs in the UnityEditor.

    Field initializers versus using Reset() function and Unity serialization:

    https://forum.unity.com/threads/sensitivity-in-my-mouselook-script.1061612/#post-6858908

    https://forum.unity.com/threads/crouch-speed-is-faster-than-movement-speed.1132054/#post-7274596

    To avoid complexity in your prefabs / scenes, I recommend NEVER using the
    FormerlySerializedAsAttribute







    If that's not it then it is...

    Time to start debugging!

    By debugging you can find out exactly what your program is doing so you can fix it.

    Here is how you can begin your exciting new debugging adventures:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the names of the GameObjects or Components involved?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    Visit Google for how to see console output from builds. If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer for iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    If your problem is with OnCollision-type functions, print the name of what is passed in!

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    If you are looking for how to attach an actual debugger to Unity: https://docs.unity3d.com/2021.1/Documentation/Manual/ManagedCodeDebugging.html

    "When in doubt, print it out!(tm)" - Kurt Dekker (and many others)

    Note: the
    print()
    function is an alias for Debug.Log() provided by the MonoBehaviour class.
     
  3. kdgalla

    kdgalla

    Joined:
    Mar 15, 2013
    Posts:
    4,575
    Your code is not actually using walkspeed for anything, so it does not make any difference what you set it to.
     
    Kurt-Dekker likes this.
  4. Teresiaqizz

    Teresiaqizz

    Joined:
    Dec 3, 2023
    Posts:
    3
    yep when i only using turnspeed it not moving so i try to add a walkspeed to let it move
     
  5. Lenakeiz

    Lenakeiz

    Joined:
    Jun 11, 2015
    Posts:
    34
    As @kdgalla pointed out you are not using walkspeed and turnspeed actually only modify the the rotation speed toeards the desired direction.
    I think that you need to try and use walkspeed to adjust the translation of the character.
    Code (CSharp):
    1.     float horizontal = Input.GetAxis("Horizontal");
    2.     float vertical = Input.GetAxis("Vertical");
    3.  
    4.     m_Movement.Set(horizontal, 0f, vertical);
    5.     m_Movement.Normalize();
    6.  
    7.     // This is where the walkspeed should be taken into account
    8.     m_Movement *= walkspeed * Time.deltaTime;
     
    Kurt-Dekker likes this.
  6. Teresiaqizz

    Teresiaqizz

    Joined:
    Dec 3, 2023
    Posts:
    3
    sorry where should i add it on? im changing my code now just delet the walkspeed and keep the turnspeed on but still not working
    Code (CSharp):
    1. public class playermovement : MonoBehaviour
    2. {
    3.     public float speed = 20f;
    4.  
    5.     Animator m_Animator;
    6.     Rigidbody m_Rigidbody;
    7.  
    8.     Vector3 m_Movement;
    9.  
    10.     Quaternion m_Quaternion = Quaternion.identity;
    11.     // Start is called before the first frame update
    12.     void Start()
    13.     {
    14.         m_Animator = GetComponent<Animator>();
    15.         m_Rigidbody = GetComponent<Rigidbody>();
    16.     }
    17.  
    18.  
    19.     private void FixedUpdate()
    20.     {
    21.         float horizontal = Input.GetAxis("Horizontal");
    22.         float vertical = Input.GetAxis("Vertical");
    23.  
    24.         m_Movement.Set(horizontal, 0f, vertical);
    25.         m_Movement.Normalize();
    26.  
    27.         bool hasHorizontalInput = !Mathf.Approximately(horizontal, 0f);
    28.         bool hasVerticalInput = !Mathf.Approximately(vertical, 0f);
    29.         bool iswalking = hasHorizontalInput || hasVerticalInput;
    30.         m_Animator.SetBool("IsWalking", iswalking);
    31.  
    32.         Vector3 desirForward = Vector3.RotateTowards(transform.forward, m_Movement, speed * Time.deltaTime, 0f);
    33.         m_Quaternion = Quaternion.LookRotation(desirForward);
    34.  
    35.     }
    36.  
    37.     private void OnAnimatorMove()
    38.     {
    39.         m_Rigidbody.MovePosition(m_Rigidbody.position+m_Movement*m_Animator.deltaPosition.magnitude);
    40.         m_Rigidbody.MoveRotation(m_Quaternion);
    41.  
    42.     }
    43.  
    44. }
     
  7. kdgalla

    kdgalla

    Joined:
    Mar 15, 2013
    Posts:
    4,575
    If you want faster (bigger) movement, then multiply your movement by walkspeed. For example, whatever distance you move calling m_Rigidbody.MovePosition, you'll move twice as fast if you multiply it by 2.
     
  8. zulo3d

    zulo3d

    Joined:
    Feb 18, 2023
    Posts:
    757
    kdgalla, the walkspeed has walked.

    Teresiaqizz, restore the walkspeed and replace lines 24 and 25 with:

    Code (CSharp):
    1. m_Movement=new Vector3(horizontal,0,vertical).normalized*walkspeed;