Search Unity

Question Why my character glitch when I move it to the left or right?

Discussion in 'Scripting' started by Jhoanabcz, Nov 27, 2022.

  1. Jhoanabcz

    Jhoanabcz

    Joined:
    Nov 27, 2022
    Posts:
    1
    Well, I don't know what happened but I was working and the character move correctly, then I closed the Unity and today I opened it and the glitch started.
    I tried to remove the script and put it on again but it doesn't work, I also tried removing the capsule (character) but it still not working.
    The capsule have the capsule collider, the script an the character controller.
    I'm using Unity 3D 2018.4.36f1



    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class PlayerController : MonoBehaviour
    6. {
    7.     private CharacterController controller;
    8.     private Vector3 direction;
    9.     public float forwardSpeed;
    10.  
    11.     private int desiredLane = 1; // 0: izquierda 1: medio 2: derecha
    12.     public float laneDistance = 4; // distancia entre carriles
    13.  
    14.     public float jumpForce;
    15.     public float Gravity = -20;
    16.     void Start()
    17.     {
    18.         controller = GetComponent<CharacterController>();
    19.     }
    20.  
    21.     // Update is called once per frame
    22.     void Update()
    23.     {
    24.         direction.z = forwardSpeed;
    25.  
    26.         if (controller.isGrounded)
    27.         {
    28.             direction.y = -1;
    29.             if (Input.GetKeyDown(KeyCode.UpArrow))
    30.             {
    31.                 Jump();
    32.             }
    33.         }
    34.         else
    35.         {
    36.             direction.y += Gravity * Time.deltaTime;
    37.         }
    38.  
    39.         //Carril deseado
    40.         if (Input.GetKeyDown(KeyCode.RightArrow))
    41.         {
    42.             desiredLane++;
    43.             if (desiredLane == 3)
    44.                 desiredLane = 2;
    45.         }
    46.  
    47.         if (Input.GetKeyDown(KeyCode.LeftArrow))
    48.         {
    49.             desiredLane--;
    50.             if (desiredLane == -1)
    51.                 desiredLane = 0;
    52.         }
    53.  
    54.         //Calcular donde deberíamos de terminar al movernos
    55.         Vector3 targetPosition = transform.position.z * transform.forward + transform.position.y * transform.up;
    56.         if (desiredLane == 0)
    57.         {
    58.             targetPosition += Vector3.left * laneDistance;
    59.         }
    60.  
    61.         else if (desiredLane == 2)
    62.         {
    63.             targetPosition += Vector3.right * laneDistance;
    64.         }
    65.  
    66.         transform.position = Vector3.Lerp(transform.position, targetPosition, 80 * Time.deltaTime);
    67.     }
    68.  
    69.     private void FixedUpdate()
    70.     {
    71.         controller.Move(direction * Time.fixedDeltaTime);
    72.     }
    73.  
    74.     //Jump
    75.     private void Jump()
    76.     {
    77.         direction.y = jumpForce;
    78.     }
    79. }
    80.  
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,745
    I'm not sure what is going on above... the script looks like a mashup of a Rigidbody script (based on the inappropriate use of FixedUpdate(), which should ONLY be used for Rigidbody physics) and a CharacterController, as well as some weird use of Mathf.Lerp() to move... not really sure where to go with it...

    Here is a super-basic starter prototype FPS based on Character Controller (BasicFPCC):

    https://forum.unity.com/threads/a-basic-first-person-character-controller-for-prototyping.1169491/

    Otherwise if you want to debug the stuff above, here's how to start:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    When in doubt, print it out!(tm)

    Note: the
    print()
    function is an alias for Debug.Log() provided by the MonoBehaviour class.