Where should i dispose NativeArray in a JobComponentSystem?

Hi! Here is my example of code:

Code (CSharp):

1. public class MySystem : JobComponentSystem {
2.         public struct Group {
3.             public ComponentDataArray<MyComponent> components;
4.             public int Length;
5.         }
6.         [Inject] private Group group;
7.  
8.         private struct SomeJob : IJobParallelFor {
9.             [ReadOnly]
10.             public NativeArray<double> values1;
11.             [ReadOnly]
12.             public NativeArray<double> values2;
13.             public NativeArray<MyComponent> data;
14.             public void Execute(int index) {
15.                 MyComponent c = data[index];
16.                 StaticFunctionForDoingStuff(ref c, values1[index], values2[index]);
17.                 data[index] = c;
18.             }
19.         }
20.  
21.         protected override JobHandle OnUpdate(JobHandle inputDeps) {
22.             NativeArray<double> values1 = new NativeArray<double>(group.Length, Allocator.TempJob);
23.             NativeArray<double> values2 = new NativeArray<double>(group.Length, Allocator.TempJob);
24.             for (int i = 0; i < group.Length; i++) {
25.                 //fill values1 and values2 with numbers
26.             }
27.             SomeJob j = new SomeJob() {
28.                 data = group.components.GetChunkArray(0, group.Length),
29.                 values1 = values1,
30.                 values2 = values2
31.             };
32.             return j.Schedule(data.Length, 5);
33.         }
34.     }

In console I have "A Native Collection has not been disposed, resulting in a memory leak. It was allocated at..." message.

I know that I must call j.Complete() and values1.Dispose(); values2.Dispose(), but where?

 

There's an attribute you can add to the native array field in the job. I think it's called [DeallocateNativeContainerOnJobCompletion]. As far as I know, it only works for NativeArray types right now.

 

Thanks, it works!
One another question then. Where can I read about this attributes? I checked documentation, but there is nothing similar there.

 

Yeah, documentation is a little sparse, but remember, this stuff is only in preview . You can also try exploring some of the systems that Unity created. Unity package soures are cached on your machine (appdata/local/unity/cache I think). You can use them for inspiration.

 

@dartriminis is right, you'll learn more about the way everything fits together (and also some options the docs don't even cover yet) than from the docs right now.

 

resuming thread. Does the compiler attribute work with custom NativeContainers?

 

you need to enable it with

[NativeContainerSupportsDeallocateOnJobCompletionAttribute]

.
(only doc about that is here)

 

is [NativeContainerSupportsDeallocateOnJobCompletionAttribute] antiquated now in 2020? I've seen NativeArrays used in ARFoundation examples but have not seen that [] before

 

Isn't SystemBase going to replace JobComponentSystem or am I misunderstanding?

 

how exactly do you specify this attribute?
and where?

 

error CS0592: Attribute 'NativeContainerSupportsDeallocateOnJobCompletion' is not valid on this declaration type. It is only valid on 'struct' declarations.