Search Unity

Resolved When will PRs be merged

Discussion in 'SRP Dev Blitz Day 2022 - Q&A' started by DevDunk, Sep 28, 2022.

  1. DevDunk

    DevDunk

    Joined:
    Feb 13, 2020
    Posts:
    5,060
    I made a few PRs for simple CPU performance improvements on all packages in the graphics repo.

    Is there any change this could be merged soon?

    If so, how does backporting work (as these could probably be backported)? Is this handles by the unity team or do I need to do something?

    https://github.com/Unity-Technologies/Graphics/pull/7657
    https://github.com/Unity-Technologies/Graphics/pull/7656
    https://github.com/Unity-Technologies/Graphics/pull/7655
    https://github.com/Unity-Technologies/Graphics/pull/7655
    https://github.com/Unity-Technologies/Graphics/pull/7653
     
    Last edited by a moderator: Sep 29, 2022
    DevDunk, Sep 28, 2022
    #1
    LaireonGames likes this.

  2. SebLagarde

    SebLagarde

    Unity Technologies

    Joined:
    Dec 30, 2015
    Posts:
    934
    Hi,

    First thanks a lot for your PRs, we appreciate the time you take to create them. We are considering them and we will merge all part required. Those PRs are done on the public repository, as the team now work on a private repository we are currently replicating them, thus why you will not see them merged.
    In our process, we need to QAed the PRs, merge them and we will take care of backporting if this is allowed by our Release Management (the more old is a version, the less non urgent fix we could land). Still we have a lot of PRs to review and process so we also can't jump immediately on your works, it will be review progressively.
     
    SebLagarde, Sep 29, 2022
    #2
    FM-Productions and DevDunk like this.