Search Unity

When I instantiate it spawns multiple prefabs at the same time after I replay the Game

Discussion in 'Scripting' started by GlideWave, Nov 19, 2022.

  1. GlideWave

    GlideWave

    Joined:
    Oct 29, 2022
    Posts:
    2
    so When I die and press replay it will instantiate multiple prefabs at the same time.
    note: the cooldown still works

    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4. using TMPro;
    5.  
    6. public class Score : MonoBehaviour
    7. {
    8.     public int score;
    9.     public int scoreG;
    10.     public TextMeshProUGUI scoreText;
    11.     public TextMeshProUGUI scoreTextG;
    12.     // Start is called before the first frame update
    13.  
    14.  
    15.     // Update is called once per frame
    16.     void Update()
    17.     {
    18.         scoreText.text = score.ToString();
    19.  
    20.         scoreTextG.text = scoreG.ToString();
    21.        
    22.     }
    23.     void OnTriggerEnter2D(Collider2D col){
    24.        
    25.         if(col.gameObject.tag == "Enemy" ){
    26.             score++;
    27.            
    28.         }
    29.     }
    30.  
    31. }
     
  2. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    11,500
    You'll need to put more effort into describing the problem here. You're discussing things that are not in the script above i.e. "cooldown", "instantiate multiple prefabs" etc. We don't know anything about your project, you have to be super clear on what you expect to happen and what isn't happening. Also, what debugging have you done.

    Regardless, this isn't a post about 2D, it's a general scripting thing so I'll move your post to the Scripting forum.
     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,745
    That sounds like a bug! Welcome to debugging. Here is how to easily get started fixing your bug:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer or iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    When in doubt, print it out!(tm)

    Note: the
    print()
    function is an alias for Debug.Log() provided by the MonoBehaviour class.
     
  4. GlideWave

    GlideWave

    Joined:
    Oct 29, 2022
    Posts:
    2
    I fixed it
     
    Kurt-Dekker likes this.