Weapon Switch performance issue

Hey everyone,

I was wondering if anyone had implemented weapon switching in a game and if you had performance issues. At the moment I am disabling the gameobject of the weapon I want to swap out and the weapon that is swapped in is set to active, it seems that the main performance issue comes from all the OnStarts of the script activation upon swap. So in these next screenshots the Shooter and AudioController scripts are both in the weapon.

I noticed that if I spam the swap weapon I have spikes in the Profiler:

Profiler before:

Profiler after:

This is the Start of the AudioController

Code (CSharp):

1.     void Start()
2.     {
3.         gManager = GameManager.Instance;
4.         source = GetComponent<AudioSource>();
5.         canPlay = true;
6.         shotgunReloader = GetComponentInParent<WeaponReloader>();
7.     }

This is the Start of the Shooter script:

Code (CSharp):

1.         pooler = ObjectPooler.Instance;
2.         playerNetwork = GetComponentInParent<PlayerNetwork>();
3.         isSwinging = false;
4.         gManager = GameManager.Instance;

Is there anything I could change?

 

Hard to say if 1ms for 1 frame is really that much of a performance issue, but you could always start the game with all these scripts active and then de-active them at the end of Start() and consider it part of the loading process.

 

You could try to move the "GetComponent" methods into Awake, otherwise, "object pooling" maybe the next step in performance increase.

 

Thanks for the responses!

I did what Grozzler suggested and it seems to have helped.

Already have some object pooling going on, wanted to see what I could do increase the FPS of my game. By far the most heavy stuff is the renderPipeline, it seems that the Universal Render Pipeline Camera Stack is taking as long as 12ms to do which I'm not sure is normal.

 

You have to dig down further in that profiler sample. It's probably something like real time shadows or whatever, but it's hard to tell when all we're seeing is RenderSingleCamera.

 

I am not sure why there are 5 calls, I have all the other cameras disabled apart from the main one and UI but it still seems to call them?
Hopefully this shows more:

 

I don't see any performance issues. All of the "Self ms" times are basically 0, which is how long those specific functions take to run. You probably just have Vsync on and there's a Gfx.WaitForPresent() in there idling around the bottom of your profiler.