Search Unity

  1. Unity 6 Preview is now available. To find out what's new, have a look at our Unity 6 Preview blog post.
    Dismiss Notice
  2. Unity is excited to announce that we will be collaborating with TheXPlace for a summer game jam from June 13 - June 19. Learn more.
    Dismiss Notice
  3. Dismiss Notice

Discussion WaterSystemDef.cs

Discussion in 'Unity 6 Beta' started by Amplify_David, Jan 16, 2024.

  1. Amplify_David

    Amplify_David

    Joined:
    Mar 29, 2023
    Posts:
    210
    Hello Unity Beta Team,
    Please can you pass this along to the team working on water systems.
    I like to give a heads up to unity that WaterSystemDef.cs will likely conflict with multiple developer's assets and or any shaders ever made by unity users.

    First found in 2023.3.0b3
    for this example, we will look at case use:

    Generated from UnityEngine.Rendering.HighDefinition.ShaderVariablesWater
    float _FoamSmoothness;
    float _WaterSmoothness;

    above are very commonly used by countless assets over the years.
    with WaterSystemDef.cs they will all get redefinition errors 2023.3.0b3


    Suggestion
    consider use a namespace or use something not so commonly used by so many others.

    Cheers
     
    Last edited: Jan 17, 2024
  2. Amplify_David

    Amplify_David

    Joined:
    Mar 29, 2023
    Posts:
    210
    @BenCloward
    for your info see above this will also break Shader Graph.

    to replicate in SG
    --- 2023.3.0b3
    --- open new graph add float _WaterSmoothness
    and or
    --- open new graph add float _FoamSmoothness
    --- set on a material with surface type Transparent
    --- observe error and pink

    Cheers