Very stuttery movement

Hi, I'm trying to make a gun that currently moves around the player when the player rotates. It works currently but is very buggy and moves back and forth extremely snappy. Why is this happening?

Code (CSharp):

1. using UnityEngine;
2.  
3. public class GunController : MonoBehaviour
4. {
5.     [Header("Objects")]
6.     public Transform camera;
7.  
8.     [Header("Gun Settings")]
9.     //Aiming
10.     public Vector3 normalLocalPosition;
11.     public Vector3 aimingLocalPosition;
12.     public Vector3 weaponDistanceAmount;
13.  
14.     public float aimSmoothing = 10;
15.  
16.     [Header("Mouse Settings")]
17.     public float mouseSensitivity = 1;
18.     private Vector2 _currentRotation;
19.     public float weaponSwayAmount = 10;
20.  
21.     private void Update()
22.     {
23.         DetermineRotation();
24.     }
25.  
26.     private void DetermineRotation()
27.     {
28.         Vector2 mouseAxis = new Vector2(Input.GetAxisRaw("Mouse X"), Input.GetAxisRaw("Mouse Y"));
29.  
30.         mouseAxis *= mouseSensitivity;
31.         _currentRotation += mouseAxis;
32.  
33.         _currentRotation.y = Mathf.Clamp(_currentRotation.y, -90, 90);
34.  
35.         transform.localPosition = (Vector3)mouseAxis + weaponDistanceAmount;
36.  
37.         transform.root.localRotation = Quaternion.AngleAxis(_currentRotation.x, Vector3.up);
38.         camera.localRotation = Quaternion.AngleAxis(-_currentRotation.y, Vector3.right);
39.  
40.     }
41. }

 

You should use Time.deltaTime to smooth movements.
Depending on how you game is running, Update() is called multiple items per seconds. If it's running at 60 fps then it's 60 calls to Update() par second so there's ~ 0.016 second between each call. So a movement of 10 degrees per frame would quickly make you spinning really fast.

If you multiply mouseAxis by Time.deltaTime, speed will be easier to adjust because you can think about it in a more humain understandable way : If you want your object to rotate at a speed of 90 degrees per second you should add 90 * Time.deltaTime to it's current rotation, giving you a smooth and constant movement.

_currentRotation += mouseAxis * Time.deltaTime;

I would also recommend to reorganize your gameobject hierarchy like this :

You can use Player transform to change position, camera to change rotation and you don't need to rotate the Gun because it will follow the camera's rotation. All you need to do is to place correctly the gun relatively to the camera and to rotate the camera.

 

Thanks! I don't believe that I forgot to do that.