Search Unity

  1. Unity Asset Manager is now available in public beta. Try it out now and join the conversation here in the forums.
    Dismiss Notice

Resolved URP performs poorly when used with OpenXR plugin via SteamVR API

Discussion in '2021.1 Beta' started by rz_0lento, Mar 2, 2021.

  1. rz_0lento

    rz_0lento

    Joined:
    Oct 8, 2013
    Posts:
    2,361
    Issue tracker: #1312513

    Issue was introduced in this PR: [11.x.x] Fixed Quest Vsync issue on Unity 21.1 #2588

    I made a workaround for it here: https://github.com/Unity-Technologies/Graphics/pull/3698
    and now Unity has their own workaround here: https://github.com/Unity-Technologies/Graphics/pull/3708

    I also mentioned this on the Unity's PR too but I'm quite worried about their fix as it just tries to set 300 Hz target framerate on all XR devices now (which is a magic number) and this isn't even required on PCVR (original fix that introduced this concept was fixing things on Quest).

    I'm opening this discussion here as I'd love to hear some thoughts around this matter. Is setting 300 Hz even doing any good here (why we need it?). I'm mainly trying to understand what is going on here as without knowing any better, it just looks like a quick fix for one platform made a regression on other platform and now the current patch looks even more hacky..
     
    rz_0lento, Mar 2, 2021
    #1

  2. LeonhardP

    LeonhardP

    Unity Technologies

    Joined:
    Jul 4, 2016
    Posts:
    3,136
    Hi @rz_0lento,

    Thanks for reaching out about this. I've forwarded the thread to the teams.
     
    LeonhardP, Mar 2, 2021
    #2
    rz_0lento likes this.

  3. rz_0lento

    rz_0lento

    Joined:
    Oct 8, 2013
    Posts:
    2,361
    Got staff response on the github:
    I guess it doesn't matter much today since this fix works but I still object in principle for doing extra work / settings on platforms that don't require it :)
     
    rz_0lento, Mar 2, 2021
    #3
    LeonhardP likes this.