Search Unity

  1. Unity 6 Preview is now available. To find out what's new, have a look at our Unity 6 Preview blog post.
    Dismiss Notice
  2. Unity is excited to announce that we will be collaborating with TheXPlace for a summer game jam from June 13 - June 19. Learn more.
    Dismiss Notice

Question [URP 15] Blitting a RenderTexture to screen -- probably obvious

Discussion in 'Universal Render Pipeline' started by bgsulz, Jun 29, 2023.

  1. bgsulz

    bgsulz

    Joined:
    Jan 17, 2019
    Posts:
    4
    TL;DR: How to blit from RenderTexture asset onto screen using RTHandle API?

    I'm making a pixel art game.
    • The camera renders to a lo-res RenderTexture.
    • A custom render pass applies a post-processing material.
    • The same custom render pass blits the processed texture to the screen.
    In older versions of URP, I wrote this:
    Code (CSharp):
    1.  
    2. // src is the lo-res RenderTexture.
    3. // dest is the camera's color target.
    4. Blit(src, dest, material);
    5.  
    I have tried converting this to the new APIs.

    Code (CSharp):
    1.  
    2. // In the feature file:
    3. public override void SetupRenderPasses(ScriptableRenderer renderer, in RenderingData renderingData)
    4. {
    5.     _retroDrawPass.ConfigureInput(ScriptableRenderPassInput.Color);
    6.     _retroDrawPass.SetTarget(renderer.cameraColorTargetHandle, drawSettings.src);
    7. }
    8.  
    9. // In the pass file:
    10. public void SetTarget(RTHandle colorHandle, RenderTexture src)
    11. {
    12.     // These are both of type RTHandle.
    13.     _colorTarget = colorHandle;
    14.     _srcTarget = RTHandles.Alloc(src);
    15. }
    16.  
    17. public override void Execute(ScriptableRenderContext context, ref RenderingData renderingData)
    18. {
    19.     // After setup and profiling...
    20.  
    21.     Blitter.BlitCameraTexture(cmd, _srcTarget, _colorTarget, _passSettings.postMat, 0);
    22. }
    23.  
    This results in three errors.
    Code (JavaScript):
    1.  
    2. [Error] Assertion failed
    3. // The assertion is this: Debug.Assert(handle.m_ExternalTexture != null || handle.rt != null);
    4. // It fails when checking _srcTarget. However, logging _srcTarget.rt == null immediately before blitting prints "False."
    5.  
    6. [Error] ArgumentNullException: Value cannot be null.
    7. // Once again, this is _srcTarget. See above.
    8.  
    9. [Warning] Render Pipeline error : the XR layout still contains active passes. Executing XRSystem.EndLayout() right now.
    10. // This is not an XR game, and I am not using any XR features. I don't quite understand this one.
    11.  
    I am probably using RTHandles incorrectly. I have combed through documentation to no avail. Some more details:
    • I have tried calling ConfigureTarget for _colorTarget as well as for both _colorTarget and _srcTarget. No difference.
    • I get the same errors when writing
      Blitter.BlitCameraTexture(cmd, _colorTarget, _colorTarget, _passSettings.postMat, 0);
      . This suggests that it has nothing to do with _srcTarget.
    • These errors also appear when running Unity's example pass.
    • This is the closest I've come to success:
    Code (CSharp):
    1. Blitter.BlitCameraTexture(cmd, _srcTarget, _srcTarget, _passSettings.postMat, 0);
    2. Blitter.BlitCameraTexture(cmd, _srcTarget, _colorTarget);
    This results in the image being drawn to the screen. The material is not applied.

    Please advise -- I have probably made an obvious mistake.
     
  2. ElliotB

    ElliotB

    Joined:
    Aug 11, 2013
    Posts:
    295
    A side note - if you are using a custom shader you will need to update it for use with the new Blit API, because the inputs for shader programs are different (it is not backwards compatible with old shaders). Check the core blit material shaders for an example of how to change vert/frag. This may be part of your woes.

    (Apologies for not giving more detail, currently not at my pc)
     
  3. bgsulz

    bgsulz

    Joined:
    Jan 17, 2019
    Posts:
    4
    After narrowing down what is a bug and what isn't, I have partially solved the problem.
    • Unity's own Full Screen Pass prints the same three errors. This is a known bug.
    • I circumvented this issue by configuring the Renderer asset. Set "Intermediate Texture" to Always. My custom pass (detailed above) works fine with this toggle enabled.
    • The shader provided here did not work for me. (ElliotB is correct, though. Unity's example doesn't work, for some reason.)
      • Yes, in my case I needed to blit a specific pre-existing render texture, whereas this shader accesses the camera's opaque texture directly. It didn't work even when I tried to just blit the opaque texture.
    • What did work: URP Sample Buffer node in Shader Graph. I recreated my shader in Shader Graph, and it works fine.
      • The way this interacts with Render Textures is strange. The render texture is drawn in the lower left corner independent of screen resolution. It does not scale or stretch. No manipulation of the Blit methods changes this. (I grabbed the method from the package cache and made an overload with scaling. No luck.)
      • I circumvented this in the shader by manipulating the UVs. I'm not satisfied with this solution.
    My inexperience with graphics programming is likely showing. I will provide future updates as I discover more. Even still, I hope this helps future internet searchers.
     
    Coccho, CrazyCode_, Kirsche and 3 others like this.