Search Unity

Unity terrain with Planar Reflection probe crashes in HDRP

Discussion in 'High Definition Render Pipeline' started by nasos_333, Nov 8, 2019.

  1. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Unity terrain with Planar Reflection probe crashes in HDRP


    Is this a known bug ?

    I use Unity 2019.2.9f1 and HDRP 6.9.2

    Thanks
     
  2. Antypodish

    Antypodish

    Joined:
    Apr 29, 2014
    Posts:
    10,775
  3. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
  4. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Bump, this is crucial error, i wonder how is not caught
     
  5. Tomas-Kiniulis

    Tomas-Kiniulis

    Unity Technologies

    Joined:
    Apr 27, 2017
    Posts:
    55
    Last edited: Nov 14, 2019
    nasos_333 likes this.
  6. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi, thanks a lot, i am stuck in my HDRP water demo because cannot use the terrain with the planar reflect probe due to crashes. I use mesh terrain now but would prefer use unity one for final demo and be sure users will not have crashes if use unity terrain.

    I have sent a bug report as well today, for better reference
     
  7. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    I checked the issue tracking, is the votes needed to fix this one ? I mean will be fixed even if not upvoted, or may be fixed much later ?

    I am about to release a new water system and this bug prevents any further action, as i cannot tell which version of unity will play in and where will crash, also is not clear how to prevent this without users upgrading, because most users will simply use the unity version they have, which means instant one star reviews if the asset is released without the planar probe working for everyone, even those that wont upgrade to a new version.

    Is there a script i can add to prevent this crash for example in general case ?

    Thanks
     
  8. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi,

    I have another update on this matter, i have made a custom depth renderer and when i use it with meshes is fine, but when in insert a Unity terrain it crashes, so seems like any other camera trying to render the terrain causes a crash.

    This happened in LWRP, so i think is a global issue and not just in HDRP
     
  9. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi,

    Is there any update on this issue ?

    This renders Unity completely unusable, it should be priority #1 as nothing works now, any system that uses an extra camera cannot be in the Asset Store for any pipeline, as is going to crash when user enters a terrain in the scene.

    This is holding back now two new assets i planned to release, is an extremely unfortunate situation.
     
  10. SebLagarde

    SebLagarde

    Unity Technologies

    Joined:
    Dec 30, 2015
    Posts:
    934
    Hi,
    thanks for having report this issue.
    we have fix the issue but it will be only available in unity binary 2019.3b13.

    (It is because intermediate renderer (i.e terrain) are never freeing per frame with custom SRP camera (i.e planar reflection). The cleanup have been move to camera culling instead.)
     
    nasos_333 likes this.
  11. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi,

    This is great news :)

    So would you suggest i target my new HDRP asset and LWRP asset to Unity 2019.3b13 as first version ?

    Is there a way to overcome this issue for previous versions (as in both new assets i use a 2ond camera, one for planar probe and one for top down rendering of terrain) so i can cover more Unity versions currently in use for the upcoming assets ?

    Thanks
     
  12. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi,

    Is there any update on this issue ? Should all our work on SRPs be moved to Unity 2019.3 beta ? Also the suggested beta with the fix is not released yet.

    It makes no sense that all SRPs so far are unusable because of this issue, it should be patched to all versions so far and not only some future version (where btw nothing currently in development will work as it is so much different than previous SRP versions and is still Beta even)

    Should we make an announcement to all customers that Unity will 100% crash if another camera is used or that they cannot use the Unity terrain ? This renders everything unusable and is a disaster for assets that use such camera.

    Please consider doing a patch for this for all versions so far so we can work, it is not enough to fix in some future version that may release next year.
     
  13. Tomas-Kiniulis

    Tomas-Kiniulis

    Unity Technologies

    Joined:
    Apr 27, 2017
    Posts:
    55
    Hi!

    The fix should come with the release of Unity 2019.3, there's also a backport for 2019.2, but unfortunately, there's no estimated date when the backport will be available.

    Can you share editor logs and repro steps on how you reproduced this in LWRP? The cases I've checked were all tied to HDRP.
     
  14. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi

    I can do a minimal project to reproduce and send tomorrow, generally i call a camera render from a top down camera and repeat it, then when terrain is used crashes. My guess is that is very similar to hdrp crash, both use 2ond camera rendering the terrain
     
  15. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi,

    I sent the crashing project, it is bug Case 1201152, i hope it helps
     
  16. Tomas-Kiniulis

    Tomas-Kiniulis

    Unity Technologies

    Joined:
    Apr 27, 2017
    Posts:
    55
    Hey,

    Thanks for the report! I've checked the project and the crash is identical to the one in HDRP. This is already addressed with 2019.3 upcoming release and will be backported to 2019.2 as well.
     
  17. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    That is great :), thanks.
     
  18. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi,

    Is there any time frame for the backporting to 2019.2, so can be used in pre 2019.3 versions as well ?

    Thanks
     
  19. Tomas-Kiniulis

    Tomas-Kiniulis

    Unity Technologies

    Joined:
    Apr 27, 2017
    Posts:
    55
    Hey,

    A fix for 2019.2 comes with 2019.2.16f1 version of Unity, it should be out in about 3 weeks.
     
    nasos_333 likes this.
  20. nasos_333

    nasos_333

    Joined:
    Feb 13, 2013
    Posts:
    13,351
    Hi,

    Thanks a lot for the heads up, very good news.
     
    Last edited: Dec 12, 2019