Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Bug Unity makes redundant update on my dll (Problem started after upgrading from 2021.3.19 to 2022.2.13)

Discussion in 'Editor & General Support' started by Xtro, Apr 13, 2023.

  1. Xtro

    Xtro

    Joined:
    Apr 17, 2013
    Posts:
    551
    Bug report: https://unity3d.atlassian.net/servicedesk/customer/portal/2/IN-38270
    Issue tracker: https://issuetracker.unity3d.com/is...embly-changes-when-editor-prompts-for-updates

    I use my pre-compiled dlls in my Unity projects. Unity started to warn and make modifications on my dlls after I upgraded my projects from 2021.3.19 to 2022.2.13.

    The source code of my dlls are also upgraded with new Unity dll references from 2022.2.13 and I don't receive any "obsolete api" warnings from Visual Studio when I build my dlls so, I'm 100% sure that my dlls are up-to-date and Unity is trying to modify them redundantly.

    On top of that problem, as can be seen in "b.png", Unity is warning for 4 of my dlls but after I click "Yes", it modifies only one of them. Other 3 aren't modified. This is an extra inconsistency problem.

    In Editor.log I attached, you can see that Unity is trying to replace "System.Runtime.CompilerServices.IsExternalInit" with the exact same thing so this dll update warning and the actual modification Unity does is REDUNDANT.

    If I click "No" in the update warning dialog, Unity doesn't modify my dlls and everything works perfectly fine. This is another proof of Unity's dll modification is redundant.

    My dlls are published to my customers via my products. Unity showing my customers an update warning for my dlls is a big problem for me. Can you please fix this problem?

    Repro Steps:
    1) Extract My Project.zip (Don't open it in Unity yet).
    2) Make a copy of Assets\DLLs folder to somewhereelse outside of the project folder.
    3) Open my project with Unity 2022.2.13.
    4) Wait for Unity to import files and see the dll update dialog similar to my b.png.
    4.b) Notice that there are 4 dlls reported in the dialog.
    5) Click Yes.
    6) Check your local Editor.log and see the update about "System.Runtime.CompilerServices.IsExternalInit". This class is being replaced with itself by Unity. This is the main bug.
    7) Compare the backup of DLLs folder with the DLLs folder in my project folder via a folder/file comparision tool like "BeyondCompare" and see that Unity modified only 1 dll called "Atesh.MagicAutoLinker.Editor".
    7.b) Despite 4 dlls being reported in the update dialog, only 1 of them gets updated. This is a secondary problem.
     

    Attached Files:

    Last edited: Apr 19, 2023
    tsukimi likes this.
  2. Xtro

    Xtro

    Joined:
    Apr 17, 2013
    Posts:
    551
    Today, Unity QA team closed my ticket with the status of "As Designed". Doing redundant things and causing error messages in console is "As Designed" for Unity, and not for the first time. They did this in the past too :( :( I'm so sad.
     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,713
  4. Xtro

    Xtro

    Joined:
    Apr 17, 2013
    Posts:
    551
    I have been using pre-compiled DLLs for my library projects within Unity for many years. Never had problems with source control. Sorry to hear you experienced them :(
     
  5. AdrianoVerona_Unity

    AdrianoVerona_Unity

    Unity Technologies

    Joined:
    Apr 11, 2013
    Posts:
    317
    Hi, sorry that was my fault; I overlooked it.

    I've reopened it and after some investigation I have found the cause.

    There's one bug and one behavior that is arguable, but not technically wrong. Most likely we'll address both.

    Regardless, I'll update the case with that information and see how to address.
     
    Last edited: May 1, 2023
    tsukimi likes this.
  6. Xtro

    Xtro

    Joined:
    Apr 17, 2013
    Posts:
    551
    Thank you very much. This made me happy, seeing an official reply and willingness to help. Thank you.