Search Unity

  1. Megacity Metro Demo now available. Download now.
    Dismiss Notice

Undo not working

Discussion in 'World Building' started by pbritton, Jan 3, 2020.

  1. pbritton

    pbritton

    Joined:
    Nov 14, 2016
    Posts:
    159
    I have recently ran into this problem and I am not sure what could be the cause but it is rather frustrating. When I undo, changes the Pro Builder "wireframe" is undone but the geometry remains the same.
    Image
     
    Last edited: Jan 3, 2020
  2. gabrielw_unity

    gabrielw_unity

    Unity Technologies

    Joined:
    Feb 19, 2018
    Posts:
    963
    Hi! Neat looking level!

    Could you give me a bit more info please:
    - version of Unity
    - version of ProBuilder
    - does it always happen? only sometimes? perhaps only with prefabs, etc?

    Thanks!
     
  3. pbritton

    pbritton

    Joined:
    Nov 14, 2016
    Posts:
    159
    I am sorry for the lack of info the initial post.
    Unity 2019.3.b12
    ProBuilder 4.1.2
    It was happening regularly but now its not happening.:confused: I will try to replicate the problem.
     
  4. gabrielw_unity

    gabrielw_unity

    Unity Technologies

    Joined:
    Feb 19, 2018
    Posts:
    963
    Ok! Just let me know if you find a definite set of repro steps :)
     
  5. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    I am having this issue as well. Undo does not work in ProBuilder at all.

    Undoing simply undo's the selection of the game object, regardless of the number of edits I make to vertices using any of the tools. (For clarity I'm editing a simple game object that has a single box mesh made in the editor)

    Unity: 2020.1.a20.2541
    ProBuilder: 4.2.3

    I'm going to try upgrading to Preview.2 4.3.0
     
  6. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    After upgrade to 4.3.0 the issue I'm experiencing is the same. I undo and the wireframe reverts but not the mesh. I created a new shape from the probuilder menu and moved a face down, then tried to undo:
    upload_2020-2-29_9-26-0.png

    If it helps, I'm using HDRP.
     
  7. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    A few more screenshots of the issue
    Moving a vertex right and undoing (then I can select the vertex)
    upload_2020-2-29_9-33-18.png

    Moving a face:
    upload_2020-2-29_9-34-49.png

    Moving an edge:
    upload_2020-2-29_9-34-13.png
     
    Last edited: Feb 29, 2020
  8. antoinebr_unity

    antoinebr_unity

    Unity Technologies

    Joined:
    Nov 16, 2018
    Posts:
    23
    Hi, I wasn't able to reproduce on my side, so here's a couple of quick questions:
    - Do you have any errors or warnings when undoing?
    - What's your build target platform?
    - Are you on Windows or Mac?
    - Are you using polybrush? We've had issues in the past with probuilder and polybrush acting weird together, but it should be fixed now.
     
  9. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    Hiya,

    Answers:
    - Do you have any errors or warnings when undoing?
    None (first thing I checked)

    - Are you on Windows or Mac?
    - What's your build target platform?
    I'm developing on Windows targeting Windows/x86_64.

    - Are you using polybrush? We've had issues in the past with probuilder and polybrush acting weird together, but it should be fixed now.
    *Not* using polybrush
     
  10. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    I even tried creating a brand new project with the HDRP template and was able to repro.

    Steps:
    1. Install Unity Hub 2.3.0, Install Unity 2019.3.0f3
    2. Click New -> High Definition RP, Name project, select location Click Create
    3. Open project and browse to Package manger
    4. Install ProBuilder 4.1.2 (2019.3 verified)
    5. Tools -> ProBuilder -> ProBuilder Window
    6. Click first tool function (New Shape)
    7. Select the second tool icon (vertex selection)
    8. Select any vertex, move the vertex
    9. CTRL+Z to undo
    10. --> Nothing happens
    11. Hover the mouse over the object
    12. --> The vertex position actually was undone, but the mesh remains the same
    13. Select the vertex again in it's original position
    14. --> The mesh remains broken, unable to select the previous vertex
    15. Move the selected vertex (original)
    16. --> The mesh updates correctly

    I'll get a video of this going.
     
  11. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
  12. neil_devine

    neil_devine

    Unity Technologies

    Joined:
    Apr 8, 2018
    Posts:
    42
    Hi, thank you for figuring out a small repro case, could you enter a bug and post the case number here ? That way you will be notified when it is fixed.
     
    EthanFischer likes this.
  13. a_radarhead

    a_radarhead

    Joined:
    Feb 3, 2020
    Posts:
    5
    I've experienced this issue as well, usually seems to occur with the first sculpt edit of a session. Undo usually works fine afterwards, but will not affect the first change made to the mesh.
     
  14. EthanFischer

    EthanFischer

    Joined:
    Feb 10, 2016
    Posts:
    46

    @BihtSift did you submit a bug for this? I tried to repro in a new project following these steps but couldn't. But I am experiencing this same issue in my project. Not sure what's causing it
     
  15. unity_ozNDYmwdlHY3-g

    unity_ozNDYmwdlHY3-g

    Joined:
    Jul 2, 2019
    Posts:
    5
    This is happening to me as well. Its rather annoying. I am using HDRP in 19.4.3 did you find any fix?
     
  16. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    I'm sorry for necroing my old thread, and I'm sorry for how long this has taken me but I've submitted a proper bug report since this is still happening in the latest version of Unity and ProBuilder.

    I've confirmed that this is an issue specifically with the HDRP template in UnityHub rather than the HDRP package. If a project is created with a 3d template instead and the HDRP and ProBuilder packages are installed after, undoing works just fine.

    The case id is:
    1277437
     
  17. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    kaarrrllll likes this.
  18. kaarrrllll

    kaarrrllll

    Unity Technologies

    Joined:
    Aug 24, 2017
    Posts:
    552
    Thanks for the bug report, I was able to reproduce it immediately and have just submitted a fix.
     
    BihtSift likes this.
  19. BihtSift

    BihtSift

    Joined:
    Aug 25, 2017
    Posts:
    13
    That was quick! Thank you!
     
  20. michealcaj

    michealcaj

    Joined:
    Aug 18, 2017
    Posts:
    191
    Hmmmmm
     
    Bennidhamma2 likes this.
  21. Bennidhamma2

    Bennidhamma2

    Joined:
    Jan 5, 2019
    Posts:
    23
    I'm seeing this as well. Hitting undo reverts changes to the mesh, and resets UV textures.
     
  22. Bennidhamma2

    Bennidhamma2

    Joined:
    Jan 5, 2019
    Posts:
    23
    Annoyingly, it looks like even using undo after editing with probuilder causes it to revert. so I basically can't use undo at all anymore in my scene.
     
  23. kaarrrllll

    kaarrrllll

    Unity Technologies

    Joined:
    Aug 24, 2017
    Posts:
    552
    What versions of Unity and ProBuilder are you using?
     
  24. Bennidhamma2

    Bennidhamma2

    Joined:
    Jan 5, 2019
    Posts:
    23
    Very reasonable questions. :)

    Unity 2021.1.0b10.2062 and ProBuilder 5.0.0-pre.7 RC

    I just noticed that there is an update to 5.0.1 and am trying that out now.
     
  25. arminiuspp

    arminiuspp

    Joined:
    Jun 15, 2020
    Posts:
    54
    I got a problem too. Undo (ctrl Z) just resets my edited cube back to cube :(. I am using unity 2021.1beta
     
  26. Bennidhamma2

    Bennidhamma2

    Joined:
    Jan 5, 2019
    Posts:
    23
    Did you update? Updating to probuilder 5.0.1 seemed to help for me.
     
  27. arminiuspp

    arminiuspp

    Joined:
    Jun 15, 2020
    Posts:
    54
    I
    I haven't I'll try updating now, thanks