Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.

Bug Tons of Assets broke with minor Editor Release (2022.3.10f1)

Discussion in 'Editor & General Support' started by Daxten, Sep 26, 2023.

  1. Daxten

    Daxten

    Joined:
    Sep 20, 2013
    Posts:
    30
    between .3.9 and .3.10 hdrp was changed that most custom shaders from the asset store / my own shaders break. imo this shouldn't happen in a minor release.

    Couldn't open include file 'Packages/com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ShaderGraphHeader.hlsl

    the file in question was removed it seems
     
  2. unity_89557FEDC9906EDF2EE0

    unity_89557FEDC9906EDF2EE0

    Joined:
    Aug 29, 2023
    Posts:
    7
  3. SebLagarde

    SebLagarde

    Unity Technologies

    Joined:
    Dec 30, 2015
    Posts:
    932
    Hi, we are aware of this issue and indeed have underestimate side effect of a previous fix.
    We are sorry about that and re working urgently on getting this solve (PR already ready).

    To fix locally you can replace include of ShaderGraphHeader.hlsl by

    'Packages/com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ShaderGraphHeader.hlsl

    #include "Packages/com.unity.shadergraph/ShaderGraphLibrary/Functions.hlsl"

    The PR we are doing si recreating the file ShaderGraphHeader.hlsl
    which will include this file
    #include "Packages/com.unity.shadergraph/ShaderGraphLibrary/Functions.hlsl"

    This affect version 23.3, 23.2, 23.1, 22.3 and 21.3
     
  4. SebLagarde

    SebLagarde

    Unity Technologies

    Joined:
    Dec 30, 2015
    Posts:
    932
    Update, those are all the versions where the fix for this issue have landed

    2023.3.0a9
    2023.2.0b13
    2023.1.17f1
    2022.3.11f1
    2021.3.32f1
     
  5. unity_89557FEDC9906EDF2EE0

    unity_89557FEDC9906EDF2EE0

    Joined:
    Aug 29, 2023
    Posts:
    7
    When are we getting those unity versions in unity hub? Cant find them in download archive neither...
     
    makaka-org and mikulic_martin like this.
  6. SebLagarde

    SebLagarde

    Unity Technologies

    Joined:
    Dec 30, 2015
    Posts:
    932
    They are not available yet, those are all the next release. That's should be around 2 weeks but this can vary.
     
  7. jbooth

    jbooth

    Joined:
    Jan 6, 2014
    Posts:
    5,452
    Sine most of us have to support multiple versions of Unity, unlike unity whcih freely breaks stuff and doesn't have to support previous versions, here's how you do a proper fix:

    Code (CSharp):
    1. #if UNITY_VERSION >= UNITY_2021_3_31
    2.        #include "Packages/com.unity.shadergraph/ShaderGraphLibrary/Functions.hlsl" // Need to be here for Gradient struct definition
    3. #else
    4.         #include "Packages/com.unity.render-pipelines.high-definition/Runtime/ShaderLibrary/ShaderGraphHeader.hlsl"
    5. #endif    

    Note that the documentation around UNITY_VERSION is incorrect, and tells you to use 2021331 as the unity version number, but this technique only works up to version x.x.9, so you have to figure out on your own that you can use UNITY_2021_3_31 as a version number.
     
  8. JiRo_Dev

    JiRo_Dev

    Joined:
    Jun 8, 2018
    Posts:
    21
    Honorable mentions of Unity's lovely policy of making absolutely unnecessary changes to the most fine working features:

    Deprecating:
    Code (CSharp):
    1. Resolution.refreshRate
    In favor of:
    Code (CSharp):
    1. Resolution.refreshRateRatio.Value
    Deprecating:
    Code (CSharp):
    1. RenderTargetHandle
    In favor of:
    Code (CSharp):
    1. RTHandle
    Just WHY?!
    80% of the stuffs on your roadmap have been in-progress for 3+ years, it's not like you have nothing to do so you mess with simple stuffs like RefreshRate out of boredom.
     
  9. bluescrn

    bluescrn

    Joined:
    Feb 25, 2013
    Posts:
    631
    Don't get me started on RenderTarget changes...

    I'm working on a URP project in 2021 LTS that makes heavy use of custom RendererFeatures (including a TAA package that's not been updated to 2022, and an outline renderer from the asset store that's been modified to work with the TAA, so not just trivial features). Moving from 2021->2022 is *not* going to be fun.

    (From my initial investigation, they didn't just change the way RT handles work, they changed the internals of blitting shaders, too. And I haven't dared look at 2023 yet after reading about even more severe breaking changes planned to the handling of render targets)
     
    JiRo_Dev likes this.
  10. JiRo_Dev

    JiRo_Dev

    Joined:
    Jun 8, 2018
    Posts:
    21
    Oh yeah, I also have some volumetric effects as render feature in 2021 LTS and I just kissed them goodbyes when I moved to 2022 LTS, I couldn't figure out how the hell RTHandle works so I just gave up and used other techniques.