Bug System updates even with disabled component

Hi folks! I created simple system with RequireForUpdate and I want to not update this system if there is zero enabled DisabledComponent. Is it possible for now?

Code (CSharp):

1. public struct DisabledComponent : IComponentData, IEnableableComponent
2. {
3.     public int Value;
4. }
5.  
6. public partial struct TestSystem : ISystem
7. {
8.     public void OnCreate(ref SystemState state)
9.     {
10.         state.RequireForUpdate<DisabledComponent>();
11.     }
12.  
13.     public void OnDestroy(ref SystemState state)
14.     {
15.     }
16.  
17.     public void OnUpdate(ref SystemState state)
18.     {
19.         UnityEngine.Debug.Log("updated");
20.         foreach (var component in SystemAPI.Query<RefRW<DisabledComponent>>())
21.         {
22.             component.ValueRW.Value++;
23.         }
24.     }
25. }

 

I think it might be intentional.
If RequireForUpdate would support Filtering on the Enableable types it would introduce a sync point because it'd need to complete any job that is working with the component.

RequireForUpdate uses EntityQuery::IsEmptyIgnoreFilter under the hood (see SystemState::ShouldRunSystem).

If you don't mind the sync point & think the performance of the game would benefit from it you can add this to the start of your OnUpdate():

Code (CSharp):

1. if (_requiredQuery.IsEmpty) return;

I have that in some places in my codebase.

 

A Disabled Component will not show up in a Query; only Enabled Components return a result - https://docs.unity3d.com/Packages/com.unity.entities@1.0/manual/components-enableable-use.html
Only Enabled Disabled Components in your Query will contribute to the count of the loop. Your loop will not run if all Components are Disabled.