Question storing singleton reference or not for performance benefit?

Hi,

Would I get much more benefit by storing frequently used references within the instance ?

Code (CSharp):

1. void Update()
2. {
3.     GameManager.Instance.playerCombat.DoSomething();
4. }

vs

Code (CSharp):

1. void Start()
2. {
3.     PlayerCombat _pc = GameManager.Instance.playerCombat;
4. }
5. void Update()
6. {
7.     _pc .DoSomething();
8. }

 

You will get a benefit as soon as accessing the singleton every frame becomes a bottleneck. As in, once you have performance issues and you profiled your game and you figured the problem is accessing the Instance property every frame, then, and only then, you should worry about it.

 

Nope.

 

Very informative