Search Unity

Question Stopping an Animation

Discussion in 'Animation' started by Goostoph_Banana, Dec 21, 2023.

  1. Goostoph_Banana

    Goostoph_Banana

    Joined:
    Aug 2, 2023
    Posts:
    1
    I am working on a 2d platformer, and I have an idle and running animation. However, when I start the running animation, both the running and idle animation play, so I need a way to stop the idle animation when the running animation starts via code. All of the solutions I have found in Google either no longer work or disable the entire function. Below is my code for the animation. Any help would be greatly appreciated.

    Variables:
    Animator animator

    Void Start()
    {
    animator = GetComponent<Animator>();
    }

    Void Update()
    {
    if (Input.GetKey(KeyCode.A))
    {
    animator.Play("Player Movement");
    } else {
    animator.Play("Player Idle");
    }

    if (Input.GetKey(KeyCode.D))
    {
    animator.Play("Player Movement");
    }
    else
    {
    animator.Play("Player Idle");
    }

    }
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,692
    Animation solutions are always a combination of code and the Animator state machines, so keep the Animator window open (and the Animator itself selected in the inspector) when debugging your code above.

    Time to start debugging!

    By debugging you can find out exactly what your program is doing so you can fix it.

    Here is how you can begin your exciting new debugging adventures:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the names of the GameObjects or Components involved?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    Visit Google for how to see console output from builds. If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer for iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    If your problem is with OnCollision-type functions, print the name of what is passed in!

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    If you are looking for how to attach an actual debugger to Unity: https://docs.unity3d.com/2021.1/Documentation/Manual/ManagedCodeDebugging.html

    "When in doubt, print it out!(tm)" - Kurt Dekker (and many others)

    Note: the
    print()
    function is an alias for Debug.Log() provided by the MonoBehaviour class.



    If you get stuck...

    How to report your problem productively in the Unity3D forums:

    http://plbm.com/?p=220

    This is the bare minimum of information to report:

    - what you want
    - what you tried
    - what you expected to happen
    - what actually happened, log output, variable values, and especially any errors you see
    - links to actual Unity3D documentation you used to cross-check your work (CRITICAL!!!)

    The purpose of YOU providing links is to make our job easier, while simultaneously showing us that you actually put effort into the process. If you haven't put effort into finding the documentation, why should we bother putting effort into replying?



    If you post a code snippet, ALWAYS USE CODE TAGS:

    How to use code tags: https://forum.unity.com/threads/using-code-tags-properly.143875/

    - Do not TALK about code without posting it.
    - Do NOT post unformatted code.
    - Do NOT retype code. Use copy/paste properly using code tags.
    - Do NOT post screenshots of code.
    - Do NOT post photographs of code.
    - Do NOT attach entire scripts to your post.
    - ONLY post the relevant code, and then refer to it in your discussion.
     
  3. sildeflask

    sildeflask

    Joined:
    Aug 16, 2023
    Posts:
    329
    thats not how you are suposed to use animator.play, you are calling it nonstop every frame

    here you can learn all you need

    https://web.archive.org/web/2021082...0807/250646/2D_Animation_Methods_in_Unity.php
     
  4. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,692
    Wow! Thanks for dredging that classic up from the time machine!

    I remember I read that WAY back in the day, like probably about when it came out, and it really impressed me for how thoroughly Joe tested all the different ways and compared the pros and cons.

    It still stands as a fantastic document to the flexibility of choices possible whenever you do anything in programming, but especially the choices even for such a simple thing as 2D animations.

    Joe used to hang out here. Wonder if he still does.
     
    sildeflask likes this.
  5. sildeflask

    sildeflask

    Joined:
    Aug 16, 2023
    Posts:
    329
    it really helped me because i am using his method on my game =D

    somehow its no longer up so i needed to search the deep archives
     
    Kurt-Dekker likes this.