Search Unity

  1. Unity support for visionOS is now available. Learn more in our blog post.
    Dismiss Notice

Bug Status HDRP bugs, no progress at all?

Discussion in 'High Definition Render Pipeline' started by Qleenie, Sep 26, 2023.

  1. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    Hi,

    I did spend a lot of time creating bug reports during the past year and am wondering why exactly I am doing this, as it seems that basically nothing get fixed. Here is a list of reported and approved bug reports which still are valid (just checked with latest 2023.1.14):

    1. Custom Pass not working with Dynamic resolution. (IN-53439). This was first reported 3 years ago. Lots of discussions in forum. Somehow never got fixed or brought back by regression in 2021. I re-reported four weeks ago. QA seems to struggle with activating DLSS, which is needed to see the issue in the project of my bug report.
    2. High Quality Lines not working in VR (https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-30721). This is fixed in higher beta + alpha versions, fix for 2023.1 seems to be in progress since many weeks now with no change.
    3. High Quality Lines crashes Unity in builds (https://issuetracker.unity3d.com/is...ommand-arg-release-when-it-runs-out-of-memory). Not reported by me, but was easy to reproduce. Critical issue, which is not even mentioned in release notes, and open since 3 months!
    4. High Quality Lines not possible to instantiate in builds (https://issuetracker.unity3d.com/issues/cant-rebuild-hair-using-hair-system-in-the-player). Backport to 2023.1.x missing, was fixed 4 weeks ago in beta version.
    5. TAA Post Sharpen does not work in XR (https://issuetracker.unity3d.com/is...e-pass-instanced-and-taa-post-sharpen-is-used). Open since 6 months.
    6. Water does not render correctly in XR (https://issuetracker.unity3d.com/product/unity/issues/guid/UUM-31909). Open since 6 months.
    7. Lens Flares don't render correctly in XR (same issuetracker as 4, as QA did not separate the issues). Open since 6 months.
    8. DLSS has very bad impact on performance if switched on/off using XR. (IN-41924, somehow the link to issuetracker is broken): This seems to be fixed in Editor somehow, but still happens in builds. Also an error is thrown on console as mentioned in my ticket. open since 4 months.
    9. Severe performance issues with DX12 + XR (IN-42188, again the link to issuetracker is broken). Open since 4 months.
    10. Mixed cached shadows on directional lights not working (IN-53418). Bug is in review since 3 weeks, but it's pretty obvious and easy to reproduce.
    Today reported another bug (Camera RenderTexture is black if DLSS and XR is used, IN-55879), but it might be my last bug report if I don't see any progress on above issues, as it seems like a waste of time.
     
  2. pierre92nicot

    pierre92nicot

    Joined:
    Aug 21, 2018
    Posts:
    57
    I can't agree more!
    It seems that too few people are using HDRP+VR for Unity to bother fixing issues.
     
    Qleenie likes this.
  3. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    Yeah, exactly. But out of the 10 bugs, 4 are not even XR related....
     
  4. schema_unity

    schema_unity

    Joined:
    Jun 13, 2018
    Posts:
    114
    For #3 I literally sent them a project containing an explanation and a fix, which can be turned on/off via preprocessor, so it's very easy to confirm where the issue is happening. The bug has been marked as "In Review" for 2 weeks, even though the crashing itself was already confirmed in another bug, but completely mislabeled, as it seems like all given explanation was ignored and a random stacktrace was blamed. (trace is semi-random due to this being memory corruption)
     
    Qleenie likes this.
  5. chap-unity

    chap-unity

    Unity Technologies

    Joined:
    Nov 4, 2019
    Posts:
    752
    I haven't got the time to investigate all the post yet but for what it's worth, to give a little context, it's not that Unity are not bothering fixing XR issues, it's more that the XR team is understaffed and just can't fix everything at once.
    Sometimes, XR bugs are moved to HDRP so that they can be fixed a little bit faster but it's no silver bullet and we don't have unlimited fixing power in HDRP either :)
     
    colinleet, m0nsky and pierre92nicot like this.
  6. mgeorgedeveloper

    mgeorgedeveloper

    Joined:
    Jul 10, 2012
    Posts:
    308
    This is one aspect of the bug reporting that I think can be improved. Sometimes the original description and specific conditions or nuances in the notes are ignored. It is redescribed in the official bug page, missing out sometimes on critical details that might make it easier for the developer to actually repro and fix the issue.

    I think the original report as described by the reporter, should at least be attached to the bug report that is written by the QA person.
     
    Trigve, pierre92nicot and Qleenie like this.
  7. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    Exactly this. What I do for now is repeat everything from the original bug report in the comment section of the issue, but this seems to be unnecessary extra work, and it's often not understandable why QA left out the most important part of the info; I e.g. had cases which only happen with DX12, but the final bug report does not mention DX12 anywhere.
     
    mgeorgedeveloper likes this.
  8. SebLagarde

    SebLagarde

    Unity Technologies

    Joined:
    Dec 30, 2015
    Posts:
    932
    Hi,

    Your report are valuable and we greatly appreciate the time you spent on it. As Remy mention there is always lot of thing happening at Unity and staying on track and even staffed can take a lot of time.

    For 1) There is no DRS management in custom pass, this is something that need to be handle on users side. So most of the time it is a problem of understand what scale uniform need to be used. We are trying to update our documentation to provide more sample with DRS.

    For item 2) and 4) This is fixed in latest 23.3 we are working on the backport.
    3) we must confess that the issue was created but was missing an area and have get in limbo.. We have fixed the JIRA it so we will look at it. But likely we fixed it at the same time then 2) and 4)

    For others I am gathering info.

    Thanks
     
  9. olavrv

    olavrv

    Joined:
    May 26, 2015
    Posts:
    511
    @SebLagarde We have been unable to upgrade since February this year (perhaps earlier) because of this bug. Hope it can be addressed so that we can take advantage of all the new features and functionalities. Would be nice if low hanging show stopping bugs could be prioritized before moving on with new stuff...
     
  10. HIBIKI_entertainment

    HIBIKI_entertainment

    Joined:
    Dec 4, 2018
    Posts:
    591
    <3 you got this all
     
    antoinecharton likes this.
  11. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    4 months later; situation still the same or even worse.

    HQ Lines still not working in XR; the provided fix does not work, as it produces heavy artifacts on one eye; reported as IN-65525. Furthermore performance is getting worse compared to using it in multi-pass, which is probably another bug.

    DLSS still not working properly in XR, even spamming exceptions in the console, performance goes nuts if DLSS is toggled during runtime. Also new bug added: Render Textures are black on Camera while using DLSS with XR (IN-55879).

    DX12 is still an unbelievable mess in XR; performance (GPU and CPU usage) is really bad even on near empty scene, and GPU memory usage seems to be twice of DX11.

    Water still broken in XR.

    TAA Post sharpen still broken in XR.
    .
    Mixed cached shadows on directional lights seems like a big mess, cannot make it work, even with the now updated documentation and updating the shadows every frame. This is with/without XR.

    All tested on 2023.2.5.
     
  12. mgeorgedeveloper

    mgeorgedeveloper

    Joined:
    Jul 10, 2012
    Posts:
    308
    Qleenie likes this.
  13. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    that's only part of the problem in XR; just measured again in build; scene is empty besides a sky and menu.
    DX11: GPU time 3ms
    DX12: GPU time 16ms

    So it's more than 5 times slower with DX12 using XR. Something is fundamentally broken.
     
  14. mgeorgedeveloper

    mgeorgedeveloper

    Joined:
    Jul 10, 2012
    Posts:
    308
    That does seem extremely slow compared to DX11.

    Over the months, we've had many issues with DX12 slow-down. At least 1 main issue, was massive slowdown due to unexpectedly running out of dedicated GPU RAM.

    But this obviously isn't what's happening in your case with an empty scene.

    I do think it's best to just stick to DX11 if possible, for as long as possible. I just hope that at some point, DX11 support doesn't get left behind so much, that we have to go DX12 and then have a huge performance/memory problem to deal with :(
     
    Qleenie likes this.
  15. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    I don't think DX12 is really production ready in the state it is in. It might have worked okay on some Unity internal test cases, but real world projects seem to run worse. I even saw inconsistent performance behavior on Unity internal projects, like the Enemies demo, which runs on DX12 by default due to the usage of RTX.
     
  16. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    Now that after having the ticket in review for 4 months (!!!!) I finally got confirmation from QA for IN-55879 (RenderTexture on Camera not working using DLSS and XR), the situation is actually officially even worse than at the time of my original post in September 2023.
    Not sure what else to do to get some priority on fixing long standing bugs....
     
  17. HIBIKI_entertainment

    HIBIKI_entertainment

    Joined:
    Dec 4, 2018
    Posts:
    591

    Waaaait. Empty scene . This could again relate to how features are handled in inf space, between DX11 and DX12 this could be exacerbated but the technical advancements but the emptiness actually gives biased results.
     
  18. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    not sure if I understand what you mean, but 16ms is definitely waaaay too much, and I don't think there is another explanation than this is buggy / not working with XR correctly.
    And in non empty XR scene it completely breaks down to be not usable, but it's hard to determine it's due to the excessive GPU RAM usage.
     
  19. mgeorgedeveloper

    mgeorgedeveloper

    Joined:
    Jul 10, 2012
    Posts:
    308
    Comparing like for like and seeing +9ms spent somewhere as compared to DX11, is a completely valid observation. It's not like the 9ms of extra time spent will somehow diminish in a real game test.
     
    pierre92nicot and Qleenie like this.
  20. Jack_Martison

    Jack_Martison

    Joined:
    Jun 24, 2018
    Posts:
    134
    That's how DX12 should be
    Is that what Unity claims "DX12 is production ready'?
     
    nehvaleem likes this.
  21. HIBIKI_entertainment

    HIBIKI_entertainment

    Joined:
    Dec 4, 2018
    Posts:
    591
    True observations, it could certainly still be bug-related or forward resource, with XR i don't have a lot of experience with it other than plugging it in, but if there are new profiles, that could be related too.

    Do either of you get the same performance with something representing internal like inside a large flipped normal cube? or the "internal" scene set up?
     
  22. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    not sure what you mean with "new profiles", but the performance drop is independent of the scene. I'll do a new bug report today on the DX12 / XR issue (after waiting for nearly a year for a solution), as my former bug report for this was changed by the QA team in a way that even I don't understand it anymore, maybe that's the reason why no one took care of it yet. This is actually a big issue, as the Unity QA team seems to be mostly junior QA engineers ( I looked up a few of them), and often don't fully understand the bug reports, but still try to rephrase them.
     
  23. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    New report for DX12 vs XR, using Unity sample scene (with added OpenXR): IN-67607
     
    HIBIKI_entertainment likes this.
  24. HIBIKI_entertainment

    HIBIKI_entertainment

    Joined:
    Dec 4, 2018
    Posts:
    591
    Apologies, I mean the Pipeline asset profiles, sometimes the unity defaults have been altered from previous versions, new technologies or slightly different defaults ( having vol clouds by default for example) but also the tuning of the quality levels.

    But yeah good call getting a report out again, especially if there's notible degradation or at least some viable explanation right now.
     
  25. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    I am using HDRP since 2019 and tested on different projects, including production projects, the performance drop is everywhere same. It’s also not a degradation to previous versions, DX12 and XR together are performing very bad in all versions in which DX12 is considered production ready by Unity.
     
  26. HIBIKI_entertainment

    HIBIKI_entertainment

    Joined:
    Dec 4, 2018
    Posts:
    591
    That is a shame.

    For you own piece of mind to you can create Test Frameworks to benchmark the editor itself bugs and crashes aside you should be able to get benches on your specific needs can compare between editor for a nice data-driven A/B test.

    This has the potentially provide you valuable insights ifor decision making into whether you should update at a stage like pre production or generally just investigating and evaluating engines and project scopes.
     
  27. Qleenie

    Qleenie

    Joined:
    Jan 27, 2019
    Posts:
    835
    We run in production with many, many customers already and just want to change to DX12 to offer RTX as an option, but can’t because of Unity bugs.
     
    pierre92nicot and olavrv like this.