Search Unity

Sprite Shape Edge Collider Not Updating

Discussion in '2D' started by JUSTCAMH, Jan 19, 2019.

  1. JUSTCAMH

    JUSTCAMH

    Joined:
    Dec 8, 2018
    Posts:
    18
    I have created a world generation system that includes Sprite Shapes. This system progressively generates a rope bridge using the sprite shape tool.

    This system works fine, but regardless of the changes made to the spline, the collider does not update. The collider is set to auto-update, and when I select the sprite shape in the inspector, the collider refreshes and works perfectly. I have tried all of the different functions available in the spriteshape controller, but none of them seems to update the edge collider.

    The spriteshape is instantiated from a prefab, then the startPos and endPos are set. The game then calls updateSpline(), shown below.

    upload_2019-1-19_11-16-15.png

    The function below is called to update the spline. What would I need to add/change to update the collider?
    Code (CSharp):
    1. public void updateSpline()
    2.     {
    3.         controller.spline.SetPosition(0, startPos);
    4.         controller.spline.SetPosition(2, endPos);
    5.  
    6.         Vector2 diff = endPos - startPos;
    7.  
    8.         float dangle = diff.magnitude / stiffness;
    9.  
    10.         Vector2 danglePos = (startPos + endPos) / 2;
    11.         danglePos.y -= dangle / 2;
    12.  
    13.         controller.spline.SetPosition(1, danglePos);
    14.  
    15.         Vector2 averageDir = ((startPos - danglePos) - (endPos - danglePos)) / 2;
    16.  
    17.         controller.spline.SetLeftTangent(1, averageDir / 2);
    18.         controller.spline.SetRightTangent(1, -averageDir / 2);
    19.         controller.spline.SetTangentMode(1, ShapeTangentMode.Continuous);
    20.        
    21.     }
     
    JUSTCAMH, Jan 19, 2019
    #1
    ETGgames and vaibhav_unity235 like this.

  2. JUSTCAMH

    JUSTCAMH

    Joined:
    Dec 8, 2018
    Posts:
    18
    I believe this is a glitch, so I made a workaround. Simply don't use the collider system given to you by Sprite Shape, and instead make your own collision system. It took a bit of tweaking to get my collider perfectly following the spline, but it is possible. Certainly a nuisance though.
     
    JUSTCAMH, Jan 19, 2019
    #2

  3. vaibhav_unity235

    vaibhav_unity235

    Joined:
    Aug 22, 2018
    Posts:
    4
    i also face this problem but didn't get any solution. if you got please send me
     
    vaibhav_unity235, Mar 18, 2019
    #3

  4. JUSTCAMH

    JUSTCAMH

    Joined:
    Dec 8, 2018
    Posts:
    18
    @vaibhav_unity235
    I set 'Update Collider' to false, then tweaked the points of the edge collider in the code. Since I generated the spriteshape, I already had a list of the points used to make the shape, so I just shoved those values into the edge collider directly.

    It was a bit more complex than that, since the quality of the collisions wasn't always high enough, so I made an algorithm to simply add extra points in between the existing ones. This also didn't really work with the handles, but once again, I just made it work. For me, it was all just a big workaround.
     
    JUSTCAMH, Mar 20, 2019
    #4

  5. Venkify

    Venkify

    Unity Technologies

    Joined:
    Apr 7, 2015
    Posts:
    644
    You could also call SpriteShapeController BakeCollider() function to generate collider on runtime while we look into the issue.

    public class AnimatePoints : MonoBehaviour
    
{
    
    bool changesMade = false;
    
    void Update()
    
    {
    
        if (changesMade)
    
            GetComponent<SpriteShapeController>().BakeCollider();
    
        // Just change some spline data.
    
        if (Random.Range(0, 10) % 2 == 0)
    
        {
    
            var pos = GetComponent<SpriteShapeController>().spline.GetPosition(0);
    
            pos.x = pos.x + Random.Range(-1.0f, 1.0f);
    
            GetComponent<SpriteShapeController>().spline.SetPosition(0, pos);
    
            changesMade = true;
    
        }
    
    }
    
}
     
    Venkify, Mar 21, 2019
    #5

  6. Discipol

    Discipol

    Joined:
    May 6, 2015
    Posts:
    83
    I still have this problem in 2019.1. Apparently the mesh generation is a JobHandle where I would have preffered it would be synchronous. I haven't solved it, but I am trying to use an Action called in a coroutine that tests the jobhandle...

    Pray for me...
     
    Discipol, May 6, 2019
    #6

  7. ImperialDynamics

    ImperialDynamics

    Joined:
    Jun 21, 2018
    Posts:
    21
    having same issue. BakeCollider doesn't solve it for me
     
    ImperialDynamics, Oct 1, 2019
    #7
    ETGgames and Discipol like this.

  8. Venkify

    Venkify

    Unity Technologies

    Joined:
    Apr 7, 2015
    Posts:
    644
    Please post a sample project or a bug report. It will help us understand the issue better as its not clear what you are trying to do.
     
    Venkify, Oct 2, 2019
    #8

  9. Discipol

    Discipol

    Joined:
    May 6, 2015
    Posts:
    83
    I already did that in relation to a different bug: 1182517 can you get it from there?
     
    Discipol, Oct 5, 2019
    #9

  10. Venkify

    Venkify

    Unity Technologies

    Joined:
    Apr 7, 2015
    Posts:
    644
    I am re-posting this again so its clearer. The Scripts posted below use BakeCollider to update the Collider for SpriteShape Renderer. The source of these scripts are not internal and can be easily integrated into any project. Please use them as reference for BakeCollider usage.

    https://forum.unity.com/threads/spriteshape-preview-package.522575/page-6#post-4479055

    We understand that different games/styles can have different needs for collider generation. Based on inputs and feedback such as the ones above, we have provided some additional scripts for collider generation in the sample project. More info and simple demonstration videos as follows:

    Geometry Based Collider (Collider from Render Geometry):



    Generates collider data from the Renderer geometry and is more precise. This is available in from the sample project here.
    https://github.com/Unity-Technologies/2d-spriteshape-samples/blob/master/Assets/Unity Technologies/2D SpriteShape/Extras/Scripts/GeometryCollider.cs

    Once you import this script to your project you can select Menu -> SpriteShape -> Generate Geometry Collider to generate spriteshape collider data for EdgeCollider2D or PolygonCollider2D if present in the select gameObject.
    1. Generates collider data from the render data and provides best fit collider.
    2. Collider is generated in main-thread and could be slower than the default generator.
    3. Collider Quality levels or Optimize collider does not apply.
    Legacy Collider (Collider generator that shipped with 2018.* versions):



    Collider generator that ships with 2018.* versions of SpriteShape. Might be useful for developers who need backward compatibility.
    This is available at :
    https://github.com/Unity-Technologies/2d-spriteshape-samples/blob/master/Assets/Unity Technologies/2D SpriteShape/Extras/Scripts/LegacyCollider.cs

    Once you import this script to your project you can select Menu -> SpriteShape -> Generate Legacy Collider to generate spriteshape collider data for EdgeCollider2D or PolygonCollider2D if present in the select gameObject.
    1. Generates collider data only based on Spline data and does not take into account different height or sprite size in the control points.
    2. Collider Quality levels or Optimize collider does not apply.
     
    Venkify, Oct 6, 2019
    #10
    ETGgames likes this.

  11. Venkify

    Venkify

    Unity Technologies

    Joined:
    Apr 7, 2015
    Posts:
    644
    This unfortunately did not have any repro project. We have already provided samples for BakeCollider usage as seen above. Please refer them. Please feel free to ask if you need more info.
     
    Venkify, Oct 6, 2019
    #11

  12. Discipol

    Discipol

    Joined:
    May 6, 2015
    Posts:
    83
    Thank you kindly Venkify! I might have copied the wrong bug report. Since upgrading to 2019.3 I have found many issues and reported quite a few.

    To be more precise, what I have is a few spritedshapecontrollers that represent sections of a race track. At runtime, I generate a racetrack from those pieces and stitch them together in a brand new (And very long) spriteshapecontroller.

    All of this happens behind a black transition screen and I required a test condition for it o be fully built / generated, including graphics and colliders. What happened was, because the camera did not look at the spriteshapecontroller, it did not trigger "OnWillRenderObject" which had the right ammount of internal logic to do the job.

    Simply calling BakeMesh did nothing, even by forcing the JobHandle to complete. What I did till now is to go inside SpriteShapeController, copy the logic (And forcing the conditions to be true just in case) in a publicly accessible method.

    This hack is annoying because everytime Unity rebuilds the modules, it resets all cs files including thatone, so I have to keep copy/pasting my hacky method.

    Another Unity developer on these forums posted something about using a temporary texture to trigger "looking at the spriteshape" to trigger internal code to generate it, but I will look at your solution which might be more direct than a hack :D
     
    Discipol, Oct 6, 2019
    #12
    ETGgames likes this.

  13. KoolGamez

    KoolGamez

    Joined:
    Apr 11, 2020
    Posts:
    29
    How can I add multiple edge colliders to my 2d spline? My goal is to make a top down road and its edges to serve as boundaries which the player cannot cross procedurally. To test this, I manually created a 2d spline using this asset and then adding an edge collider to it. Even the first edge collider was not lining up properly with the sprite's edges. How can I make it accurate using code where I don't have to manually do this?
     
    KoolGamez, Nov 13, 2020
    #13

  14. JiriAtanasovsky

    JiriAtanasovsky

    Joined:
    Jan 18, 2021
    Posts:
    9
    It seems to me that collider stops to be recalculated whenever I set one of points to be exactly 0. Im not sure thought... Can someone else investigate and confirm?
     
    JiriAtanasovsky, Mar 31, 2021
    #14
    kawaiianthony, cassiopolegatto and emrotten like this.

  15. emrotten

    emrotten

    Joined:
    Jun 19, 2020
    Posts:
    4
    Wow, great catch.

    I'm creating a Sprite Shape that's a cone, starting at 0 on the originating body and going out from there. I'm using (0f,0f,0f) as my base spline point. The Polygon Collider 2d wasn't updating no matter what I did.

    Updating the base point to be (0f,0.1f,0f) fixes the problem.
     
    emrotten, Apr 27, 2021
    #15

  16. Venkify

    Venkify

    Unity Technologies

    Joined:
    Apr 7, 2015
    Posts:
    644
    Will take a look asap and post an update to this thread. Thanks for the Update.
     
    Venkify, Apr 28, 2021
    #16

  17. cassiopolegatto

    cassiopolegatto

    Joined:
    Sep 17, 2018
    Posts:
    1
    I was having the same problem and bumped into this thread.
    I moved my sprite shape a point away of 0,0,0 like you said and it fixed it, thank you!
     
    cassiopolegatto, Oct 29, 2021
    #17

  18. wedgiebee

    wedgiebee

    Joined:
    Aug 9, 2016
    Posts:
    40
    @Venkify Any updates on the 0,0,0 issue? I'm seeing it still in 2021.2.7f1.
     
    wedgiebee, Jan 14, 2022
    #18

  19. Venkify

    Venkify

    Unity Technologies

    Joined:
    Apr 7, 2015
    Posts:
    644
    I believe this has been fixed in recent versions (tested 7.0.3 for 2021.2) Could you please let us know what version of SpriteShape you use? It would also be helpful if you kindly submit a bug report with a simple repro project ? Thanks. collider.gif
     
    Venkify, Jan 17, 2022
    #19

  20. wedgiebee

    wedgiebee

    Joined:
    Aug 9, 2016
    Posts:
    40
    @Venkify I'm on 7.0.3! It looks like I isolated the repro - it only happens when you use a Sprite Shape Profile that dosn't have any Sprites in its Sprites list. I'm doing this because I need a closed SpriteShape with no border.

    I also submitted a bug report with a repro project!
     
    wedgiebee, Feb 7, 2022
    #20