Search Unity

Spaceship Demo Project

Discussion in 'General Graphics' started by ThomasVFX, Aug 14, 2019.

  1. ThomasVFX

    ThomasVFX

    Unity Technologies

    Joined:
    Jan 14, 2016
    Posts:
    26
    Last edited: Aug 19, 2019
  2. keeponshading

    keeponshading

    Joined:
    Sep 6, 2018
    Posts:
    332
    Hi.
    Unity 2019.2.0

    GIT LFS checkout
    and
    Download Release

    fire following error after import

    LocalPackages\net.peeweek.gameplay-ingredients\Runtime\Managers\Implementations\VirtualCameraManager.cs(4,7): error CS0246: The type or namespace name 'Cinemachine' could not be found (are you missing a using directive or an assembly reference?)

    Cinemachine ist installed over PackageManager

    duplicate from
    https://github.com/Unity-Technologies/SpaceshipDemo/issues/3
     
    peopleUnity likes this.
  3. Rich_A

    Rich_A

    Joined:
    Nov 22, 2016
    Posts:
    169
    Submitting my FPS:

    (laptop)
    i7-6700HQ
    1060 6GB
    16GB RAM

    1080p:

    45-70. Average 55.

    Definitely the scene or HDRP behind it needs further optimisation, considering there are no skinned-mesh characters, no large environments, no networking.
     
    Last edited: Aug 20, 2019
    laurenth-unity likes this.
  4. razzraziel

    razzraziel

    Joined:
    Sep 13, 2018
    Posts:
    122
  5. TheElumenati

    TheElumenati

    Joined:
    Jan 22, 2014
    Posts:
    7
    Sometimes, but not always the hologram table animation galaxy state animation starts playing but then it closes before you have the opportunity to click on anything. The "FTL target system" loading bar is up and blinking. But the galaxy faded out to nothing.

    I have been able to find is state machine attached to hologram table (if i make the state public) is at Galaxy and the animation on galaxy/GalaxyFadeIn is a few frames beyond the end of the animation if the bug occurs, and at the blue line if the bug doesn't occur.
    I am unsure if that is normal or not, but if i rewind the animation back to the blue line the galaxy comes back.

    This is what it looks like when the bug does not happen:


    This is what it looks like when the bug happens:


    If i manually stretch out the animation timelines it helps, but the bug is happening in some of the other animation timelines.


    Follow on the issue tracker:
    https://github.com/Unity-Technologies/SpaceshipDemo/issues/5
     
  6. TheElumenati

    TheElumenati

    Joined:
    Jan 22, 2014
    Posts:
    7
    I think i found the bug in GameplayIngredients.Rig.DirectorControlRig->Update line 64

    Code (CSharp):
    1. director.time = newTime
    should be
    Code (CSharp):
    1.  
    2. if (m_PlayMode == PlayMode.Reverse) {
    3. director.time = newTime < 0 ? 0 : newTime;
    4. } else {
    5. director.time = newTime > director.playableAsset.duration ? director.playableAsset.duration : newTime;
    6. }
    right after this line it evaluates the timeline.

    this change prevents the timeline from being played outside of the playable region if for example the time step is greater than one fps. Not sure if this is a complete fix because it could still possibly miss event inside the timeline... which i will explain my thought here:

    Does anyone know more about this PlayableDirector's behavior while in DirectorUpdateMode.Manual mode? It seems to me that it has a certain chance to miss timeline events. If the frame rate is slower than the expected frame rate of the timeline, or if has a hickup during the timeline event, this might be the cause of the missed timeline event.... It evaluates before the event and after the event, but misses the event completely...

    Again i haven't used this timeline much... is there a way to see a list of where on the timeline it was evaluated after the fact and if it missed any important parts of the animation?
     
    Last edited: Aug 30, 2019
  7. flyer19

    flyer19

    Joined:
    Aug 26, 2016
    Posts:
    13
    spaceship mac.jpg
    what is wrong ?can not run on mac
     
  8. cfree

    cfree

    Joined:
    Sep 30, 2014
    Posts:
    61
    Hi.
    Cannot use the fire VFX on another project (package exported from Spaceship demo)... it renders all black... using Unity 2019.2 and 2019.3.
    Please help.
    Thanks!
     

    Attached Files: