Search Unity

  1. Unity support for visionOS is now available. Learn more in our blog post.
    Dismiss Notice
Unity's version control component has been upgraded to Plastic SCM.

[Solved] collab commit version number stuck at 501

Discussion in 'Unity Collaborate' started by zubz, Nov 1, 2017.

  1. zubz

    zubz

    Joined:
    Feb 11, 2016
    Posts:
    12
    Hi, any idea why my collab history is stuck at 501 no matter how many every commits I make.
    I do recall it being at 700 something about 3-4 weeks ago and then noticed one fine day 501 as the new commit and it's stuck at that number since. The data seems fine, just the commit number is not incrementing.
    Any idea what happened, did I hit some limit?
     
  2. Ryan-Unity

    Ryan-Unity

    Joined:
    Mar 23, 2016
    Posts:
    1,993
    Hi @zubz! In our effort to optimize the experience of the History Window we limited the number of commits that are returned in that window to 500. The count in that window is based solely on the number of revisions that are currently displayed, not necessarily their actual revision number. Rest assured that you are not losing any data. But because you hit the limit of the history window, all your latest commits will return as being commit 501.

    If you ever need to go back to a commit that's older than 500 commits ago then you can still go to the Collaborate section of the Developer Dashboard and look through the Assets tab to download older versions of any of your assets. I hope that clears up the confusion.
     
  3. zubz

    zubz

    Joined:
    Feb 11, 2016
    Posts:
    12
    Thnx for the info Ryan. Is there a variable or something that correlates to the "commit number" as the dashboard doesn't have any commit number either. We were basing our builds to a commit number so we could roll back and troubleshoot if need be, now with no proper commit number it's hard to tag/track the commits, unless we maintain it manually or via some script.
     
  4. zubz

    zubz

    Joined:
    Feb 11, 2016
    Posts:
    12
    Also why not keep the current commit numbers just display the last 500 instead of resetting the numbering. I would rather see 600-1100 than 0-500 always which are irrelevant. Thnx
     
  5. Gurg

    Gurg

    Unity Technologies

    Joined:
    Nov 9, 2016
    Posts:
    73
    So this starts to get into the nitty gritty of the change that happened. I'll do my best to explain.

    So commits don't really have a number that we store with them. They do have a generated ID, but it's not a simple incremental number ID. They never actually had this. The editor was just counting the number of commits it knew about on the client side to generate those numbers. Since it's just a count and we limited the history return to 500 commits, the most recent commit is always number 501.

    There was no client side logic change for this. This was done completely server side. The reason for the change was because we didn't have a limit on how much history to return to the editor. It just asked for the whole thing at once. This was very slow for users with very long commit histories. We figured the net pain of having to wait over a minute for your history to load every time would be greater than having to go to the dev dashboard website to deal with the rare case where you need a commit from over 500 commits ago.

    This 500 value is set server side by us, but it is not set in stone and this limit is only in place for the call that says "Give me the entire history." In a near future editor release, the history window will have properly implemented pages (the same kind of pages you can see on the dev dashboard website now where it shows 100 commits at a time). Once this is out, there won't be a limit to the number of commits that are visible in the editor for versions of the editor with this paged feature.

    Yes, it would make more sense to show 600-1100 instead or whatever, but if we could have made a client side change like that before imposing this limit, we would have just put in the pages feature instead to avoid the need to do that. Also if we can find other means of making this history call work a lot faster, we would be free to increase this limit to something much higher. Just keep in mind that if we did raise it, the same problem would still exist. If we raised the limit to 1000, then the most recent commit would be always number 1001 assuming that you have more than 1000 commits.

    I hope that helps to explain the current situation and that it's only temporary until we get history pages in.
     
    bradunity likes this.
  6. Jilljoy

    Jilljoy

    Joined:
    Mar 3, 2015
    Posts:
    6

    I know this is a bit old but is anything happening with the commit numbers and the page feature. It wasn't clear to us that there was a 500 limit.

    Thanks
     
  7. Gurg

    Gurg

    Unity Technologies

    Joined:
    Nov 9, 2016
    Posts:
    73
    Sorry for the late reply. 2018.1 is the first editor version with the new paginated history window UI so you won't be limited to the latest 500 commits.
     
  8. cxode

    cxode

    Joined:
    Jun 7, 2017
    Posts:
    268
    Oh, bless your soul, that's fantastic and I can't wait. It has been a continued source of angst for me that I can't go back more than 500 commits. To clarify, there isn't any limit at all now, right?

    Edit: also, will this work for projects over 500 commits that were created before 2018.1?
     
    Last edited: Apr 17, 2018
  9. Gurg

    Gurg

    Unity Technologies

    Joined:
    Nov 9, 2016
    Posts:
    73
    So just to reiterate, your project itself, on the server, has no limit to the number of commits and never had a limit to the number of commits.

    The problem was that on older editor versions we had to limit how many commits the history window could display! That display limit will still be in effect on the older editor versions as they are working off of the old UI framework, making a backport of the new UI to them very difficult.

    So if you have a project with way more than 500 commits but were on an older editor version and then upgraded to 2018.1, you'll see the ability to browse back to your first commits return.
     
    cxode likes this.
  10. cxode

    cxode

    Joined:
    Jun 7, 2017
    Posts:
    268
    @Gurg awesome, thank you for the information!
     
    Gurg likes this.
  11. Jilljoy

    Jilljoy

    Joined:
    Mar 3, 2015
    Posts:
    6
    Great work team! I think our project is migrating to the LTS version however but it'll be something to look forward to. So is there no limit on the history window now? It just reloads a new page?
     
  12. Ryan-Unity

    Ryan-Unity

    Joined:
    Mar 23, 2016
    Posts:
    1,993
    Yes, there will be no limits in the history window for newer versions of the Editor. :)
     
    cxode and Gurg like this.
  13. cxode

    cxode

    Joined:
    Jun 7, 2017
    Posts:
    268
    The new collab history window is wonderful, thank you so much for adding it. Just one slightly annoying issue is that numbers four digits and above are cut off. The build numbers should be moved a little to the left.
     
  14. Ryan-Unity

    Ryan-Unity

    Joined:
    Mar 23, 2016
    Posts:
    1,993
    Thank you for bringing that to our attention, @Iamsodarncool. I'll pass this along to the dev team.
     
    cxode likes this.
  15. Gurg

    Gurg

    Unity Technologies

    Joined:
    Nov 9, 2016
    Posts:
    73
    Hey @Iamsodarncool how wide is your window when you see that? Does the problem go away if you make the window wider?
     
  16. cxode

    cxode

    Joined:
    Jun 7, 2017
    Posts:
    268
    @Gurg I keep the window pretty wide, but the size does not affect the relative position of the numbers.
     
  17. Gurg

    Gurg

    Unity Technologies

    Joined:
    Nov 9, 2016
    Posts:
    73
    Noted, thanks for the video of the bug.
     
    cxode likes this.