Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Unite 2023 Registrations are now LIVE! We are thrilled to announce that Unite 2023 Registration is now live and open for all!
    Dismiss Notice
New Forum User Notice Unite 2023 Registrations are now LIVE!

Feature Request Small Usability Requests and Feedback.

Discussion in 'Localization Tools' started by Garrafote, Mar 31, 2020.

  1. Garrafote

    Garrafote

    Joined:
    Jun 13, 2013
    Posts:
    48
    Hi,

    Overall we are loving the way localization tools are shaping up.
    That said, here are some small usability requests gathered after some time of use on the tools:

    1. Can we have table names ordered alphabetically? I keep seeing my team taking too long to find tables on the list.
    upload_2020-3-31_10-13-25.png


    2. I would like to follow a naming standard for IMetadatas where all metadata class names end with Metadata but the "Metadata" word is not part of the title shown on the UI.

    Code (CSharp):
    1. [Serializable]
    2. [Metadata(AllowedTypes = MetadataType.SharedTableData)]
    3. public class NotionCollectionMetadata : IMetadata
    4. {
    5.     public string collectionUrl;
    6. }
    upload_2020-3-31_10-22-4.png


    3. In our game, each game dialogue is tied to a distinct localization table. It would be nice to have a native type that references a StringTable on my scripts. We created our own custom drawer as a workaround but it would be nice to have something similar to LocalizedString with a simple async method to pull an entire table in the same way LocalizedString does.

    upload_2020-3-31_10-27-47.png


    4. This might not be directly related to your team. The assets "Assets\AddressableAssetsData\AssetGroups\Localization-Assets-Shared.asset" and "Assets\AddressableAssetsData\AssetGroups\Localization-StringTables.asset" are modified whenever a new LocalizationTable is added. These assets are running into git conflicts during git merge. If a conflict happens we have different possible scenarios:

    a. It's a simple conflict and we are able to fix it by hand. No further implications.
    b. We aren't able to solve the conflict by hand and we chose to use one of the original versions. In this case, all tables edited on the other commit will not be shown on the "Selected Table" dropdown on the table editor window.

    I'm bringing this issue to light because it's possible that we have two team members working on unrelated features that both require adding new localization tables. This scenario is not obvious to cause git conflicts and worse, those conflicts if not understood and fixed properly could possibly result on invalid/broken LocalizationTables laying around in the project with no notification or warning.
     

    Attached Files:

    Garrafote, Mar 31, 2020
    #1
    karl_jones likes this.

  2. Garrafote

    Garrafote

    Joined:
    Jun 13, 2013
    Posts:
    48
    5. Broken LocalizedString inspector. The inspector for LocalizedString is not respecting indentation and the locale name is overlaping the localized text preview on narrow inspector windows:
    upload_2020-3-31_11-32-3.png
     
    Garrafote, Mar 31, 2020
    #2
    karl_jones likes this.

  3. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,845
    We have already changed this in the next release. We were just showing them in the order we get them on disk but we do now order them by name :)
    We could maybe add some sort of search functionality or custom grouping to help order them better.
    What if we gave you an extra field in the Metadata attribute to provide an optional name?

    Good idea. Should be no problem to do. I'll add it to our list.

    Hmm. So by default when a table is added/removed we need to add/remove an entry in the Addressables, the thing you see modified. Ill have a chat with the Addressables team and see if they can come up with some ideas.

    Thanks for the feedback, its really useful and its great to hear you are using the package :)
     
    Last edited: Mar 31, 2020
    karl_jones, Mar 31, 2020
    #3

  4. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,845
    Could you please file a bug report for this :)
     
    karl_jones, Mar 31, 2020
    #4

  5. Garrafote

    Garrafote

    Joined:
    Jun 13, 2013
    Posts:
    48
    Last edited: Apr 2, 2020
    Garrafote, Mar 31, 2020
    #5
    karl_jones likes this.

  6. Lukas-Labaj

    Lukas-Labaj

    Joined:
    Nov 22, 2012
    Posts:
    36
    Hi @karl_jones ,

    regarding git merge conflicts. We also have an issue with when more people adding new entry to string table in same time and trying to commit to git. IDs for key are locally sequential and both team members end up with same ids and different content. What is the best practice for that? Are you planning have some solution?

    Thank you
     
    Lukas-Labaj, Jun 24, 2020
    #6

  7. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,845
    Hi,
    Hmm it's not something that has been brought up before. We could try using random keys instead of sequential.
    Generally the best practice would be for each person to add their entries to a different table although that may not be practical.
    I'll make a note to look into it, random keys may work.

    Edit: Found a better solution than random ;)
     
    Last edited: Jun 25, 2020
    karl_jones, Jun 24, 2020
    #7

  8. Xarbrough

    Xarbrough

    Joined:
    Dec 11, 2014
    Posts:
    1,184
    Is this solution something you can explain in short and is it implemented in the newest version? Thanks!
     
    Xarbrough, Jul 1, 2020
    #8

  9. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,845
    Yes, its already landed for 0.8.0(eta Aug)

    We changed the ids from uint to long and we now encode 3 different values into each one:

    This article describes the technique https://www.callicoder.com/distributed-unique-id-sequence-number-generator/
    This now generates a unique id for each machine it is running on. QA tested it and its looking great so far :)
     
    karl_jones, Jul 1, 2020
    #9
    Chris16514, Prodigga and Xarbrough like this.

  10. Chris16514

    Chris16514

    Joined:
    Feb 8, 2021
    Posts:
    9
    Good to see the unique ID issue is resolved. We just had a merge conflict as two people added entries to the same table and the Unity merge tool failed. Any suggestions for a solution as I can see this happening more often and don't really want to do manual merges every time?
     
    Chris16514, Mar 17, 2021
    #10

  11. karl_jones

    karl_jones

    Unity Technologies

    Joined:
    May 5, 2015
    Posts:
    7,845
    Im not sure. I'll speak to the team who does the merge tool and see if there's anything we can do.
     
    karl_jones, Mar 17, 2021
    #11
    Chris16514 likes this.