Singleton Design Pattern Feedback

Hello,

I would like feedback on my newest repository, which provides Singleton's for C#. Like my last repository and post, this repository is focused on Singleton-like design patterns. However, since my last repository, I have studied the problem and feedback given and have made the following changes:

- Type and BaseType properties are now of type 'object' and is no longer limited to just strings.
- Singleton's can be instantiated and destroyed on command with the 'Instantiate' and 'Destroy' properties. These singleton's can access properties and override functions to determine when it is being constructed and destroyed.
- Find, FindAll, Instantiate and Destroy properties all can type or base type as a filter. They can additionally use a given generic to search by both type and base type, or by just the base type.
- Singleton's can use a Instance property by inheriting from the generic class 'InstanceSingleton'.

I would love any constructive feedback on for my project.
Thanks in advanced!

 

You licensed your code under GPL3.

That means that NOBODY will be able to use your code with unity engine, as they will be unable to comply with the license.

Spoiler

Please research what opensource licenses mean.
-------
Same thing applies to your last repository.

"GPL" means "it is unusable in any unity project".

 

Add a [RuntimeInitializeOnLoadMethod(RuntimeInitializeLoadType.SubsystemRegistration)] method to initialize your static data or it won't work when domain reloading is disabled.

 

I did not know that, thank you. What is the recommended open source for a project like mine, where I'd like the developer full personal and professional use?

 

For a single file I'd use public domain or CC0 and possibly release it as a github gist.

For more complex stuff, Apache license, ZLib license, BSD license, MIT license are good.

Spoiler

GPL comes with nasty restrictions - using GPL code requires you to convert your whole project to GPL, and that's impossible when you're using unity, because unity is proprietary.
LGPL is less nasty, because it allows dynamic linking, but that's not really usable with unity either, as normally you use statically linked code in unity project. Actually the point of LGPL is that user should be able to swap the library with their own version.