Feedback Should the new Debug Toggle change the DEBUG directive?

I'm using the #if DEBUG directive to compile out some logging and safety checks, and noticed that the new Debug toggle doesn't set this directive. I think it would be useful for having a closer performance to release and also quickly test both code paths.

 

It should, regular .NET projects define DEBUG so by extension if anyone wants to reuse any non-Unity library or code snippet this functionality will break. (same with TRACE)

 

Reading your answer I think I should clarify:
Currently, the DEBUG directive exists and works as expected(in Editor and Development builds). What I'm asking if for the new toggle to set it to FALSE when working in "Release" mode.

 

Bump

 

In previous versions of Unity, you could also switch to release by disabling the "Editor Attaching" option in Preferences / External tools. And we didn't add DEBUG in that case and our code internally has always set DEBUG when compiling in the editor regardless of debug/release C# configuration.

Code (CSharp):

1.     if (developmentBuild || buildingForEditor)
2.     {   // For System.Diagnostics.Debug class
3.         outDefines.push_back("DEBUG");
4.         outDefines.push_back("TRACE");
5.     }
6.  

Changing this behavior would technically be a regression and could cause issues for some users. So the the safest option would be to add a new define, like UNITY_DEBUG and UNITY_RELEASE or similar.

 

Yeah that would work as well. In the end what's needed is the ability to run the code in the same conditions as in a release build.

 

We have added a task to our backlog to address this.

 

Thank you!