Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Question Shooting in only one direction?

Discussion in 'Scripting' started by IronDan21, Jul 14, 2023.

  1. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    Hi, for a game project I am working on, I have a way to shoot lasers from a certain point. The mechanic itself works well, the bullets fire, they destroy enemies and destroy when colliding with enemies, and there is a delay after shooting. However, the main problem I am having is that they only appear to be firing in one direction no matter which way the player is facing.

    Code (csharp):
    1. /CODE]
    2. using System.Collections;
    3. using System.Collections.Generic;
    4. using UnityEngine;
    5. using UnityEngine.InputSystem;
    6.  
    7. public class Shoot : MonoBehaviour
    8. {
    9.     public Bullet bulletPrefab;
    10.     public Transform shootPoint;
    11.  
    12.     private Animator anim;
    13.  
    14.     float timer = 0;
    15.     float shootDelay = 0.2f;
    16.  
    17.     // Start is called before the first frame update
    18.     void Start()
    19.     {
    20.         anim = GetComponent<Animator>();
    21.     }
    22.  
    23.     // Update is called once per frame
    24.     void Update()
    25.     {
    26.        
    27.         if (Keyboard.current.spaceKey.wasPressedThisFrame && Time.time>=timer)
    28.         {
    29.             Instantiate(bulletPrefab, shootPoint.position, transform.rotation);
    30.             anim.Play("Shoot");
    31.             timer = Time.time + shootDelay;
    32.         }
    33.     }
    34. }
     
  2. zulo3d

    zulo3d

    Joined:
    Feb 18, 2023
    Posts:
    510
    Can you show the bullet script?.
     
  3. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    10,468
    Nothing here is relevant to the direction the bullet moves, just where it starts so there's no way to help.

    Do you tell the bullet which way it's supposed to move? If so, that code would be more relevant so as above, show the bullet script or specifically show how you choose which direction it should move; that's going to be the thing that's broken, not the spawn point.
     
  4. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    Here it is
    Code (csharp):
    1. /CODE]
    2. using System.Collections;
    3. using System.Collections.Generic;
    4. using UnityEngine;
    5.  
    6. public class Bullet : MonoBehaviour
    7. {
    8.     public float speed;
    9.     private Rigidbody2D rb;
    10.  
    11.     public AudioSource destroy;
    12.  
    13.     void Start()
    14.     {
    15.         rb = GetComponent<Rigidbody2D>();
    16.         destroy = GetComponent<AudioSource>();
    17.        
    18.     }
    19.  
    20.     private void Update()
    21.     {
    22.         transform.position += transform.right * Time.deltaTime * speed;
    23.     }
    24.  
    25.     private void OnTriggerEnter2D(Collider2D collision)
    26.     {
    27.         if(collision.tag == "Enemy")
    28.         {
    29.            
    30.             Destroy(gameObject);
    31.         }
    32.  
    33.         if (collision.tag == "Enemy2")
    34.         {
    35.            
    36.             Destroy(gameObject);
    37.         }
    38.  
    39.         if (collision.tag == "Core")
    40.         {
    41.            
    42.             Destroy(gameObject);
    43.         }
    44.     }
    45. }
     
  5. MelvMay

    MelvMay

    Unity Technologies

    Joined:
    May 24, 2013
    Posts:
    10,468
    I presume you've debugged Transform.right before asking here? What is its value? That's the direction it's moving. Note that we cannot debug it for you so if you've not done that then I would highly recommend reading how to.

    Here's a guide.

    If it's pointing right, it'll go right. Presumably as per your previous post, you're flipping the local scale and now you're expect that to be a rotation which it isn't.

    Also, you should NOT be modifying the Transform when using physics as I mentioned previously.
     
  6. zulo3d

    zulo3d

    Joined:
    Feb 18, 2023
    Posts:
    510
    Check to see if your Shoot script is actually on the player object. I'm always dropping scripts onto the wrong object. It's really easy to do.
     
  7. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    It is
     
  8. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,563
    That just sounds like it is time for you to start debugging!

    Here is how you can begin your exciting new debugging adventures:

    You must find a way to get the information you need in order to reason about what the problem is.

    Once you understand what the problem is, you may begin to reason about a solution to the problem.

    What is often happening in these cases is one of the following:

    - the code you think is executing is not actually executing at all
    - the code is executing far EARLIER or LATER than you think
    - the code is executing far LESS OFTEN than you think
    - the code is executing far MORE OFTEN than you think
    - the code is executing on another GameObject than you think it is
    - you're getting an error or warning and you haven't noticed it in the console window

    To help gain more insight into your problem, I recommend liberally sprinkling
    Debug.Log()
    statements through your code to display information in realtime.

    Doing this should help you answer these types of questions:

    - is this code even running? which parts are running? how often does it run? what order does it run in?
    - what are the names of the GameObjects or Components involved?
    - what are the values of the variables involved? Are they initialized? Are the values reasonable?
    - are you meeting ALL the requirements to receive callbacks such as triggers / colliders (review the documentation)

    Knowing this information will help you reason about the behavior you are seeing.

    You can also supply a second argument to Debug.Log() and when you click the message, it will highlight the object in scene, such as
    Debug.Log("Problem!",this);


    If your problem would benefit from in-scene or in-game visualization, Debug.DrawRay() or Debug.DrawLine() can help you visualize things like rays (used in raycasting) or distances.

    You can also call Debug.Break() to pause the Editor when certain interesting pieces of code run, and then study the scene manually, looking for all the parts, where they are, what scripts are on them, etc.

    You can also call GameObject.CreatePrimitive() to emplace debug-marker-ish objects in the scene at runtime.

    You could also just display various important quantities in UI Text elements to watch them change as you play the game.

    Visit Google for how to see console output from builds. If you are running a mobile device you can also view the console output. Google for how on your particular mobile target, such as this answer for iOS: https://forum.unity.com/threads/how-to-capturing-device-logs-on-ios.529920/ or this answer for Android: https://forum.unity.com/threads/how-to-capturing-device-logs-on-android.528680/

    If you are working in VR, it might be useful to make your on onscreen log output, or integrate one from the asset store, so you can see what is happening as you operate your software.

    Another useful approach is to temporarily strip out everything besides what is necessary to prove your issue. This can simplify and isolate compounding effects of other items in your scene or prefab.

    Here's an example of putting in a laser-focused Debug.Log() and how that can save you a TON of time wallowing around speculating what might be going wrong:

    https://forum.unity.com/threads/coroutine-missing-hint-and-error.1103197/#post-7100494

    "When in doubt, print it out!(tm)" - Kurt Dekker (and many others)

    Note: the
    print()
    function is an alias for Debug.Log() provided by the MonoBehaviour class.
     
  9. zulo3d

    zulo3d

    Joined:
    Feb 18, 2023
    Posts:
    510
    How do you change the "direction" of the player?. Can you show the script that sets the player's direction?.
     
  10. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    I've tried doing it that way. It partially works as I can have the player rotate and that fixes the direction problem. However, it creates another problem where the character rotates continuously
     
  11. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    OK then, I'm trying with the debugging and its not easy to understand, I'm planning on looking at video tutorials to help
     
  12. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    Also I'm doing this on a computer
     
  13. zulo3d

    zulo3d

    Joined:
    Feb 18, 2023
    Posts:
    510
    That's a relief!
     
    mopthrow and Kurt-Dekker like this.
  14. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    I'll try and do debugging. I should also mention this is for a game jam that ends on thursday, so I have limited time but enough so far that I have a standard game with simple but functional mechanics
     
  15. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,563
    Debugging is NOT optional. It is part and parcel of programming.

    That's awesome! Now you are motivated to work fast and focus your attention productively.
     
  16. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    Already have another problem XD
    upload_2023-7-14_17-39-58.png
    This window at the bottom, I think I accidentally removed it and I have no idea how to get it back.
     
  17. IronDan21

    IronDan21

    Joined:
    Mar 22, 2023
    Posts:
    28
    Ignore this, just fixed it