Search Unity

Severe performance issue

Discussion in 'FPS.Sample Game' started by carlself, Nov 30, 2018.

  1. carlself

    carlself

    Joined:
    Feb 5, 2016
    Posts:
    13
    Code in ClientGameWorld.HandleTime has severe performance issue. Line 420 tries to loop for (m_PredictedTime.tick - prevTick) times, which gets game stuck when server run for a long time before client joined. This can be easily tested.
     
    carlself, Nov 30, 2018
    #1

  2. carlself

    carlself

    Joined:
    Feb 5, 2016
    Posts:
    13
    It seems that loop for min(m_PredictedTime.tick - prevTick, NetworkConfig.commandClientBufferSize) times is fine.
     
    carlself, Nov 30, 2018
    #2

  3. Mogens_H

    Mogens_H

    Unity Technologies

    Joined:
    Mar 7, 2017
    Posts:
    20
    I think you are right - thanks. We will change that.
     
    Mogens_H, Dec 4, 2018
    #3