Setting objects with a tag active

I'm making a racing game, one of the modes is a battle mode where the cars have weapons attached. I thought a simple way to do this was to activate all objects with the tag "Weaponry" (the weapons) when there is an object with the tag "PowerupsActive" in the scene, what's wrong with my script?

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class EnableWeapons : MonoBehaviour
6. {
7.     // Start is called before the first frame update
8.     void Awake()
9.     {
10.         GameObject[] objs = GameObject.FindGameObjectsWithTag("PowerupsActive");
11.         if (objs.Length == 1)
12.         {
13.             GameObject.FindGameObjectWithTag("Weaponry").SetActive(true);
14.         }
15.          
16.  
17.     }
18.  
19.  
20. }

 

FindGameObjectWithTag() only returns a single object. You need the slightly different FindGameObjectsWithTag(). You probably made a typo. You will also need to iterate over all the objects in the returned array with a loop to set each of them active.

 

How would I do this? Sorry, don't have much scripting knowledge

 

Check out https://docs.unity3d.com/ScriptReference/GameObject.FindGameObjectsWithTag.html

There are two example code snippets there. The first code snippet calls FindGameObjectsWithTag, then it uses a foreach loop to iterate over all the results. Try making a foreach loop similar to the example, and set each object to active instead of whatever they're doing in the example.

 

I get the idea, but I'm not sure how to write it out

Code (CSharp):

1. using System.Collections;
2. using System.Collections.Generic;
3. using UnityEngine;
4.  
5. public class EnableWeapons : MonoBehaviour
6. {
7.     public GameObject weapon;
8.     public GameObject[] weapons;
9.     void Start()
10.     {
11.         if (weapons == null)
12.             weapons = GameObject.FindGameObjectsWithTag("Weaponry");
13.  
14.         foreach (GameObject weapon in weapons)
15.         {
16.             weapon.SetActive(true);
17.         }
18.     }
19. }
20.  

 

I fixed the problem, I did this by doing the opposite- disabling them when I didn't need them

Code (CSharp):

1. public GameObject[] weapons;
2.     void Update()
3.     {
4.         weapons = GameObject.FindGameObjectsWithTag("Weaponry");
5.  
6.         foreach (GameObject weapon in weapons)
7.         {
8.             weapon.SetActive(false);
9.         }
10.     }