setactive does nothing

im new to unity
trying to disable a canvas when the player touches a collider but it doesnt work

Code (CSharp):

1.  public Canvas canvas;
2.     void Update()
3.     {
4.         void OnTriggerEnter2D(Collider2D col)
5.         {
6.             if (col.tag == "Player")
7.             {
8.      
9.                 canvas.gameObject.SetActive(true);
10.             }
11.             else
12.             {
13.              
14.                 canvas.gameObject.SetActive(false);
15.             }
16.         }
17.     }

 

Start by putting a Debug.Log before line 6 here, see if OnTriggerEnter2D is being called at all.

 

You've got your OnTriggerEnter2D inside the Update() method...

 

Well, I guess the good news is that now local functions are allowed in Unity

 

it gets printed if it's not inside the update function but it doesn't show the canvas

 

Code (csharp):

1. void OnTriggerEnter2D(Collider2D col)
2. {
3.             Debug.Log("Is player entering? : " + (col.tag == "Player"));
4.             if (col.tag == "Player")
5.             {
6.                   canvas.gameObject.SetActive(true);
7.             }
8. }
9.  
10. void OnTriggerExit2D(Collider2D col)
11. {
12.             Debug.Log("Is player exiting? : " + (col.tag == "Player"));
13.             if (col.tag == "Player")
14.             {
15.                   canvas.gameObject.SetActive(true);
16.             }
17. }

You're using OnTrigger... so make sure you're collider is set as a trigger.

 

And make sure the object's tag is correct

 

If(col.gameObject.tag =="Player")

Make sure to add gameObject before tag, so you can get the tag of the game object that the collider is attached to.

 

it works now thank you