Search Unity

SEGI (Fully Dynamic Global Illumination)

Discussion in 'Assets and Asset Store' started by sonicether, Jun 10, 2016.

  1. RockSPb

    RockSPb

    Joined:
    Feb 6, 2015
    Posts:
    97
    Oh man! GI is realy hard thing so you should't say such things!)
    May be you need to take a step back and start you work on point when core visual is corret?
    I think it difficult to fix such complex systems when you don't know what went wrong.
     
    neoshaman likes this.
  2. ivanmotta

    ivanmotta

    Joined:
    Jun 19, 2013
    Posts:
    21
    Hey @Ninlilizi ! Cheers from Rio! And a big, fat thank you for all the effort on building this asset!
    I'm having a little trouble on a big environment. My game is a procedural dungeon-crawler on office buildings, and as you can see from the screenshot attached, the distant geometry is kinda glitchy. I messed with all the settings, and all the free and open source fog assets available to try to cover it, but seems like GI is drawn on top of everything, so there's no way my fog covers these parts (and yes, it is set to maximum like 30, and camera clipping on 60 for testing).
    Is there a workaround? Re-order the render or something?
    Oh and I'm using you latest branch on Github.
    Cheers, and thanks!
     

    Attached Files:

  3. Ninlilizi

    Ninlilizi

    Joined:
    Sep 19, 2016
    Posts:
    265
    If you find line 51 of SEGI_NKLI.cs it will look like

      [PostProcess(typeof(SEGIRenderer), PostProcessEvent.AfterStack, "NKLI/SEGI")]


    Change the 'AfterStack' to something something else.... just delete that bit and start typing 'before' .... Intellisense will give some options.... Pick something that sounds super early in there... I forget what the options are..... But that'll let you layer fog effects over the top.
     
    ivanmotta likes this.
  4. jefferytitan

    jefferytitan

    Joined:
    Jul 19, 2012
    Posts:
    80
    I wonder what the best default option for an effect like this would be? My gut feeling is somewhat early, because it occurs in worldspace, which should happen before all the 2D effects like bloom etc. What kind of things should happen before GI?
     
  5. Ninlilizi

    Ninlilizi

    Joined:
    Sep 19, 2016
    Posts:
    265
    That was how I originally had it.... But a bunch of pages of this thread ago there were requests to push it to later in the pipeline so I obliged.
     
  6. jefferytitan

    jefferytitan

    Joined:
    Jul 19, 2012
    Posts:
    80
    Hmm, I'd be curious to know their reasoning and if they still feel it applies. For example with volumetric light included there may be less reasons now?
     
  7. Ninlilizi

    Ninlilizi

    Joined:
    Sep 19, 2016
    Posts:
    265
    I think I'm going to change it back when I get a moment...

    Also, volumetric light?
    Are you confusing SEGI with Nigiri?
     
  8. jefferytitan

    jefferytitan

    Joined:
    Jul 19, 2012
    Posts:
    80
    Oh goodness, I already forgot you were working on both!
     
  9. soleron

    soleron

    Joined:
    Apr 21, 2013
    Posts:
    87
    where can we get this asset for testing?
     
  10. Mauri

    Mauri

    Joined:
    Dec 9, 2010
    Posts:
    1,422
    If you mean the new improved SEGI version, see https://github.com/ninlilizi/SEGI .
    Should you mean Ninlilizi's new GI approach (as shown in #2431) instead: it's not yet available.
     
    Alverik and soleron like this.
  11. QuantumTheory

    QuantumTheory

    Joined:
    Jan 19, 2012
    Posts:
    1,030
    I'm a little confused. SEGI is now broken and this thread has turned into someone else's GI solution?

    I downloaded SEGI. My scene view is corrupted and upside down and the sample scenes look nothing like the screenshots.
     
  12. PROE_

    PROE_

    Joined:
    Feb 20, 2016
    Posts:
    12
    Ninlilizi was working on improving it but nothing new has been made in about 2 weeks so I guess she's working on her own GI solution. SEGI has some problems from what I understand.

    If you want SEGI from screenshots checkout it's original repository @ https://github.com/sonicether/SEGI
     
  13. jefferytitan

    jefferytitan

    Joined:
    Jul 19, 2012
    Posts:
    80
    SEGI was originally by SonicEther, but he has basically abandoned all Unity development from what I understand. Ninlilizi has kindly decided to continue development, however as is natural with a new developer taking over a project and doing a lot of new development, things can break. I believe she has marked some as release builds, so they may be more stable.

    Separately she has decided to build her own GI solution currently called Nigiri because of shortcomings in SEGI which she feels aren't fixable. She hasn't started a new forum thread yet on that, but she plans to. Possibly she's focusing more on that than SEGI right now.
     
    Alverik likes this.
  14. QuantumTheory

    QuantumTheory

    Joined:
    Jan 19, 2012
    Posts:
    1,030
    Thanks folks. Looks like it's just broke for VR as I've tried multiple versions. Good luck @Ninlilizi !
     
  15. soleron

    soleron

    Joined:
    Apr 21, 2013
    Posts:
    87
    Yeah looks like it does not work for VR at this point. Sadly. And does not support SRP either. Pity. BUT for those not interested in using the latest Unity it is still an amazng tool to improve your visuals in ways not yet possible in SRP and new versions of Unity.
     
    Last edited: Dec 14, 2018
  16. jjejj87

    jjejj87

    Joined:
    Feb 2, 2013
    Posts:
    254
    Nin, any progress update? :D
     
  17. neoshaman

    neoshaman

    Joined:
    Feb 11, 2011
    Posts:
    4,114
    holidays, expect progress after the solstice break
     
    jejacks0n likes this.
  18. ivanmotta

    ivanmotta

    Joined:
    Jun 19, 2013
    Posts:
    21
    Hey @Ninlilizi any news on the development? I wanted to know if this is still gonna happen, I want to publish my game but would love some extra performance... Just some bug crushing would be lovely.
    BTW, anybody got it working well with 2018.3? I have some strange behaviour: if it is enabled on Post Processing, I get all sort of errors and pink shaders. If I disable it, they go away and it works! But disabled?!?!
     
  19. Ninlilizi

    Ninlilizi

    Joined:
    Sep 19, 2016
    Posts:
    265
    Still alive... Having some general life issues.

    The short list...
    * Everything is broken on 2018.3 onwards, I plan to fix this.
    * SEGI for a while has produced some seriously sub-par results versus SE's code. During my absence I have become upto speed enough to fix this and make it render correctly. So I plan to fix this also.
    * Regarding VR, every new major editor release finds new and interesting way to break anything that intersects VR and shaders. Joy is me.
    * Regarding SEGI, don't expect anything breaking in terms of additional performance. But I do intend to fix the bugs that make my existing innovations problematic.
    * SRP support, I don't plan to make any further effort here till after the SRP's leave their preview state.

    * With Nigiri ... Being quiet here.... But I want to avoid putting myself in a position where I'm obligated to officially support it till after I've got my life together again and can reliably commit to being able to do so.
     
    Vytek, Alverik, nirvanajie and 17 others like this.
  20. ivanmotta

    ivanmotta

    Joined:
    Jun 19, 2013
    Posts:
    21
    Hey thank you for the answer! Hope everything gets better, life can be a little Katamari sometimes... I wish I could program shaders to help you, but my c# skills are way lower than required...
     
    RB_lashman likes this.
  21. cerrec

    cerrec

    Joined:
    Jan 19, 2017
    Posts:
    25
    Hi, Just want to let you know you've got another fan here! I love SEGI and anything you can do to improve it is most welcome.
     
    RB_lashman likes this.
  22. florianalexandru05

    florianalexandru05

    Joined:
    Mar 31, 2014
    Posts:
    875
    Hello, I just want to say I have been using Segi for a while and i like it! I used Segi for my renders and videos and performance was alright, however my framerate on video wasn't that great, I have a older video card. I should sure like to see this project improve!

    You don't really notice the gi that well in outdoor scene but it improved the quality of the visuals.


     
    NeatWolf, konsic, Baldinoboy and 3 others like this.
  23. VCDESIGN

    VCDESIGN

    Joined:
    Jul 18, 2017
    Posts:
    43
    Hello, does SEGI works in 2018.3?
     
  24. florianalexandru05

    florianalexandru05

    Joined:
    Mar 31, 2014
    Posts:
    875
    I don't think so not atm, the version I'm using from Github is for Unity 5.
     
  25. ivanmotta

    ivanmotta

    Joined:
    Jun 19, 2013
    Posts:
    21
    I got some issues on setting up, but after a little messing with settings and scripts, yes it works! Also confirmed working on PC builds!
     
  26. VCDESIGN

    VCDESIGN

    Joined:
    Jul 18, 2017
    Posts:
    43
    Could you release the one you've fixed?
     
  27. ivanmotta

    ivanmotta

    Joined:
    Jun 19, 2013
    Posts:
    21
    Well it was more about scene settings than scripting. Basically my project was ok with 2018.1, upgraded to 2018.3 and started getting HLSL merge errors and pink shaders, so disabled SEGI on post processing stack, and somehow it stayed on even if turned off. One issue I had turn around and forget was reflection probes: sometimes they work, and other just give some high value reflections that mess everything (mostly with standard shaders), so right now I'm only using SSR, way below ideal, but works.
     
    RB_lashman likes this.
  28. dojoman

    dojoman

    Joined:
    Jul 24, 2014
    Posts:
    272
    RB_lashman likes this.
  29. Abuthar

    Abuthar

    Joined:
    Jul 12, 2014
    Posts:
    87
    I've got a question for anyone out there : I just bought this amazing skin shader but it doesn't work properly with SEGI. Reflections work for some reason, but the GI does not, including light from emissive objects. Would anyone be able to point me into the right direction in making a shader compatible with SEGI? (documentation, examples, etc) I'm new to shader programming but am willing to learn how to do it myself as what the creator of the plugin is asking to make it compatible for me is... out of my budget.
     
    RB_lashman likes this.
  30. neoshaman

    neoshaman

    Joined:
    Feb 11, 2011
    Posts:
    4,114
    Both are screenspace this will be hard or as easy as finding the right order to apply the shader
     
    RB_lashman likes this.
  31. Abuthar

    Abuthar

    Joined:
    Jul 12, 2014
    Posts:
    87
    Where do i start? Like I said Reflectivity works but GI doesn't.
     
    RB_lashman likes this.
  32. jjejj87

    jjejj87

    Joined:
    Feb 2, 2013
    Posts:
    254
    If anyone is curious, SEGI does work just fine 19.1.6f

    It does get some errors during runtime, but nothing you can't fix quickly.
     
  33. cerrec

    cerrec

    Joined:
    Jan 19, 2017
    Posts:
    25
    What sort of errors?