Bug search keeps resetting scope

then

esc

ctrl+space
and it's back to project

 

No.

do you think it's better like that?

 

Definitely.

 

Also if you could fix the show tab resetting that'd be extra space for the list.

Where is the sync option?

 

I see, that's interesting. Do you have a video showcasing the benefit of contextual search like that? Within a production off course because as your speed goes up implicit things get in the way. Even with the syn off (it doesn't persist, it should to be consistent with unity behavior or toggles)
Now, I am sure you will fix that non persistence of sync toggle.
But here is my comment on what you are trying to do: instead of pushing for use of the massive search window for advanced queries, could you instead make accessible those queries inside the imbedded search field?

I had mapped the contextual search instead of search all by mistake.

Now that this is search all, ctrl+space calls the search all tab unless a search field is editing

 

nice! auto wildcard type. Advanced should be the default, why is it not?

 

"Advanced search" (ie. QuickSearch) requires a search cache to be built, and performs a bit worse than the old one. It's also got this really annoying property where it goes "there's no results for your search" while what it really means it "we're still waiting for the background search thread to finish searching".

So there are some reasons to still use the old one.

 

@sebastiengrenier you got this?

Got the notes on that? I'm interested in all things UI/behavioral

 

It makes sense and it's good that you want to not perturb muscle memory, but then why did you add this button?

 

This is opposite to my experience - it returned less results.

• The hierarchy search box wouldn't show results from the DontDestroyOnLoad scene
• The object picker would prepopulate the query with the entire namespace of the type of object (t:MyNamespace.MyClass) and would return zero results. You'd have to manually change it to t:MyClass to get any hits.
• The project search box would work, mostly, until sometimes the index was busy being rebuilt in which case it returned a mix bag of results. So it felt completely unreliable - I'd search for something "UIWindow" - and I'd get 3-4 hits. Something feels off. I wait a little, and search again, and get my expected number of results. Sometimes I get no hits.
• It also slowed down search results considerably. Not seconds of time, but enough time to make it feel very sluggish and slow. Searching project for a simple string felt like a heavy operation.
• The constant index scanning/regeneration slows down the editor considerably, and can take a long time to resolve.
• This is Unity 2021 LTS

Lots of great ideas with the new search system. But its too slow/heavy and does not fill me with faith with the results it returns. (index is constantly in flux and outdated, and so are the results).

I trust the legacy search because I know it will definitely find everything in the project for the given query, if it is a query it supports. (name search, search by type, etc).

Baste touched on this last point. The new search presents the results of the query as if it is definitive - No results found! but in reality, there might actually be results - its just waiting for the index to build. I just can't put any faith in it!

 

I never use that, anyone? Seems like power user workflow which shouldn't take up space, there is a shortcut for it as we've seen.

If you could do it that's be great.

 

After having used advanced for a few weeks now and with the project growing in asset# I know why it's not default: it's much slower than builtin.

 

This one.

I don't know how many assets I have. Advanced is noticeably slower whereas classic is instant. Note that I use 10ms debounce threshold.

 

On my side, searching for eg. t:SomeClass is instant in project view, always. The first time I boot QS after opening, it takes a few seconds to get itself ready to show anything. Any recompile or minor asset change makes it not give the correct results for a little bit as well.

 

Anything that can help, we spend a LOT of time in search.
And if you could please push a fix to the sync-off ignore bug... I keep typing stuff then look for spelling mistake because the list is empty only to realize that it's on some tab instead of all.

 

Just to update what I'm trying to say above, what's happening a ton with Quick Search is this:

- I open Quick Search and search for a prefab, and get a result fairly quickly
- I make any code change
- I open Quick Search and search for the exact same thing
- Quick Search spends 5+ seconds spinning showing "no results" before it finds the old thing

My code change didn't in any way change the thing I searched for.

So there's a bug where Quick Search has realized that there is some change in some asset, and because of that fails to find any results whatsoever. I assume that this is to avoid the window hanging, but being responsive and not showing any results is almost just as bad as hanging.

There's only two real solutions where QS is good enough to replace the default search:
- it's so fast at updating the database that my above problem isn't noticeable
- It's able to show results from the un-updated index while the index is updating, without that causing hangs.

 

Yeah, it for sure doesn't look like it's able to use the old index during indexing. It's at least not showing results that used to be there!

Does the old index live in memory? Ie. could it be that since there's been an assembly reload, the required data's been evicted? The assembly QS lives in shouldn't have been reloaded, but there might be a safety feature where you're ditching data since some of it might not be valid anymore with the new data?