Search Unity

[saveduringplay] For Custom Cinemachinecomponent Doesn't Seem To Work?

Discussion in 'Cinemachine' started by Baste, Apr 12, 2019.

  1. Baste

    Baste

    Joined:
    Jan 24, 2013
    Posts:
    6,338
    I've got a custom CinemachineComponent, that I've attached the [SaveDuringPlay] attribute to. I've also toggled the "save during play" checkbox on the vCam with this component on it.

    That doesn't seem to do anything, my values gets reverted to the starting values after exiting play mode. The built-in components does get saved, so there seems to be a difference.

    I can't really tell by browsing the code how the [SaveDuringPlay] attribute is processed. Is there a custom inspector I have to have my component inherit from?
     
    Baste, Apr 12, 2019
    #1

  2. Gregoryl

    Gregoryl

    Unity Technologies

    Joined:
    Dec 22, 2016
    Posts:
    7,730
    You just need the [SaveDuringPlay] on your class. The rest is automatic, not dependent on inspectors. If you like, you can PM me the class and I can take a look at it.
     
    Gregoryl, Apr 12, 2019
    #2

  3. xiao-xxl

    xiao-xxl

    Joined:
    Nov 16, 2018
    Posts:
    48
    It does not work for data in collections such as arrays or lists.
     
    xiao-xxl, Feb 10, 2022
    #3

  4. xiao-xxl

    xiao-xxl

    Joined:
    Nov 16, 2018
    Posts:
    48
    Sorry, Works for array, but not for list.
     
    xiao-xxl, Feb 10, 2022
    #4

  5. xiao-xxl

    xiao-xxl

    Joined:
    Nov 16, 2018
    Posts:
    48
    Remove array item works, but add array item not wrok.
     
    xiao-xxl, Feb 10, 2022
    #5

  6. gaborkb

    gaborkb

    Unity Technologies

    Joined:
    Nov 7, 2019
    Posts:
    856
    I could reproduce a bug with Lists, but not with arrays (e.g. int[]). We'll investigate further.
     
    gaborkb, Feb 14, 2022
    #6

  7. omangbaheti

    omangbaheti

    Joined:
    Jun 17, 2020
    Posts:
    1
    Hey @Baste were you able to make it work. I'm facing the same problem
     
    omangbaheti, Jan 26, 2023
    #7

  8. Baste

    Baste

    Joined:
    Jan 24, 2013
    Posts:
    6,338
    Can't remember! I think we stopped solving that particular problem with a CinemachineComponent, so it stopped being relevant.
     
    Baste, Jan 26, 2023
    #8