Search Unity

Search

Official Quick Search Preview

Discussion in 'Editor Workflows' started by benoitd_unity, Feb 26, 2019.

Page 3 of 19

sebastienp_unity

Unity Technologies

Joined:

Feb 16, 2018

Posts:

201

I have written some not so horrible doc for the Quick Search tool. Keep in mind that English is not my first language Documentation is available from the Package Manager Window -> Quick Search (click the View Documentation link). It should open your browser at that page: https://docs.unity3d.com/Packages/com.unity.quicksearch@1.0/manual/index.html

The documentation explains our filter system.

A few more clarifications on the filter system:

- There are 2 levels of filter. SearchProvider filters: useful to enable a single Search Provider. These filters must be specified at the BEGINNING of the search query

player -> p for project, will only look for asset
h:Main Camera -> h for hierarchy. Will only look in the scene
me:Create Folder -> me for menu. Will look for create folder menu item
se:VFX -> se for settings.

All the SearchProvider filter are shown in the FilterWindow:

Arguably "p:" and "h:" should maybe be renamed something else... "as:" and "sc:"?

There is also the concept of "in provider filter". Which means that each provider can support its own filtering. The AssetProvider and SceneProvider supports the same query language as the Project Window and the Hierarchy Window. Which means you can use

t:<Aset type>
a:<package or assets>

And such.

For your case, if you would want only prefabs with Player in their name the more precise query would be:

"player t: Prefab" -> in that case p: limits the search to the AssetProvider

Baste said: ↑

Thanks, that's a great explanation.

What I want to do in the case where I'm searching for "Player trefab" is to get all prefabs that match the string Player. The best way to do that is to search for "Player" with only the prefab search provider enabled.

The provider search filter token seems to be the perfect way to handle that. You have a p: prefix that can be used to filter for assets. Could I suggest to add more filters, and make them easier to remember?

as: for assets
sc: for scene
me: for menu
pr: for prefabs
cs: for scripts (.cs file)
sh: for shaders

Or something along those lines.
Click to expand...

sebastienp_unity, May 10, 2019

#101
fherbst

Joined:

Jun 24, 2012

Posts:

802

Hey, not sure why nobody told you yet, but the default shortcut (Alt + ') doesn't work on German keyboards, as this is not a separate key there. If you want the same spot, it would be "Alt + /".

I guess you don't want people to have to change the shortcut first before it works at all.

fherbst, May 13, 2019

#102

pragmascript likes this.
fherbst

Joined:

Jun 24, 2012

Posts:

802

Is it somehow possible to change the default action or better, change the default action per file/asset type?

If I'm searching for scripts I really want the default action to be to Open them, not select the item in the project pane which is pretty useless. Note that I wouldn't want that for image files, so it should really be type-dependant.

fherbst, May 13, 2019

#103
Baste

Joined:

Jan 24, 2013

Posts:

6,334

It seems like the shorcuts are bound by physical location - I'm on a Norwegian keyboard, and the quick search launches just fine when I press ctrl+æ.

Baste, May 13, 2019

#104
fherbst

Joined:

Jun 24, 2012

Posts:

802

Next note: please make the shortcut for opening the modal window also close the modal window. This should be "quick" - I don't want to have press Escape or use my mouse if I change my mind about searching a file.

Also, would be great if the online search had an Item for "regular web search". If you are for whatever reason not allowed to do that would be great to have a way to enter custom prefix URLs for the online search (similar to what you can do in most browsers by specifying a "Query URL" e.g. "https://duckduckgo.com/?q=%s".

fherbst, May 13, 2019

#105
fherbst

Joined:

Jun 24, 2012

Posts:

802

@Baste, I think they are bound by Keycode, at least that's the behaviour when I change keyboard layouts here (good way to test that is using the "-" key which is in different places on different keyboard layouts).
Maybe there is already some logic in place to deal with specific layouts / non-existing keys, and it fails because my system language is English? Not sure.

fherbst, May 13, 2019

#106
sebastienp_unity

Unity Technologies

Joined:

Feb 16, 2018

Posts:

201

- Different defualt actions per item types: This is on the todo list. No ETA.
- Shortcut: if you are on 19.1 (and onward) you can use the shortcut manager to rebing any shortcuts.
- General WebSearch: good idea.
- Closing the window: the window closes when you activate an item or if you press Escape. I am unsure how reusing the same shortcut would be quicker than Escape (which is mostly a cancel key in any software)?

fherbst said: ↑

@Baste, I think they are bound by Keycode, at least that's the behaviour when I change keyboard layouts here (good way to test that is using the "-" key which is in different places on different keyboard layouts).
Maybe there is already some logic in place to deal with specific layouts / non-existing keys, and it fails because my system language is English? Not sure.
Click to expand...

sebastienp_unity, May 13, 2019

#107
fherbst

Joined:

Jun 24, 2012

Posts:

802
Thanks for your replies.

Regarding the shortcut: the issue here is that people not using english keyboard layout will have to rebind the shortcut, it would be better if you choose one that actually works across keyboards by default.

Closing the window: well, sometimes it just happens. You wanna find something and open the Quick Search but then you see it directly. Instead of typing or moving the mouse and clicking you close the modal window again and just continue where you left off.
Examples for this kind of on-off button behaviour include:

the Windows key (opens the Start Menu, but closes it as well)

any task bar (e.g. Windows Task bar) - you can click on sth to open it, if you click again it closes. Yes, you could have also clicked on "Minimize" but it takes much longer

(Additionally, in general it's a good thing UX-wise if an action can be reverted as easily as started and doesn't require another key/another action.)
fherbst, May 13, 2019

#108
fherbst

Joined:

Jun 24, 2012

Posts:

802

And another suggestion: could you provide a quick search history?

(something like this - could even be smartly sorted based on how often you searched for something, like "last five", "most searched five")

fherbst, May 13, 2019

#109
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

fherbst said: ↑

And another suggestion: could you provide a quick search history?
Click to expand...

Hi,

We had this at the beginning, but it got removed for UX reasons. We could bring it back on the table and see if we want to give it another try or not.

That said, if you open the Quick Search window and press Alt+Up arrow and Alt+Down arrow, it will cycle through the last 10 search queries you've done.

jonathans42, May 13, 2019

#110

Baste likes this.
Lurking-Ninja

Guest

jonathans42 said: ↑

We had this at the beginning, but it got removed for UX reasons. We could bring it back on the table and see if we want to give it another try or not.
Click to expand...

I think it can be a separate tab, and not shown by default. Cycling through these two tabs by Alt+Left and Alt+Right?

Lurking-Ninja, May 13, 2019

#111
Baste

Joined:

Jan 24, 2013

Posts:

6,334

sebastienp_unity said: ↑

Arguably "p:" and "h:" should maybe be renamed something else... "as:" and "sc:"?
For your case, if you would want only prefabs with Player in their name the more precise query would be:

"player t: Prefab" -> in that case p: limits the search to the AssetProvider
Click to expand...

Thanks for the explanation. I would prefer it if you added more search provider filters, so we can type less things. A provider filter that limited to just the prefab provider or just the script provider would allow me to type a lot less.

Baste, May 14, 2019

#112
xenonmiii

Joined:

Aug 2, 2010

Posts:

147

Hi all,
I was working on a similar tool called Omnibar before Quick Search preview by Unity was announced. Being spoiled with something like Alfred or JetBrains' Rider searching capabilities, I wanted to create a similar tool for Unity as I was getting frustrated wasting time to search for stuff as the projects get bigger and bigger. Also wanted to create a tool for supporting custom commands (not just searching). Named groups, moving items around, loading scenes additively are just a few.

I just had a look at what Unity has done, and I humbly still think that my tool has an edge of Unity's Quick Search, which is getting to your assets/gameobject really fast, i.e. you type less to get to your assets. You can use CamelCasing, or partial substrings to get quick access to all your assets, which from my testing is not supported in Unity's Quick Search (1.0.9 at least).

Here's a quick video for comparison where I try to search for an item both in Omnibar and Unity's Quick Search:

A bit of shameless ad for my tool, but if you're interested you can grab Omnibar from the Asset Store:
http://u3d.as/1sN9

Here's a more comprehensive video of Omnibar in action:

P.S. Omnibar shows the history searches when you invoke it, and you also can modify the aliases on how to search for staff as there is an externalized config file you can easily edit

xenonmiii, May 14, 2019

#113

Lahcene, Azzopardi and FlyingSquirrels like this.
sebastienp_unity

Unity Technologies

Joined:

Feb 16, 2018

Posts:

201

Great work on the Omnibar @xenonmiii! At first quicksearch was called OmniTool but marketing didn't like the name

Some information on the latest release:

- Search will be indexed and way faster than the asset databse. Our tests on projects with more than 350K items are lighning fast.
- Search will support CamelCase matching.
- A few more goodies.

@xenonmiii : Can the Omnibar be extended? Our goal when we created quicksearch was that everything could be extended:

- You can easily create a new provider, provide your own indexer, filter and such. This is how we have provider for Assets, Scene objects, Menus, ettings, web search and a calculator. We should bring in a not so distant future provider for packages and more.
- You can register any custom action for any provider (orthogonal to provider registration). Which means you can augment what the asset provider can do.

Don't get me wrong I do not want to start a tool war I feel the more great tools we have available for the Unity ecosystem the best it is for our users. Keep up the great work.

xenonmiii said: ↑

Hi all,
I was working on a similar tool called Omnibar before Quick Search preview by Unity was announced. Being spoiled with something like Alfred or JetBrains' Rider searching capabilities, I wanted to create a similar tool for Unity as I was getting frustrated wasting time to search for stuff as the projects get bigger and bigger. Also wanted to create a tool for supporting custom commands (not just searching). Named groups, moving items around, loading scenes additively are just a few.

I just had a look at what Unity has done, and I humbly still think that my tool has an edge of Unity's Quick Search, which is getting to your assets/gameobject really fast, i.e. you type less to get to your assets. You can use CamelCasing, or partial substrings to get quick access to all your assets, which from my testing is not supported in Unity's Quick Search (1.0.9 at least).

Here's a quick video for comparison where I try to search for an item both in Omnibar and Unity's Quick Search:

A bit of shameless ad for my tool, but if you're interested you can grab Omnibar from the Asset Store:
http://u3d.as/1sN9

Here's a more comprehensive video of Omnibar in action:

P.S. Omnibar shows the history searches when you invoke it, and you also can modify the aliases on how to search for staff as there is an externalized config file you can easily edit
Click to expand...

sebastienp_unity, May 14, 2019

#114
xenonmiii

Joined:

Aug 2, 2010

Posts:

147

@sebastienp_unity Omnibar can be extended with custom commands, and add your own file types that can be indexed by modifying a config file then force a re-index. Not saying it's as extensible as Unity's tool. Wanted to go down that path of extensibility but wanted to test the waters first as see how it goes before exposing more stuff.

Glad to hear you will be adding CamelCasing too and having a faster indexing service. Will it have partial substring matching (like you mix camel casing with other substrings)?

It was still a nice learning experience to create Omnibar. I still find it handy myself including for creating named groups (instead of number shortcuts, which I always get confused).

xenonmiii, May 14, 2019

#115
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Lurking-Ninja said: ↑

I think it can be a separate tab, and not shown by default. Cycling through these two tabs by Alt+Left and Alt+Right?
Click to expand...

Another tab could be an idea. As for Alt+Left and Alt+Right, they are already used to open the filter window and to select more actions on the selected item (when you see the small vertical dots on the right) respectively.

jonathans42, May 14, 2019

#116
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

We added selection tracking to the `SearchProvider` API. i.e. this can be used to track similarly named objects in an Unity scene and better identify them.

jonathans42, May 14, 2019

#117

SugoiDev and Lahcene like this.
sient

Joined:

Aug 9, 2013

Posts:

602

jonathans42 said: ↑

We added selection tracking to the `SearchProvider` API. i.e. this can be used to track similarly named objects in an Unity scene and better identify them.
Click to expand...

Nice! Does this/can this also work for assets? That'd eliminate my ping-only action provider[1].

1: https://forum.unity.com/threads/quick-search-preview.635863/page-2#post-4462387

sient, May 15, 2019

#118

jonathans42

Unity Technologies

Joined:: Jan 25, 2018

Posts:: 514

Yes it will but in version ~1.1.1. Now we just published version 1.1.0-preview.1.

Changelog:



- Add a switch to let search provider fetch more results if requested (e.g. `SearchContext.wantsMore`)

- Add selection tracking to the `SearchProvider` API.

- Fix search item caching.

- Improve quick search debouncing when typing.

- Ping scene objects when the selection changes to a scene provider search item in the Quick Search window.

- Track project changes so search provider can refresh themselves.

- Update file indexes when the project content changes.

- Update UI for Northstar retheming.

jonathans42, May 15, 2019

#119

SugoiDev likes this.

jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Baste said: ↑

What I want to do in the case where I'm searching for "Player trefab" is to get all prefabs that match the string Player. The best way to do that is to search for "Player" with only the prefab search provider enabled.
Click to expand...

If you try the new (experimental) indexed asset provider (see quick search settings) you should be able to simply type: "prefab player" or "player prefab" or even "pla pref" since we also match the asset file extension. You can also use the * wildcard, but that might be slow depending on the amount of assets you have in your project, i.e. "pl*.prefab".

jonathans42, May 15, 2019

#120
User340

Joined:

Feb 28, 2007

Posts:

3,001

I've got 3 feature requests:
#1: Add support for right-clicking a search result, have it do what the 3 dots on the right do currently.
#2: Automatically highlight the first result, the one on top.
#3: Add ability to set the default action when double-clicking or pressing return on a search result. I almost never want it to select the asset, I almost always select "Open Asset".

Maybe I'm missing something. Is there a way to set the "Default Action"?

Last edited: May 17, 2019

User340, May 17, 2019

#121
User340

Joined:

Feb 28, 2007

Posts:

3,001

fherbst said: ↑

And another suggestion: could you provide a quick search history?

View attachment 420121
(something like this - could even be smartly sorted based on how often you searched for something, like "last five", "most searched five")
Click to expand...

Yes, I like this idea. To make it even better, have the history displayed by default when nothing is being searched (when you first bring up the dialog). Instead of the instructions that are there currently. That should address the UX concerns.

User340, May 17, 2019

#122
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

HonorableDaniel said: ↑

I've got 3 feature requests:
#1: Add support for right-clicking a search result, have it do what the 3 dots on the right do currently.
#2: Automatically highlight the first result, the one on top.
#3: Add ability to set the default action when double-clicking or pressing return on a search result. I almost never want it to select the asset, I almost always select "Open Asset".

Maybe I'm missing something. Is there a way to set the "Default Action"?
Click to expand...

Hi,

#1 You should be able to press Alt+Right to open that same menu on the selected item.
#2 There were some UX issues by doing so, . I do not remember then all now, but I'll try to find the reasons and I'll get back to you.
#3 We've discussed the ability to set the default action, but that would requires some more advance/complexe UI to allow that per provider. We might add this in the future, but for now we are trying to keep the settings and the UI as simple as possible.

You can try to use all the Alt+Left, Right, Down, Up keyboard shortcuts to do more things. Try it out.

jonathans42, May 18, 2019

#123
User340

Joined:

Feb 28, 2007

Posts:

3,001

Suggestion: Rename "search anything..." too "Quick Search". Please see attachment for more details.

User340, May 18, 2019

#124
User340

Joined:

Feb 28, 2007

Posts:

3,001

jonathans42 said: ↑

#2 There were some UX issues by doing so, . I do not remember then all now, but I'll try to find the reasons and I'll get back to you.
Click to expand...

Ok, sounds good.

jonathans42 said: ↑

You can try to use all the Alt+Left, Right, Down, Up keyboard shortcuts to do more things. Try it out.
Click to expand...

Thx for the tip.

User340, May 18, 2019

#125
Baste

Joined:

Jan 24, 2013

Posts:

6,334
jonathans42 said: ↑

If you try the new (experimental) indexed asset provider (see quick search settings) you should be able to simply type: "prefab player" or "player prefab" or even "pla pref" since we also match the asset file extension. You can also use the * wildcard, but that might be slow depending on the amount of assets you have in your project, i.e. "pl*.prefab".
Click to expand...

Just tried this, and it works excellently! The quick search is a whole lot better with this. Thanks!

Minor thing; getting occasional exceptions when I'm recompiling code:

Code (csharp):

IOException: Could not create file "C:\Mesmer\Library\~quicksearch.index". File already exists.

System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share, System.Int32 bufferSize, System.Boolean anonymous, System.IO.FileOptions options) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.IO.FileStream..ctor (System.String path, System.IO.FileMode mode, System.IO.FileAccess access, System.IO.FileShare share) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

(wrapper remoting-invoke-with-check) System.IO.FileStream..ctor(string,System.IO.FileMode,System.IO.FileAccess,System.IO.FileShare)

Unity.QuickSearch.Providers.FileEntryIndexer.UpdateIndexes (System.String[] paths, System.Collections.Generic.IEnumerable`1[T] words, System.String saveIndexBasePath) (at Library/PackageCache/com.unity.quicksearch@1.1.0-preview.1/Editor/Providers/FileEntryIndexer.cs:198)

Unity.QuickSearch.Providers.FileEntryIndexer.BuildWordIndexes () (at Library/PackageCache/com.unity.quicksearch@1.1.0-preview.1/Editor/Providers/FileEntryIndexer.cs:257)

System.Threading.ThreadHelper.ThreadStart_Context (System.Object state) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ThreadHelper.ThreadStart () (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

UnityEngine.UnhandledExceptionHandler:<RegisterUECatcher>m__0(Object, UnhandledExceptionEventArgs)

Code (csharp):

ThreadAbortException

System.Int32.CompareTo (System.Int32 value) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

Unity.QuickSearch.Providers.FileEntryIndexer.SortWordEntryComparer (Unity.QuickSearch.Providers.FileEntryIndexer+WordIndexEntry item1, Unity.QuickSearch.Providers.FileEntryIndexer+WordIndexEntry item2) (at Library/PackageCache/com.unity.quicksearch@1.1.0-preview.1/Editor/Providers/FileEntryIndexer.cs:341)

System.Collections.Generic.ArraySortHelper`1[T].PickPivotAndPartition (T[] keys, System.Int32 lo, System.Int32 hi, System.Comparison`1[T] comparer) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Collections.Generic.ArraySortHelper`1[T].IntroSort (T[] keys, System.Int32 lo, System.Int32 hi, System.Int32 depthLimit, System.Comparison`1[T] comparer) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Collections.Generic.ArraySortHelper`1[T].IntrospectiveSort (T[] keys, System.Int32 left, System.Int32 length, System.Comparison`1[T] comparer) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Collections.Generic.ArraySortHelper`1[T].Sort (T[] keys, System.Int32 index, System.Int32 length, System.Comparison`1[T] comparer) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

Rethrow as InvalidOperationException: Failed to compare two elements in the array.

System.Collections.Generic.ArraySortHelper`1[T].Sort (T[] keys, System.Int32 index, System.Int32 length, System.Comparison`1[T] comparer) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Collections.Generic.List`1[T].Sort (System.Comparison`1[T] comparison) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

Unity.QuickSearch.Providers.FileEntryIndexer.BuildPartialIndex (System.String basis, System.String[] entries, System.Func`2[T,TResult] skipEntryHandler) (at Library/PackageCache/com.unity.quicksearch@1.1.0-preview.1/Editor/Providers/FileEntryIndexer.cs:319)

Unity.QuickSearch.Providers.FileEntryIndexer.BuildWordIndexes () (at Library/PackageCache/com.unity.quicksearch@1.1.0-preview.1/Editor/Providers/FileEntryIndexer.cs:251)

System.Threading.ThreadHelper.ThreadStart_Context (System.Object state) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ExecutionContext.RunInternal (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state, System.Boolean preserveSyncCtx) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ExecutionContext.Run (System.Threading.ExecutionContext executionContext, System.Threading.ContextCallback callback, System.Object state) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

System.Threading.ThreadHelper.ThreadStart () (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

UnityEngine.UnhandledExceptionHandler:<RegisterUECatcher>m__0(Object, UnhandledExceptionEventArgs)
Baste, May 20, 2019

#126

SirIntruder likes this.
User340

Joined:

Feb 28, 2007

Posts:

3,001

jonathans42 said: ↑

Hi,

#1 You should be able to press Alt+Right to open that same menu on the selected item.
#2 There were some UX issues by doing so, . I do not remember then all now, but I'll try to find the reasons and I'll get back to you.
#3 We've discussed the ability to set the default action, but that would requires some more advance/complexe UI to allow that per provider. We might add this in the future, but for now we are trying to keep the settings and the UI as simple as possible.

You can try to use all the Alt+Left, Right, Down, Up keyboard shortcuts to do more things. Try it out.
Click to expand...

Just to clarify, are you going to add right-click support according to #1? This would be a useful addition.

User340, May 21, 2019

#127
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Baste said: ↑

Minor thing; getting occasional exceptions when I'm recompiling code:
Click to expand...

Thanks for the feedback. The first exception has been fixed already and should be in the next update. As for the second one it's a bit more tricky. I am still trying to get a proper fix for it. I'll let you know when it is fixed. That said, the excpetion does not cause any major issues, it mostly just annoying. We'll still get a fixed for it as soon as possible.

jonathans42, May 21, 2019

#128
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

HonorableDaniel said: ↑

Just to clarify, are you going to add right-click support according to #1? This would be a useful addition.
Click to expand...

Sebastien is working on that and it should be available in the next update. I'll let him show a preview of it.

jonathans42, May 21, 2019

#129

User340 likes this.
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514
Baste said: ↑

ThreadAbortException

System.Int32.CompareTo (System.Int32 value) (at <d7ac571ca2d04b2f981d0d886fa067cf>:0)

Unity.QuickSearch.Providers.FileEntryIndexer.SortWordEntryComparer (Unity.QuickSearch.Providers.FileEntryIndexer+WordIndexEntry item1, Unity.QuickSearch.Providers.FileEntryIndexer+WordIndexEntry item2) (at Library/PackageCache/com.unity.quicksearch@1.1.0-preview.1/Editor/Providers/FileEntryIndexer.cs:341)

Click to expand...

Do you use Quick Search using a dockable window or not? It might happens more if the window is always open between compilation/domain reload.
jonathans42, May 21, 2019

#130
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Baste said: ↑

Just tried this, and it works excellently! The quick search is a whole lot better with this. Thanks!
Click to expand...

One more thing, in the next version the indexed version will also match stuff like Assets/MySuperBigScript.cs with "msbg" or "sbg" or "bg". It will also work the same for Assets/my_super_big_script.cs (same with spaces and dashes).

jonathans42, May 21, 2019

#131

Baste likes this.
Baste

Joined:

Jan 24, 2013

Posts:

6,334

jonathans42 said: ↑

Do you use Quick Search using a dockable window or not? It might happens more if the window is always open between compilation/domain reload.
Click to expand...

I'm not using it as a dockable window, no. It seems like I only have to open the modal window and then close it for this to happen.

Unity likes to sometimes "lose" ScriptableObjects like EditorWindows. This is a fun situation where you have closed the window, but it's still in some internal list of things that need OnEnable to get called on them. This generally causes exceptions to be thrown on every domain reload until you restart Unity.
It's rare, and one of those things that's too hard to repro and too low effort for us to ever bother creating a bug report about, but it might be what you're running into here.

Baste, May 21, 2019

#132
Marble

Joined:

Aug 29, 2005

Posts:

1,268

Could the API / Manual search options use locally installed documentation if available?

Marble, May 21, 2019

#133

User340 likes this.
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Marble said: ↑

Could the API / Manual search options use locally installed documentation if available?
Click to expand...

That's a good idea, we'll see how this could work.

jonathans42, May 21, 2019

#134
Adrian

Joined:

Apr 5, 2008

Posts:

1,065

As an experiment, I tried implementing a search provider for the script reference that allows to directly search the Unity API in Quick Search.

The implementation was straightforward but is there a way for a search provider to influence result order?

I'm using the search index from the online script reference and mimic its search algorithm. As part of the algorithm, it calculates a score for each search result and using this, the ordering in the online search is much better than when I just feed the results into Quick Search.

Adrian, May 23, 2019

#135
Adrian

Joined:

Apr 5, 2008

Posts:

1,065

Since it was simple, I tried to add a priority field to SearchItem and then used that as an additional sorting cirteria in SearchService's SortItemComparer. See the attached screenshots to see how the results got improved:

Without item priority:

With item priority:

For simplicity, I just sorted by the items' priority if the providers' priority is the same but ideally, high-priority results from a low-priority provider could show up above low-priority results from a high-priority provider. Maybe it would make sense to establish some default priorities for providers and items to make sure they mix well together (a bit like shaders' render queue).

As an aside, I was a bit confused that search providers with lower priority values are sorted higher in the list. Shouldn't higher priority values cause the items to appear earlier in the list? This way, the language for low/high priority matches the actual value.

Adrian, May 23, 2019

#136

jonathans42 likes this.
sebastienp_unity

Unity Technologies

Joined:

Feb 16, 2018

Posts:

201

Next version will support a "Score" per item to influence selection order. We use this for Fuzzy search and other search related things.

Would you like to share your search provider on github (as a gist or in a repo)?

Adrian said: ↑

Since it was simple, I tried to add a priority field to SearchItem and then used that as an additional sorting cirteria in SearchService's SortItemComparer. See the attached screenshots to see how the results got improved:

Without item priority:
View attachment 425422

With item priority:
View attachment 425419

For simplicity, I just sorted by the items' priority if the providers' priority is the same but ideally, high-priority results from a low-priority provider could show up above low-priority results from a high-priority provider. Maybe it would make sense to establish some default priorities for providers and items to make sure they mix well together (a bit like shaders' render queue).

As an aside, I was a bit confused that search providers with lower priority values are sorted higher in the list. Shouldn't higher priority values cause the items to appear earlier in the list? This way, the language for low/high priority matches the actual value.
Click to expand...

sebastienp_unity, May 23, 2019

#137

jonathans42 likes this.
Adrian

Joined:

Apr 5, 2008

Posts:

1,065

sebastienp_unity said: ↑

Next version will support a "Score" per item to influence selection order. We use this for Fuzzy search and other search related things.

Would you like to share your search provider on github (as a gist or in a repo)?
Click to expand...

Great!

Yeah, the plan is to publish it as a package but right now it's not really usable. Will wait for the next version and polish it a bit before a first release.

Adrian, May 23, 2019

#138

jonathans42 likes this.
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Adrian said: ↑

Yeah, the plan is to publish it as a package but right now it's not really usable. Will wait for the next version and polish it a bit before a first release.
Click to expand...

Looking forward to see this new search provider. Version 1.2.0 will bring some nice features for search provider authors.

jonathans42, May 24, 2019

#139
Carwashh

Joined:

Jul 28, 2012

Posts:

762

Can we have the ability to customise the short cut please? Alt+' doesn't work for me - I assume because I'm using an Apple keyboard on Windows.

I know the quick search is available via Help -> Quick Search, but using that makes it 'Slowed down quick search'.

Carwashh, May 24, 2019

#140
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Carwashh said: ↑

Can we have the ability to customize the short cut please? Alt+' doesn't work for me - I assume because I'm using an Apple keyboard on Windows.
Click to expand...

Hi, if you have 2019.1 or higher, you can rebind the shortcut with the shortcut manager. See Edit/Shortcuts...., then search for the menu item Help/Quick Search and rebind the shortcut like you want.

Thanks,

jonathans42, May 24, 2019

#141

Carwashh likes this.
fherbst

Joined:

Jun 24, 2012

Posts:

802

@Carwashh I still haven't got feedback from the Shortcut Manager team, but hope that helps you at least in getting into Quick Search, well, quicker: https://forum.unity.com/threads/shortcut-manager-feature-preview.553639/#post-4533244

@jonathans42 That's exactly why I think a different shortcut that works internationally is important as discussed earlier... especially for something that calls itself "Quick Search"!

fherbst, May 24, 2019

#142
sebastienp_unity

Unity Technologies

Joined:

Feb 16, 2018

Posts:

201

Quick unofficial survey:

What would be the best "compromise" shortcut that could/would best fit all the keyboards of the world? Our goal with the shortcut is as follow:

- Must be executable with one hand.
- We aim for the left hand (hence which alt + ' was chosen on Jo's French Canadian keyboard).

F1? shift + f1?
alt + 1?

What else?

fherbst said: ↑

@Carwashh I still haven't got feedback from the Shortcut Manager team, but hope that helps you at least in getting into Quick Search, well, quicker: https://forum.unity.com/threads/shortcut-manager-feature-preview.553639/#post-4533244

@jonathans42 That's exactly why I think a different shortcut that works internationally is important as discussed earlier... especially for something that calls itself "Quick Search"!
Click to expand...

sebastienp_unity, May 24, 2019

#143
Carwashh

Joined:

Jul 28, 2012

Posts:

762

Don't use alt! I like shift+F1 .. I'm in the UK, don't know if that works everywhere.

Carwashh, May 24, 2019

#144
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

fherbst said: ↑

@jonathans42 That's exactly why I think a different shortcut that works internationally is important as discussed earlier... especially for something that calls itself "Quick Search"!
Click to expand...

I totally agree with you. It's a bit out of scope for Quick Search to also change the Shortcut Manager, but I'll pass the word around. I use a French Canadian keyboard myself and I usually have to remap many shortcuts.

Thanks,

jonathans42, May 24, 2019

#145
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Carwashh said: ↑

Don't use alt! I like shift+F1 .. I'm in the UK, don't know if that works everywhere.
Click to expand...

I also like only F1, here's the bindings I use on Windows (a mix of vscode and Visual Assist shortcuts):

jonathans42, May 24, 2019

#146
fherbst

Joined:

Jun 24, 2012

Posts:

802

Regarding "What would be the best "compromise" shortcut that could/would best fit all the keyboards of the world?" - I'm not sure how the Shortcut Manager in general is supposed to handle shortcuts that don't exist on a specific keyboard layout - if it did some kind of "automatic re-layouting" all would be good with what you have right now... see https://hacks.mozilla.org/2017/03/internationalize-your-keyboard-controls/ for browsers actually doing this.

That being said -
I remapped Quick Search to Alt + X, pressable with one hand and still in typing area (F1 is too far, you have to get away and back from typing position).
Fast to press on many keyboards is sth like "Shift + E" (which is actually not taken yet in Shortcut Manager).
Also, I like "Ctrl + Space" - which is also what some other softwares use for Omnibar-style popups.

fherbst, May 24, 2019

#147

jonathans42 likes this.
Huacanacha

Joined:

Aug 16, 2013

Posts:

60

I map to Alt+Space. It's convenient and keeps UX close to Spotlight Search / Alfred on the Mac (which is CMD+Space).

Huacanacha, May 28, 2019

#148

Marble likes this.
jonathans42

Unity Technologies

Joined:

Jan 25, 2018

Posts:

514

Version 1.2.0-preview.1 of Quick Search is out if you wanna give it a shoot. Try the new asset file path indexing (you can enable it in the user preferences).

Thanks,

jonathans42, May 29, 2019

#149
Baste

Joined:

Jan 24, 2013

Posts:

6,334

It seems to be faster!

I think somebody mentioned it earlier, but I think it'd be a great idea to disable search providers that doesn't support a used filter. So, if I write "player controller trefab", the scene search provider should be disabled as it doesn't understand "trefab".

Another minor issue; breaking old habits is hard, and I keep clicking in the project window's search bar before I remember to open the quick search. But when the search bar has focus, the quick search shortcut doesn't work. Is that maybe something that's fixable?

jonathans42 said: ↑

Thanks for the feedback. The first exception has been fixed already and should be in the next update. As for the second one it's a bit more tricky. I am still trying to get a proper fix for it. I'll let you know when it is fixed. That said, the excpetion does not cause any major issues, it mostly just annoying. We'll still get a fixed for it as soon as possible.
Click to expand...

Just to confirm: The first exception did indeed get fixed, the second one is still there, only when the file system indexing is turned on.

Huacanacha said: ↑

I map to Alt+Space. It's convenient and keeps UX close to Spotlight Search / Alfred on the Mac (which is CMD+Space).
Click to expand...

On Windows that opens this menu for all programs:

Nobody knows why alt+space does that. Nobody wanted that menu in the first place. But it's a conflict

Baste, May 29, 2019

#150

fherbst likes this.

(You must log in or sign up to reply here.)

Page 3 of 19