Question about if this = true && other name is this || this name then do something

Hi everyone. I wanted to check and see if what Im writing is interpreted in unity as such.

Im trying to say:
if (RunCollisionOnce == true && other.gameObject.name == "ninjato" || other.gameObject.tag == "Weapon")

I need it to read as, if RunCollisionOnce == true AND IF other.gameObject.name == "ninjato" OR ITS NAME IS other.gameObject.tag == "Weapon"

I wanted to make sure its not saying if RunCollisionOnce == true && other.gameObject.name == "ninjato" OR IF ONLY other.gameObject.tag == "Weapon") then do something.

I want to make sure this is not read as if the first two are true together OR the second one only is true then run. I want it to run only if the first statement is true AND the other game objects tag or name is ONE of the two ALSO.

 

Without parantheses, the expression will be the same as (A && B) || C, because ANDs do usually have higher precedence than ORs.

Your attempts to describe the desired logic are a bit confusing, but it seems you want A && (B || C).

Even if you wanted the first logic, it'd be good to put parentheses for the sake of readability. You wouldn't have those moments in which you need to think about precedence.

If you want to be any clearer, you can use something like:

Code (csharp):

1.  
2.  
3. var hasNameOrTag = (other.gameObject.name ==  "ninjato") || other.gameObject.CompareTag("Weapon");
4. // or the longer version
5. // var hasNinjatoName = other.gameObject.name == "ninjato";
6. // var hasWeaponTag = other.gameObject.CompareTag("Weapon");
7. // var hasNameOrTag = hasNinjatoName || hasWeaponTag;
8.  
9. if (RunCollisionOnce && hasNameOrTag)
10. {
11.     ...
12. }
13.  

 

so confused is || and or is &&?

 

|| = or
&& = and

 

Which is AND and Which is OR? between these two codes "||" "&&"

 

Thanks.................

 

For the sake of completeness, strictly speaking | = 'Or' and & = 'And', whereas || = 'OrElse' and && = 'AndAlso' (Not sure if the names are universally used, but it's how I originally saw them referred to and how I differentiate them in my mind).

Take a look at the documentation for short circuited Boolean operators to see how they differ from the others. If the difference isn't understood, incorrect usage can lead to undesired behaviour.
https://docs.microsoft.com/en-us/do...l-operators#conditional-logical-and-operator-
https://docs.microsoft.com/en-us/do...l-operators#conditional-logical-and-operator-

 

And to beat a dead horse, hare are some guidelines I try to adhere to, simply because it makes life so much easier to me:

• NEVER compare a bool to true or false. Always write "if (myBool) { do this }" or "if (!myBool) { do that}
• Always use parantheses. It may be annoying to write, but you won't fall into the order of precendence trap, especially if you are using a not (!) operator.
• Never try to invert an AND or OR operator in your head. I've got more than 30 years of programming experience under my belt, and simply know that I'll screw up because I'm human.
• Use linebreaks for clarity, i.e. when you have multiple guards strung together by a conjunction, use a linebreak

Code (CSharp):

1. if ((a < b) &&
2.     (a < x) &&
3.     (stillAlive) ) {
4.        do some funky stuff
5. }

And finally: if you are mixing && and || in the same expression without parantheses, you are probably getting it wrong.