Profiler, which lines are editor related?

Thanks for bringing it up. We're actually working on filtering the profiler output so it more cleanly separates this stuff. Part of that approach is about filtering EditorOnly safety allocations out from Hierarchy view (Reasoning: if you're scrubbing frames to get your player loop GC.Alloc free, you shouldn't see anything you don't have to do anything about) and de-emphasizing it in Timeline (i.e. grey it out, mark as EditorOnly, don't show child nodes. Reasoning: we can't hide time but we also want to emphasis the actionable stuff)

Another thing we're looking at is to more clearly mark what happens in player loop over editor loop by adding root markers. This means an additional line in Timeline and an additional foldout in Hierarchy but we're looking to auto expand it in Hierarchy and the timeline view's vertical space issue is getting addressed so hopefully that extra line won't hurt too much. Especially since this would also be there when profiling a player build.

All the Editor Only stuff that we'd hide/collaps would become available as soon as you hit "Profile Editor" in case you're working on Asset Store Packages

I'm interested to hear what you think of this and if that would help you.

Regarding your markers, Watermark probably is the "DevelopementBuild" text in the lower right corner of the screen. EditorOverhead might be rendering Editor UI and logic or just generally time that is unaccounted for while profiling the player loop within the editor.

Even with our filtering, the cleanest profiling you can get is still from profiling a player build instead of the editor though, as there is always going to be stuff that interferes while profiling the editor.

 

Right, I should've been more specific when I said player builds. While profiling a standalone Win/Mac build gets rid of all the editor overhead, there are obviously still OS and hardware specific gotchas. Like a mobile phone OS throttling CPU if the phone overheats.
To maybe sacrifice those shiny 60 fps so that the phone will stay colder and the performance more stable is not the most intuitive thing, especially if you're not profiling on device.

 

Just a small update on this, from 2018.3 on, the Profiler toplevel markers are in. The player running within the Editor is underneath the PlayerLoop sample and the Editor related stuff under Editor Loop. When "Profile Editor" is active, everything is underneath the EditorLoop sample.

Samples that only occur in the Editor (e.g. safety checks) will show up as "EditorOnly [SomeMethodName]" and their GC value will be shown but not added to that of the encompassing sample. Also, any samples underneath those will be hidden, including the GC.Alloc. If you want to see those, there's an option menu in the CPU Hierarchy view toolbar to toggle the collapsing of these samples.


Note that in the above, the surrounding GC Alloc values don't seem to change because the error logs for this particular EditorOnly sample are so heavy in GC Allocs, that the collapsed 64B get lost to the rounding in the UI (Player loop is the only place where it does show).

 

Hi @daniozi117,
I don't see how this relates to the thread but please do submit a bug report with an editor.log and crashlog and details on how to reproduce the crash. See this for more details on how to submit a bug report: https://unity3d.com/unity/qa/bug-reporting

Thank you