ProBuilder version (4.3.1) does not compile in older Unity versions

Hi, I'm an avid user of ProBuilder (4.2.3). I noticed there was a new version for ProBuilder and wanted to try it out. I'm currently using Unity 2018 and in this version of Unity there will be a compile error:

This derives from: https://github.com/Unity-Technologi.../blob/master/Editor/EditorCore/ShapeEditor.cs where System.Reflection is used twice for older versions, because line 3 is:

Code (CSharp):

1. using System.Reflection;

And line 11 is:

Code (CSharp):

1. #if !UNITY_2019_3_OR_NEWER
2. using System.Reflection;
3. #endif

So sure enough the error makes sense. Of course I can update Unity to 2019, but that won't fix the core problem.

Can this be fixed so that I can enjoy the great amount of bug fixes in the new ProBuilder version?

I'm sorry if this isn't the best place to put it, I would love to hear if I should be handling this in a different manner. Thank you!

 

Thank you! While not directly related to this thread: is this the best way to report these bugs (as in: create new threads in this forum)?

 

I noticed that the pull request(s) are closed, most likely due to not being able to reproduce this. The reason why it is not reproducible is because in my project warnings like these are regarded as errors, similar to: https://answers.unity.com/questions/216838/how-to-force-warnings-as-errors.html basically having -warnaserror+ assigned.

The closed pull requests:

• https://github.com/Unity-Technologies/com.unity.probuilder/pull/302
  
• https://github.com/Unity-Technologies/com.unity.probuilder/pull/301

So technically it's not ProBuilder's fault, but it's still unclean code and in my case causing a situation where I cannot use newer ProBuilder versions unless this warning is fixed. I'm stuck at older versions.

-EDIT-
This is the warning that gets turned to error in my case: Compiler Warning (level 3) CS0105: https://docs.microsoft.com/en-us/dotnet/csharp/misc/cs0105
Unity docs about platform dependent compilation (with this you can define warning = error): https://docs.unity3d.com/Manual/PlatformDependentCompilation.html

Repro steps:
Create a new empty Unity 2018.X project.
Create a new file in Assets, call it msc.rsp and add the -warnaserror+ in it.
Go to Package Manager, find and install ProBuilder 4.3.1

 

I'm running into the same issue with Unity 2019.2.21f1

 

The same issue happens in 2018.4.24f1, because of the warning = error thing mentioned in my previous post. I'm still dependent on ProBuilder having clean code in just this one class there is still no reason to have the same 'using' twice in any circumstance.

-EDIT-
Typo.

 

Thank you! I will await the next update and try it out. I'm sorry if I wasn't clear enough earlier.

 

Can probuilder work on unity 2022?