Possible memory leak

Hello,

I challenged myself to finalize a small prototype of very simple games.
To allow me to better understand the issues and be efficient for the future.

My problem is optimization, I'm not yet an expert, and in programming, it's far from being optimized...

I tried to do my best so that no extra items remained on my scene so useless.

I noticed that when I play I had some small FPS loss, but since nothing is optimized, I don't worry too much.

On the other hand I noticed that when my game goes into gameOver, and if I leave it too long in game Over, my pc lags.

I opened my task manager window, opened the performance tab, Memory and I put game in game Over for a moment, then I clicked on restart.
My surprise to see my memory go down all of a sudden.

Is this what we call memory leak???

 

yes it sounds like you may have a memory leak in your code. You are probably doing something like adding objects to a collection unendingly during your scene.

 

I disabled all the elements of my game to find the culprit, finally it comes from the only script that I did not write xD

 

Code (CSharp):

1.  
2. using System.Collections;
3. using System.Collections.Generic;
4. using UnityEngine;
5.  
6.  
7.  
8.  
9. public class MeshColliderUpdate : MonoBehaviour
10. {
11.     private float time = 0;
12.     SkinnedMeshRenderer meshRenderer;
13.    
14.     void Start()
15.     {
16.         meshRenderer = GetComponent<SkinnedMeshRenderer>();      
17.     }
18.    
19.     void Update()
20.     {
21.         time += Time.deltaTime;
22.         if (time >= 0)
23.         {
24.             time = 0;
25.             UpdateCollider();
26.         }
27.     }
28.  
29.     public void UpdateCollider()
30.     {      
31.         Mesh colliderMesh = new ();
32.         meshRenderer.BakeMesh(colliderMesh);
33.         GetComponent<MeshCollider>().sharedMesh = null;
34.         GetComponent<MeshCollider>().sharedMesh = colliderMesh;
35.     }
36. }

 

Ok the problem comes from :

if (time >= 0)

 

Yeah you're creating a new Mesh every frame:

Mesh colliderMesh = new ();

This is going to result in a memory leak since you never call

Destroy()

on these meshes.

 

Thanks !!!!!!! I'll check it out right now ^^

 

PraetorBlue

You are a real genius, it works, you saved me ^^

So if I understood correctly at each UpdateCollider() a new mesh was created, and since it was not deleted they add it to the memory of my game, is that right?

I tried with Destroy and DestroyImmediate, both work well, can you advise me which one?

 

I would advise - neither.

Rather, make one new Mesh object in Awake, and reuse it constantly.
Destroy it in OnDestroy. (not DestroyImmediate)

 

I don't understand, I need a new mesh every frame, so that it is aligned with the animation of my character.

 

No you don't. You can just keep updating the existing one.

Code (CSharp):

1. private SkinnedMeshRenderer meshRenderer;
2. private Mesh bakedMesh;
3.  
4. private void Awake()
5. {
6.     meshRenderer = GetComponent<SkinnedMeshRenderer>();
7.     bakedMesh = new Mesh();
8. }
9.  
10. private void OnDestroy()
11. {
12.     Destroy(bakedMesh);
13. }
14.  
15. public void UpdateCollider()
16. {
17.     meshRenderer.BakeMesh(bakedMesh);
18.     //etc etc
19. }

 

Wow just perfect, I'm too stupid, I hadn't understood it like that :/
On the other hand, I had succeeded in preventing the memory leak, but I still got an error in the console ... it would surely have caused me problems later.

PraetorBlue spiney199 You are too strong thank you
!!!!!!!!!
!!!!
!!
!​

 

So I don't need all this mess in UPDATE anymore, thanks again ^^