Question Player walks faster while pressing forward/back and any of the side keys

I'm working on a player controller using the character controller component. But, when I hold forward/back and any of the side keys, the player will walk in 2x speed. I have tried to clamp the magnitude. But, it still walks 2x faster.

Code (CSharp):

1.     CharacterController cc;
2.     public Transform cam;
3.     public float sens;
4.     public float speed;
5.  
6.     float xro;
7.  
8.     private void Start()
9.     {
10.         cc = GetComponent<CharacterController>();
11.  
12.         Cursor.lockState = CursorLockMode.Locked;
13.     }
14.  
15.     private void Update()
16.     {
17.         Cursor.visible = true;
18.  
19.         float cam_x = Input.GetAxis("Mouse X") * sens * Time.deltaTime;
20.         float cam_y = Input.GetAxis("Mouse Y") * sens * Time.deltaTime;
21.  
22.         float move_x = Input.GetAxis("Horizontal") * speed * Time.deltaTime;
23.         float move_z = Input.GetAxis("Vertical") * speed * Time.deltaTime;
24.  
25.         xro -= cam_y;
26.         xro = Mathf.Clamp(xro, -90, 90);
27.  
28.         transform.Rotate(0f, cam_x, 0f);
29.         cam.transform.localRotation = Quaternion.Euler(xro, 0f, 0f);
30.  
31.  
32.  
33.         Vector3 movement = new Vector3(move_x, 0, move_z);
34.         movement = Vector3.ClampMagnitude(movement, speed);
35.  
36.         cc.Move(transform.forward * movement.z + transform.right * movement.x);
37.     }

 

You will just want to normalise your input vector before you use it further on. You can also combine it into one Vector3 and then multiply it by speed, etc (after you normalize it), to avoid repeating code.

 

If you're interested in continuing to write your own CC, by all means have at it.

But if you just need one, I like to use this one so I can get back to developing my game.

https://forum.unity.com/threads/a-basic-first-person-character-controller-for-prototyping.1169491/

That controller has run, walk, jump, slide, crouch... it's crazy-nutty!!

 

You are multiplying input by speed * DeltaTime, then Clamping magnitude by speed.
What you should do is clamping input by 1, only after that multiplying by speed * DeltaTime.

By multiplying it with DeltaTime you are making it too low it's never been clamped by speed in the first place.

 

Oohhh, ok. Thank you for the help.

 

To be more precise, it's 1.41421356237 faster.