Player movement script not working

I'm following a tutorial to make a box move left and right, I followed the code exactly but when testing it (holding down A or D) nothing happens. (I'm using Mac, if that helps)

 

Remove the

;

from the end of lines 14 and 19.
Then look at how to write if statements in some C# tutorials.
And next time post codes in code tags, not as screenshots.

 

To insert code to make it readable for others, see the icon on the toolbar.

 

As what BabiAGameStudio said you need to remove the semicolons:
From

Code (CSharp):

1. if (...);
2. {
3.  
4. }

To

Code (CSharp):

1. if (...)
2. {
3.  
4. }

Also if the box moves too slow you can multiply it by a constant.
Last but certainly not least: If you're using FixedUpdate() function. You should use Time.fixedDeltaTime instead of Time.deltaTime

 

No, you actually didn't.

For one there's the extra sprinkled-in semicolons. Those ain't in the tutorial! Every character must be perfect.

Second is you should not be using deltaTime OR fixedDeltaTime. You only use those if YOU are computing a new position for the object, not when you are telling the physics system to apply a force, which is the case here.

Perhaps this will save you some time in the future:

Tutorials and example code are great, but keep this in mind to maximize your success and minimize your frustration:

How to do tutorials properly:

Tutorials are a GREAT idea. Tutorials should be used this way:

Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly. Fortunately this is the easiest part to get right.

Be a robot. Don't make any mistakes. BE PERFECT IN EVERYTHING YOU DO HERE.

If you get any errors, learn how to read the error code and fix it. Google is your friend here. Do NOT continue until you fix the error. The error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost. If you want to learn, you MUST do Step 2.

Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!

Finally, when you have errors...

Remember: NOBODY here memorizes error codes. That's not a thing. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

The complete error message contains everything you need to know to fix the error yourself.

The important parts of the error message are:

- the description of the error itself (google this; you are NEVER the first one!)
- the file it occurred in (critical!)
- the line number and character position (the two numbers in parentheses)
- also possibly useful is the stack trace (all the lines of text in the lower console window)

Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors. Often the error will be immediately prior to the indicated line, so make sure to check there as well.

All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

 

Thank you it works now! This is my first time using unity and I can't believe I missed that : /

 

Thank you for the advice, now that the code works I feel motivated to keep moving forward!