Search Unity

Performance Improvements To Text Serialization In 2019.3

Discussion in '2019.3 Beta' started by harryr, Apr 15, 2019.

  1. fherbst

    fherbst

    Joined:
    Jun 24, 2012
    Posts:
    429
    @superpig it's toggled on and off with an identical name when repeatedly calling "AssetDatabase.ForceReserializeAssets" (and commiting the changes inbetween calls). The version number did only change on the first call.
     
  2. AlkisFortuneFish

    AlkisFortuneFish

    Joined:
    Apr 26, 2013
    Posts:
    706
    It does work, it's just *hugely* finicky to configure correctly and rather neglected in general. So, agreeing with the general sentiment but we have had it working in our studio.
     
    Ramobo likes this.
  3. Lorash

    Lorash

    Joined:
    May 6, 2019
    Posts:
    68
    Nothing. I was being sarcastic. :)
     
    Ramobo likes this.
  4. Lorash

    Lorash

    Joined:
    May 6, 2019
    Posts:
    68
    These conventions apply to your public stuff, no underscores simply means to not do
    public int Something_Like_This;
    . There is deliberately no convention for private members.
     
  5. fherbst

    fherbst

    Joined:
    Jun 24, 2012
    Posts:
    429
    @harryr @superpig why I was still not able to reproduce this in an fresh project (seems the reordering happens with certain complexity, haven't figured out yet which that is), to give you an overview of the massive amount of that going on:

    Repeatedly forcing reserialization a project with ~5000 files results in 202 of those having reorderings, all of them either .unity or .prefab. Some other files have options toggled.

    m_UseShadowmask toggling happens as can be seen here (that's all changes for this file). No m_ShadowMaskMode and no m_UseShadowMask here, that file underwent reserialization on that exact Unity version already multiple times.
    upload_2019-12-4_16-23-36.png

    Reorderings all over the place:
    upload_2019-12-4_16-25-20.png

    Another peculiar case: .psd.meta files have the pSDShowRemoveMatteOption toggled on reserialization (again, those files underwent reserialization earlier on the same Unity version)
    upload_2019-12-4_16-27-12.png
     
    phobos2077 and Peter77 like this.
  6. OndrejP

    OndrejP

    Joined:
    Jul 19, 2017
    Posts:
    68
    Jes28 likes this.
  7. OndrejP

    OndrejP

    Joined:
    Jul 19, 2017
    Posts:
    68
    Looking forward to single-line serialization, it's definitely step into right direction, it makes VCS merging easier.
     
  8. Jes28

    Jes28

    Joined:
    Sep 3, 2012
    Posts:
    468
    Does anybody know when one line serialization will arrive?
     
  9. harryr

    harryr

    Unity Technologies

    Joined:
    Nov 14, 2017
    Posts:
    30
    The new one line serialization setting will be in 2020.1, the default is on for all new projects and off for existing ones.

    Screenshot 2020-01-02 at 11.12.16.png
     
    TextusGames, rwetzold, Jes28 and 3 others like this.
  10. Jes28

    Jes28

    Joined:
    Sep 3, 2012
    Posts:
    468
    Nice to hear :)

    Will it be backported to Unity 2019?
     
    OndrejP, BTStone and Peter77 like this.
  11. harryr

    harryr

    Unity Technologies

    Joined:
    Nov 14, 2017
    Posts:
    30
    Apologies, no plans to backport as this is a new feature and 2019.3 is now in a stabilizing phase before release :)
     
  12. Deozaan

    Deozaan

    Joined:
    Oct 27, 2010
    Posts:
    616
    So it will be at least March 2021 before people sticking to LTS releases will see it. :(
     
    Lorash and sand_lantern like this.
  13. fherbst

    fherbst

    Joined:
    Jun 24, 2012
    Posts:
    429
    One more piece of information about the random file reordering issues that are causing us tons of woe & git conflicts were non should be: not only Scenes and Prefabs exhibit that, but Timelines as well.

    @harryr
     
unityunity