Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. We have updated the language to the Editor Terms based on feedback from our employees and community. Learn more.
    Dismiss Notice
  3. Join us on November 16th, 2023, between 1 pm and 9 pm CET for Ask the Experts Online on Discord and on Unity Discussions.
    Dismiss Notice

Peer Review Longings

Discussion in 'Scripting' started by Nigey, Dec 13, 2017.

  1. Nigey

    Nigey

    Joined:
    Sep 29, 2013
    Posts:
    1,129
    Hi Guys,

    tl;dr - Is there a place, or where is the best place to have Unity3D code reviewed online by fellow developers?

    Longer Version

    I'm a lone developer, and I'm missing the ability to go through discussion and code review. I'm pretty certain I'm not alone in the Unity3D landscape there (I bet the opposite).

    I've worked in teams before and have posted code in the forums before. For me, having second opinions on overall architecture, design patterns, and Unity best practices has been invaluable and allowed me to improve, almost as much as a whole level up. I'm very aware that by now becoming a lone developer I can compartmentalise myself and my general methods to program will no longer gain from external influences. It may not continue to grow at the same speed. I've used things like StyleCop and such to enforce C# best practices (modifying to fit Unity3D specifics), and self check for code smells, but you always miss the things you genuinely don't know, or haven't imagined. Which in my opinion, is where you grow the most.

    How has other people tackled this? It would be ideal for me to have a website where I can chuck up my code, and say, 'what do you think guys?'. Where I can also look at other people's code for inspiration on improving my code too. Some code I write for clients I'd obviously need to obfuscate, but the overall patterns and methods can be shared.

    What's everyone else's thoughts on this?

    Thanks!
     
  2. MickM

    MickM

    Joined:
    Nov 19, 2012
    Posts:
    166
    Very interesting; the only place I can find somewhat relevant is
    https://codereview.stackexchange.com

    I think the biggest barrier is IP protection concerns (valid or otherwise). Obviously not an issue within a team but when you are working on something that you (potentially) intend to publish commercially, handing over code (design etc) comes with some risks.

    I personally think it is a great idea, as someone that has never worked professionally in a programming environment, one of the biggest shortfalls I am cognisant of is the fact that both my design patterns and implementations are developed in isolation.

    I guess the closest current way is request for feedback on the design and scripting sub forums... but I would certainly be interested in something more organised. I also think the mentorship opportunities this would provide are quite valuable.... but all of this is taking away time from the project the individual is working on so there remains a willingness to volunteer time (Much moreso than the current replying to specific questions).

    Feel free to keep me in the loop anyway