Optimization on script!!! Help!

in my game the player can pick up diferent kind of items, i have somethig like this:

void OnTriggerEnter(Collider other){
switch(other.tag){
case ("Bullet"):
//Something
break;
case("Red"):
//Something
break;
case("SpeedUp"):
//Something
break;
case("SpeedDown"):
//something
break;
case("Valid"):
//something
break;
.
.
etc................
}
}
}

this is in my player script, is better this way or write a scrip for each item that send a message to the player when the item is picked up????

 

I would make a base class called ItemPickup. Then you can extend that class so that each object does something different when it is picked up.

Code (csharp):

1. public abstract class ItemPickup : MonoBehaviour
2. {
3.   public abstract void DoPickup();
4. }

Then your player can change that switch statement to this.

Code (csharp):

1. void OnTriggerEnter(Collider c) {
2.   ItemPickup itemCheck = c.GetComponent<ItemPickup>();
3.   if (itemCheck != null) itemCheck.DoPickup();
4. }

Alternatively, you can have ItemPickup check for the player then run DoPickup() itself if it detects it collided with the player.

 

Since you're asking if there's a better way, I hope you don't mind if I go on a small tangent

Do you know about polymorphism in OO design? What I'd suggest you do is make a base Item class, like this:

Code (CSharp):

1. public class Item : MonoBehaviour
2. {
3.     public virtual void PickUp(Player player)
4.     {
5.         Debug.Log("Picked up " + name);
6.     }
7. }

Then, you can make your specific item scripts derive from Item, and then override the PickUp method to have other effects. As an example:

Code (CSharp):

1. public class SpeedUp : Item
2. {
3.     public override void PickUp(Player player)
4.     {
5.         base.PickUp(player);
6.         player.speed += 1f;
7.     }
8. }

EDIT: Looks like I was beaten to it!

 

lol at least we can be reasonably sure this is a good way to handle this case!

 

thank very much you both!!, i'll will the use the inheritance and the override, sometimes when im making my game i forget about all the OO stuff....

 

Good choice. There's nothing inherently wrong with what you were doing... and using a switch statement is far better than multiple if/then statements because the CLR builds a lookup table for switches internally that makes them fast. However, going the OO route will result in much cleaner code.

 

mmmm, but in performance what will be better? stay with my switch code or go for the OO design??
the game is for mobile..

 

6 of one half dozen of the other I think. I would go the cleaner OO route.