Not all jobs are terminating before OnDestroy is called after updating to 2019.1b.10

There is a race condition that sometimes occurs when a Scene is destroyed. Some of the jobs that were scheduled do not terminate before OnDestroy is called. This causes a scheduling conflict because some of those jobs are scheduled to use Allocator.Persistent containers stored in a Monobehaviour. When the Monobehaviour calls NativeHashMap.Dispose(), sometimes those jobs are still scheduled or running, outputting error messages on the console.

Code (CSharp):

1. InvalidOperationException: The previously scheduled job NativeLRUCacheSingle`2:SetJob writes to the NativeArray SetJob.data.cache. You must call JobHandle.Complete() on the job NativeLRUCacheSingle`2:SetJob, before you can deallocate the NativeArray safely.
2. Unity.Collections.LowLevel.Unsafe.AtomicSafetyHandle.CheckDeallocateAndThrow (Unity.Collections.LowLevel.Unsafe.AtomicSafetyHandle handle) <0x159b914b0 + 0x00052> in <3b14123eec6449dcbdce6fe247c0f416>:0
3. Unity.Collections.LowLevel.Unsafe.DisposeSentinel.Dispose (Unity.Collections.LowLevel.Unsafe.AtomicSafetyHandle& safety, Unity.Collections.LowLevel.Unsafe.DisposeSentinel& sentinel) (at /Users/builduser/buildslave/unity/build/Runtime/Export/NativeArray/DisposeSentinel.cs:69)
4. Unity.Collections.NativeHashMap`2[TKey,TValue].Dispose () (at Library/PackageCache/com.unity.collections@0.0.9-preview.17/Unity.Collections/NativeHashMap.cs:685)
5. NativeLRUCacheSingle`2[K,V].Dispose () (at Assets/Scripts/Utility/NativeContainer/NativeLRUCacheSingle.cs:125)
6. ResultCacheSingle`2[Request,Result].OnDestroy () (at Assets/Scripts/Environment/Physics/CalculatorIO/ResultCacheSingle.cs:33)
7.  

Some potentially helpful information:

• The JobHandle that acts on those persistent containers is passed to EntityCommandBufferSystem.AddJobHandleForProducer(inputDeps). I sorta abuse EntityCommandBufferSystem to force jobs to complete at a certain time. A Monobehaviour usually titled [name of EntityCommandBufferSystem]Runner fetches the EntityCommandBufferSystem and manually runs it in FixedUpdate()
• The strange thing is that whenever this error occurs, the next time I run the application, three NativeContainer leak errors appear. Those three NativeContainers are the ones that would've been disposed of had they been disposed of in the previous application run!

If needed I can include a link to the project.

 

It's important that you report these issues together with a reproduction project if you want them to get fixed. If you don't do it, it might be a long time until someone else reports them or until Unity Technologies find them.
https://unity3d.com/unity/qa/bug-reporting

 

Will do!

 

The issue ID is 1144526

That makes sense. It looks like Unity is doing exactly as it should be, so could this bug report become a feature report? Namely, add in a feature that terminates all running jobs upon the destruction of a scene. Otherwise, we'd have to jump through hoops to pass in the JobHandle to the relevant Monobehaviours to wait on right before OnDestroy

 

I want to add that the Script Execution Order that produces the error is
ActorsRunner
BeforePreloaderSyncRunner
PreloaderRunner
BeforeActorsSyncRunner
I may have forgotten to click "Apply" before sending the report package