Normal on modified Standard shader not working

Hello,

I've modified Standard shader so that it can render two textures combined by a mask. Its albedo is all fine but the normal won't come out.



1. Unity's standard shader with normal
2. Unity's standard shader and my shader without normal
3. Unity's standard shader and my shader with normal

I've attached a unitypackage with scene, shaders, and cgincs. I suspect the "#ifdef _NORMALMAP" at "UnityStandardInput.cginc" is false or something. Why is that? How can I modify my shader to make the normal appears?

 

Bump

 

Seen you didn't enable the _NORMALMAP keyword. CustomEditor "StandardShaderGUI" do the job. You need to create your custom editor.

 

Oh I see.

So I skipped creating custom editor and edited the cginc directly to enable the normals by modifying these files:

Code (CSharp):

1.  
2. // Test_UnityStandardCore.cginc
3. half3 PerPixelWorldNormal(float4 i_tex, half4 tangentToWorld[3]) {
4.     half3 tangent = tangentToWorld[0].xyz;
5.     half3 binormal = tangentToWorld[1].xyz;
6.     half3 normal = tangentToWorld[2].xyz;
7.  
8.     half3 normalTangent = NormalInTangentSpace(i_tex);
9.     half3 normalWorld = NormalizePerPixelNormal(tangent * normalTangent.x + binormal * normalTangent.y + normal * normalTangent.z);
10.  
11.     return normalWorld;  
12. }
13.  

Code (CSharp):

1.  
2. // Test_UnityStandardInput.cginc
3. //#ifdef _NORMALMAP
4. half3 NormalInTangentSpace(float4 texcoords) {
5.     float4 mask = tex2D(_MainTex, texcoords.xy);
6.     half3 normalTangent = UnpackScaleNormal(tex2D(_BumpMap, texcoords.xy), _BumpScale) * mask.r +
7.             UnpackScaleNormal(tex2D(_Normal2, texcoords.xy), _BumpScale) * (1 - mask.r);
8.  
9.     return normalTangent;
10. }
11. //#endif
12.  
13.  

But still the normals won't come out at 0 to 1 normal value (_BumpScale). If I fill the normal value with values over 1, some black artifact appears.

 

You should multiple mask.r with _BumpScale and not the unpacked normal.

 

Hmm, it doesn't work. Weirdly it's the same when I use only the first normal.

Code (CSharp):

1. normalTangent = UnpackScaleNormal(tex2D(_BumpMap, texcoords.xy), _BumpScale);

 

I try. It seem working.

Code (CSharp):

1.     float4 mask = tex2D(_MainTex, texcoords.xy);
2.     half3 normalTangent = UnpackScaleNormal(tex2D(_BumpMap, texcoords.xy), _BumpScale * mask.r)+
3.                             UnpackScaleNormal(tex2D(_Normal2, texcoords.xy), _BumpScale * (1 - mask.r));
4.  

 

Was my PerPixelWorldNormal wrong? What did I miss?

 

Here the shader file.

 

Ow man it (magically) works by creating the editor!

Thank you @tsangwailam