Search Unity

Question NetworkStream.ReadByte function randomly stutters, pausing all inputs for the duration

Discussion in 'Scripting' started by Pontus_Forsmark, May 10, 2023.

  1. Pontus_Forsmark

    Pontus_Forsmark

    Joined:
    Oct 3, 2022
    Posts:
    2
    The Problem
    I am using a hokuyo uam-05lp-t301 sensor as input for a Unity application, every frame it sends data via ethernet to computer. Normally it only takes around 10-20ms to get this data into Unity using NetworkStream.ReadByte, according to the profiler. Sometimes the application freezes and the profiler tells me the ReadByte function takes 2000ms or even 6000 in some cases. The application is completely unusable during this time.
    It seems to happen quite randomly but more often when I actually interact with the sensor.

    Screen cap of unity profiler at the frozen frame:


    Here is the function that performs the byte reading:
    Code (CSharp):
    1. static string ReadLine(NetworkStream stream)
    2. {
    3.     if (stream.CanRead)
    4.     {
    5.         StringBuilder sb = new();
    6.         bool is_NL2 = false;
    7.         bool is_NL = false;
    8.         do
    9.         {
    10.             profMarker.Begin();
    11.             char buf = (char)stream.ReadByte();
    12.             profMarker.End();
    13.             if (buf == '\n')
    14.             {
    15.                 if (is_NL)
    16.                 {
    17.                     is_NL2 = true;
    18.                 }
    19.                 else
    20.                 {
    21.                     is_NL = true;
    22.                 }
    23.             }
    24.             else
    25.             {
    26.                 is_NL = false;
    27.             }
    28.             sb.Append(buf);
    29.         } while (!is_NL2);
    30.         return sb.ToString();
    31.     }
    32.     else
    33.     {
    34.         return null;
    35.     }
    36. }
    I don't understand networking enough to see why this is happening or how I can fix it.

    What I have Tried
    When I put the ReadLine function in a thread the application no longer freezes and the framerate is much higher, but the input from the sensor still stops for the 2-6 seconds. Using a thread is definitely preferable but not a solution.
    I have tried adding ReceiveTimeout to the TCP Client thinking it might just skip the data for the frame if it takes too long. This mostly stops the application from freezing but the input still doesn't work for a few seconds. It also generates an error:
    "
    SocketException: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
    Rethrow as IOException: Unable to read data from the transport connection: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.

    "

    Any advice would be helpful as this issue severely affects the usability of the application. Let me know if more info is required.
     
  2. Bunny83

    Bunny83

    Joined:
    Oct 18, 2010
    Posts:
    3,990
    Even thought it is transported over a packet based protocol (IP), the TCP protocol is an endless streaming protocol. So data isn't nicely grouped into packets. You seem to read "lines" from the stream, so you're reading character by character until you hit a new line character. However if the input buffer of the stream is currently empty, when calling ReadByte, the ReadByte method would block until new data has arrived. That's because you run the socket in normal "blocking mode". It's possible to read from a socket asynchronously by using BeginRead. However that means the actual reading is done in a callback.

    I prefer to work in blocking mode but do the actual receiving inside a receiving thread that I start myself. Of course you would need some sort of synchronisation between the receiving thread and Unity's main thread. Though a ConcurrentQueue<string> is usually enough. The queue takes care about proper locking / syncing and your receiving thread can simply enqueue newly assembled strings and your Unity code can simply TryDequeue a string from the queue.

    So a thread is almost always required for any kind of network communication. I can't say why it may freeze. I don't know what kind of protocol you're dealing with and if the server is actually flushing the buffer after each line to make sure the latest info is actually send out. It seems that you always read multiple lines and only return when you receive an empty line (two \n in a row). Is that really the specification of the protocol?
     
  3. Pontus_Forsmark

    Pontus_Forsmark

    Joined:
    Oct 3, 2022
    Posts:
    2
    Thank you for the response. I don't really understand what you wrote in your first two paragraphs, I am new to networking and find it difficult to understand.

    I can confirm that I am using a thread for reading as that gives 100+ fps instead of barely 30 when not using a thread, but the problem is the freezing.

    All the sensor data gets in to unity as it should so I would assume it is correct to return at an empty line like it does.