Network Proximity Checker and major FPS drop with large GC collection

I have 450 objects that use Network Proximity Checker and the servers fps drops by 30 every time it updates. I find it strange that it seems to check every object with the proximity checker if there is a player nearby, rather than checking every player if there are any objects with the proximity checker.

The 450 objects is mainly a test, as my game is going to have a lot more than that. Is this meant only for very small scale games or am I doing something wrong?

I tried with 2,500 objects and the GC allocation went up to 130mb and my fps would drop to 1 from 120 every time it updated.

 

Anybody?
Is there not an option to spread it over multiple frames?

 

Thank you very much!
I have created a couple classes which seem to work a lot faster, I tested with thousands of objects and it was fine
Here is the code if anyone else would like it.

Code (CSharp):

1. using UnityEngine;
2. using System.Collections;
3. using UnityEngine.Networking;
4. using System.Collections.Generic;
5.  
6. // Attach this to objects that need their visibility updated as the player moves around
7. [RequireComponent(typeof(NetworkIdentity))]
8. public class NetworkVisbility : NetworkBehaviour {
9.  
10.     public List<NetworkConnection> playersObserving = new List<NetworkConnection>();
11.     public NetworkIdentity networkIdentity;
12.  
13.     void Awake(){
14.         networkIdentity = GetComponent<NetworkIdentity>();
15.     }
16.  
17.     public override bool OnRebuildObservers(HashSet<NetworkConnection> observers, bool initial){
18.          foreach (NetworkConnection net in playersObserving){
19.             observers.Add(net);
20.         }
21.         return true;
22.     }
23.  
24.     public override bool OnCheckObserver(NetworkConnection newObserver){
25.         return false;
26.     }
27. }

Code (CSharp):

1. using UnityEngine;
2. using System.Collections;
3. using UnityEngine.Networking;
4. using System.Collections.Generic;
5.  
6. // Attach this to player prefab
7. [RequireComponent(typeof(SphereCollider))]
8. public class NetworkPlayerVisibility : NetworkBehaviour {
9.  
10.     [SerializeField]
11.     private int visRadius = 50; // Radius of sphere collider
12.     [SerializeField]
13.     private float visUpdateInterval = 2000; // Update time in ms
14.     private SphereCollider collider;
15.     private List<NetworkVisbility> changedObjects = new List<NetworkVisbility>(); // Objects that have changed visibility
16.     private float visUpdateTime;
17.  
18.     void Awake(){
19.         collider = GetComponent<SphereCollider>();
20.         collider.isTrigger = true;
21.         collider.radius = visRadius;
22.     }
23.  
24.     void Update(){
25.         if (!NetworkServer.active)
26.             return;
27.        
28.         if (Time.time - visUpdateTime > visUpdateInterval){
29.             RebuildChangedObjects();
30.             visUpdateTime = Time.time;
31.         }
32.     }
33.  
34.     void RebuildChangedObjects(){
35.         foreach (NetworkVisbility net in changedObjects){
36.             net.networkIdentity.RebuildObservers(false);
37.         }
38.         changedObjects.Clear();
39.     }
40.  
41.     void OnTriggerEnter(Collider col){
42.         NetworkVisbility net = col.GetComponent<NetworkVisbility>();
43.         if (net != null && connectionToClient != null){
44.             net.playersObserving.Add(connectionToClient);
45.             changedObjects.Add(net);
46.         }
47.     }
48.  
49.     void OnTriggerExit(Collider col){
50.         NetworkVisbility net = col.GetComponent<NetworkVisbility>();
51.         if (net != null && connectionToClient != null){
52.             net.playersObserving.Remove(connectionToClient);
53.             changedObjects.Add(net);
54.         }
55.     }
56.  
57.     // Use these to update radius and interval in game
58.     public void SetVisualRadius(int radius){
59.         visRadius = radius;
60.         collider.radius = radius;
61.     }
62.  
63.     public void SetUpdateInterval(float interval){
64.         visUpdateInterval = interval;
65.     }
66.  
67. }
68.  

 

So @Teedo145 the first script you posted would be used for NPC objects?

 

@Teedo145 Is it possible to let your script work without trigger enter/exit? Cause it interferes with my combat system wich uses a trigger box... Would like to use Physics.OverlapSphere like the original, but it lacks the option to remove a client from the playersObserving list like you do in trigger exit. Any thoughts?

 

You could keep a record of the entities that are observed each time you use OverlapSphere, and drop visibility from those that are no longer in range.

 

@Teedo145 I am using your altered proximity checker and I love it! Have a weird problem now tho.. It all works fine the first time a client connects and plays. But when I quit and reconnect the server trows a lot of warnings for all objects affected by the checker. Weird part is that it all still works but it just trows a lot of warnings:



Also when I check the obeservers of a BlackPine I see this:



Do you have any ideas??

 

Anyone?

It looks like the connection is reused or something and bugs the observer list after a reconnect..

 

Any Unity staff? Do I need to bug report? Cause it looks like a bug to me... (Bottom screenshot observers)

 

bump

 

I hate to necro but this is because your connection isn't set to ready (see in connectionId: 1 isReady: false). If anyone else has this issue, make sure you are checking that the connection is ready