Search Unity

  1. Welcome to the Unity Forums! Please take the time to read our Code of Conduct to familiarize yourself with the forum rules and how to post constructively.
  2. Dismiss Notice

Need help

Discussion in 'Scripting' started by camory88, May 28, 2021.

  1. camory88

    camory88

    Joined:
    Mar 28, 2021
    Posts:
    2
    I am geting this Error and cant find how to fixit
    Assets\ToggleSwitch.cs(46,22): error CS1002: ; expected

    This is my script

    using UnityEngine;
    using UnityEngine.UI;
    using UnityEngine.EventSystems;
    using DG.Tweening;

    public class ToggleSwitch : MonoBehaviour
    {
    [SerializeField]
    private bool isOn = false;
    public bool isOn
    {
    get
    {
    return _isOn;
    }
    }

    [SerializeField]
    private RectTransform toggleIndicator;
    [SerializeField]
    private Image backroundImage;

    [SerializeField]
    private Color onColor;
    [SerializeField]
    private Color offColor;
    private float offx;
    private float onx;
    [SerializeField]
    private float tweenTime = 0.25f;

    private AudioSource audioSource;

    public delegate void ValueChange(bool value);
    public event ValueChange valueChanged;

    void Start()
    {
    offx = toggleIndicator.anchoredPosition.x;
    onx = backroundImage.rectTransfor.rect.width - toggleIndicator.rect.width;
    audioSource = this.GetComponent<audioSource>();
    }

    private void OnEnable()
    {
    Toggle(!isOn)
    }

    private void Toggle(bool value, bool playSFX = true)
    {
    if (value != isOn)
    {
    _isOn = value;

    ToggleColor(isOn);
    MoveIndicator(isOn);

    if (playSFX)
    audioSource.play();

    if (valueChanged != null)
    valueChanged(isOn);
    }
    }

    private void ToggleColor(bool value)
    {
    if (value)
    backroundImage.DOColor(onColor, tweenTime);
    else
    backroundImage.DOColor(offColor, tweenTime);
    }

    private void MoveIndicator(bool value)
    {
    if (value)
    toggleIndicator.DOAnchorPosX(onx, tweenTime);
    else
    toggleIndicator.DOAnchorposX(offx, tweenTime);
    }

    public void Update()
    {
    if (Input.GetKeyDown(KeyCode.E))
    {
    Toggle(!isOn);
    }
    }
    }
     
  2. BenniKo

    BenniKo

    Joined:
    Mar 24, 2015
    Posts:
    100
    The error says it all. There is a ; missing at line 46

    Probably here
    Code (CSharp):
    1. Toggle(!isOn);
     
  3. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,756
    Actually you can find how! Here's some guidance.

    First, remember that NOBODY memorizes error codes. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    The important parts of an error message are:
    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

    How to understand compiler and other errors and even fix them yourself:

    https://forum.unity.com/threads/ass...3-syntax-error-expected.1039702/#post-6730855

    If you post a code snippet, ALWAYS USE CODE TAGS:

    How to use code tags: https://forum.unity.com/threads/using-code-tags-properly.143875/

    How to report your problem productively in the Unity3D forums:

    http://plbm.com/?p=220
     
  4. camory88

    camory88

    Joined:
    Mar 28, 2021
    Posts:
    2
    thx for the help i am now geting error CS0102: The type 'ToggleSwitch' already contains a definition for 'isOn'
    if you whould help thanks again
     
  5. BenniKo

    BenniKo

    Joined:
    Mar 24, 2015
    Posts:
    100
    You defined isOn twice.
    You probably wanted to define the private bool this way:
    Code (CSharp):
    1. private bool _isOn = false;
     
  6. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    36,756
    You really need to read what I wrote above about how to process errors and solve them. This forum is definitely not so much a typing service for you to rely on...

    If you're gonna bang your way through tutorials, that's great.

    Here is how to do tutorials properly:

    Tutorials are a GREAT idea. Tutorials should be used this way:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation generally ends in disaster. That's how software engineering works. Every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly. Fortunately this is the easiest part to get right. Be a robot. Don't make any mistakes. BE PERFECT IN EVERYTHING YOU DO HERE.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!
     
    vendaar likes this.