Search Unity

Need help with syntax errors

Discussion in 'Scripting' started by brucehjoyner, Sep 17, 2021.

  1. brucehjoyner

    brucehjoyner

    Joined:
    Mar 24, 2021
    Posts:
    12
    Code (CSharp):
    1. using System.Collections;
    2. using System.Collections.Generic;
    3. using UnityEngine;
    4.  
    5. public class PlayerCombat : MonoBehaviour
    6. {
    7.     [SerializeField] GameObject[] _weapons;
    8.     [SerializeField] float _rateOfFire = 0.2f;
    9.     [SerializeField] GameObject _bullet;
    10.     [SerializeField] Transform _bulletSpawnPoint;
    11.  
    12.     private bool _isArmed = false:
    13.     private bool _isFiring = false;
    14.  
    15.    // Update is called once per frame
    16.     void Update()
    17.     {
    18.         //check to see if armed and if press left mouse button
    19.         if (Input.GetMouseButtonDown(0) && _isArmed)
    20.         {
    21.             //_isFiring set to true
    22.             _isFiring = true;
    23.             StartCoroutine(Firing());
    24.         }
    25.  
    26.         if (Input.GetMouseButtonUp(0) && _isArmed)
    27.         {
    28.             //_isFiring set to true
    29.             _isFiring = false;
    30.         }
    31.     }
    32.  
    33.     public void SetWeapon (Weapon.WeaponType weaponType)
    34.     {
    35.         if (weaponType == weapon.weaponType.Pistol)
    36.         {
    37.             _weapons[0].SetActive(true);
    38.             _isArmed = true;
    39.         }
    40.     }
    41.  
    42.     IEnumerator Firing ()
    43.     {
    44.         while (_isFiring)
    45.         {
    46.             //instantiate a bullet
    47.             GameObject bullet = Instantiate(_bullet, _bulletSpawnPoint.position, Quaternion.identify);
    48.             //fire the bullet in the direction
    49.             bullet.GetComponent<Rigibody>().velocity = transform.forward * 15000 * Time.deltaTime;
    50.             yield return new WaitForSeconds(_rateOfFire);
    51.         }
    52.     }
    53. }
    54.  
    It keeps saying: Assets\Scripts\Weapons\PlayerCombat.cs(12,34): error CS1003: Syntax error, ',' expected
    and: Assets\Scripts\Weapons\PlayerCombat.cs(12,35): error CS1002: ; expected
    Does anyone know how to fix
     
  2. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    19,163
    These are all just fat-finger typos, such as you used a colon (
    :
    ) instead of semicolon (
    ;
    )on line 12. See how the error says (12,34?) That's line 12, character 34. Read more below:

    There are also two outright misspellings in the final function.

    You can fix ALL them yourself. Here is now:

    The complete error message contains everything you need to know to fix the error yourself.

    Always start with the FIRST error in the console window, as sometimes that error causes or compounds some or all of the subsequent errors.

    The important parts of the error message are:

    - the description of the error itself (google this; you are NEVER the first one!)
    - the file it occurred in (critical!)
    - the line number and character position (the two numbers in parentheses)
    - also possibly useful is the stack trace (all the lines of text in the lower console window)

    All of that information is in the actual error message and you must pay attention to it. Learn how to identify it instantly so you don't have to stop your progress and fiddle around with the forum.

    Remember: NOBODY memorizes error codes. The error code is absolutely the least useful part of the error. It serves no purpose at all. Forget the error code. Put it out of your mind.

    If you plan to monkey-hammer bang tutorial code in, let me offer you this to save a LOT of your time with this sorta stuff.

    How to do tutorials properly:

    Tutorials are a GREAT idea. Tutorials should be used this way:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation (even a single character!) generally ends in disaster. That's how software engineering works. Every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly. Fortunately this is the easiest part to get right.

    Be a robot. Don't make any mistakes. BE PERFECT IN EVERYTHING YOU DO HERE.

    If you get any errors, learn how to read the error code and fix it. Google is your friend here. Do NOT continue until you fix the error. The error will probably be somewhere near the parenthesis numbers (line and character position) in the file. It is almost CERTAINLY your typo causing the error, so look again and fix it.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!
     
  3. brucehjoyner

    brucehjoyner

    Joined:
    Mar 24, 2021
    Posts:
    12
    Thanks! This helped me a lot. I didn't know I could read error messages like that.
     
    Kurt-Dekker likes this.
  4. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    19,163
    You're very welcome! The compiler is your friend, he really tries his best to explain what's wrong.

    When the compiler fails to make it clear, hie thee to the Google, and happy coding to you.
     
unityunity