Search Unity

Bug Need help with code

Discussion in 'Scripting' started by Spacetutle808, Jun 16, 2021.

  1. Spacetutle808

    Spacetutle808

    Joined:
    Jun 14, 2021
    Posts:
    1
    Hi, I'm just starting out with unity and following a Brackeys tutorial on FPS movement I tried copying the code exactly, but when I hit play I got a lot of errors

    here's the code

    using System.Collections;
    using System.Collections.Generic;
    using UnityEngine;
    public class Player_Movment : MonoBehaviour
    {
    public CharacterController controller;
    void Update();
    public float speed = 12f;
    float x = Input.GetAxis("Horizontal");
    float z = Input.GetAxis("Vertical");
    Vector3 move = transform.right * x + transform.forward * z;
    controller.Move(move * speed * Time.deltaTime);
    }

    and my errors are
    Assets\Player_Movement.cs(18,16): error CS1519 Invalid token '(' In class, struct, or interface member declaration

    Assets\Player_Movement.cs(18, 30): error CS8124 tuple must contain at least two elements

    Assets\Player_Movement.cs(18,30): error CS1026: ) expected

    Assets\Player_Movement.cs(18,46): error CS1003 Syntax error ( expected

    Thanks if you can help
     
  2. StarManta

    StarManta

    Joined:
    Oct 23, 2006
    Posts:
    8,775
    Use code tags when posting code.

    You didn't copy the code exactly. Pay closer attention to brackets { } and semicolons. You also seem to have put at least one line out of order (no "public" variable can ever be inside a function)
     
    Spacetutle808 likes this.
  3. TheNightglow

    TheNightglow

    Joined:
    Oct 1, 2018
    Posts:
    201
    pls use the code tags when posting code :)


    you made a mistake with your Update method

    you have a line ending right after it with ; and you never open its scope using { }
     
    Spacetutle808 likes this.
  4. Kurt-Dekker

    Kurt-Dekker

    Joined:
    Mar 16, 2013
    Posts:
    38,697
    If you are going to be monkey-typing tutorial code in, it has GOT TO BE 100% PERFECT.

    How to do tutorials properly:

    Tutorials are a GREAT idea. Tutorials should be used this way:

    Step 1. Follow the tutorial and do every single step of the tutorial 100% precisely the way it is shown. Even the slightest deviation generally ends in disaster. That's how software engineering works. Every single letter must be spelled, capitalized, punctuated and spaced (or not spaced) properly. Fortunately this is the easiest part to get right. Be a robot. Don't make any mistakes. BE PERFECT IN EVERYTHING YOU DO HERE.

    Step 2. Go back and work through every part of the tutorial again, and this time explain it to your doggie. See how I am doing that in my avatar picture? If you have no dog, explain it to your house plant. If you are unable to explain any part of it, STOP. DO NOT PROCEED. Now go learn how that part works. Read the documentation on the functions involved. Go back to the tutorial and try to figure out WHY they did that. This is the part that takes a LOT of time when you are new. It might take days or weeks to work through a single 5-minute tutorial. Stick with it. You will learn.

    Step 2 is the part everybody seems to miss. Without Step 2 you are simply a code-typing monkey and outside of the specific tutorial you did, you will be completely lost.

    Of course, all this presupposes no errors in the tutorial. For certain tutorial makers (like Unity, Brackeys, Imphenzia, Sebastian Lague) this is usually the case. For some other less-well-known content creators, this is less true. Read the comments on the video: did anyone have issues like you did? If there's an error, you will NEVER be the first guy to find it.

    Beyond that, Step 3, 4, 5 and 6 become easy because you already understand!
     
    Spacetutle808 likes this.